From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx-mac80211: Set antenna gains if not in sprom
Date: Fri, 3 Aug 2007 23:38:43 +0200 [thread overview]
Message-ID: <200708032338.43593.mb@bu3sch.de> (raw)
In-Reply-To: <46b39d7d.4kGviB6QZBFl2jfv%Larry.Finger@lwfinger.net>
On Friday 03 August 2007 23:26:21 Larry Finger wrote:
> In the sprom for bcm43xx devices, any unprogrammed values are set to all ones.
> In the case of antenna gains, the specs indicate that a gain of 2 dBm should
> be set if no value is stored. This patch implements that provision.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> +++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> @@ -3805,6 +3805,12 @@ static void bcm43xx_sprom_fixup(struct s
> bus->boardinfo.rev > 0x40)
> bus->sprom.r1.boardflags_lo |= BCM43xx_BFL_PACTRL;
>
> + /* Handle case when gain is not set in sprom */
> + if (bus->sprom.r1.antenna_gain_a == 0xFF)
> + bus->sprom.r1.antenna_gain_a = 2;
> + if (bus->sprom.r1.antenna_gain_bg == 0xFF)
> + bus->sprom.r1.antenna_gain_bg = 2;
> +
> /* Convert Antennagain values to Q5.2 */
> bus->sprom.r1.antenna_gain_a <<= 2;
> bus->sprom.r1.antenna_gain_bg <<= 2;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Queued, thanks!
--
Greetings Michael.
prev parent reply other threads:[~2007-08-03 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 21:26 [PATCH] bcm43xx-mac80211: Set antenna gains if not in sprom Larry Finger
2007-08-03 21:38 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708032338.43593.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).