From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jiri Benc <jbenc@suse.cz>, Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: allow drivers to indicate failed FCS/PLCP checksum
Date: Sat, 4 Aug 2007 14:25:28 +0200 [thread overview]
Message-ID: <200708041425.29112.IvDoorn@gmail.com> (raw)
In-Reply-To: <1186177475.13315.10.camel@johannes.berg>
Hi,
> @@ -241,6 +241,8 @@ struct ieee80211_rx_status {
> #define RX_FLAG_MMIC_ERROR (1<<0)
> #define RX_FLAG_DECRYPTED (1<<1)
> #define RX_FLAG_RADIOTAP (1<<2)
> +#define RX_FLAG_FAILED_FCS_CRC (1<<3)
> +#define RX_FLAG_FAILED_PLCP_CRC (1<<4)
> int flag;
> };
This looks good, but there is a slight problem for rt2x00.
The package descriptor knows 3 kind of errors for a received frame:
CRC error
Physical error
Cipher error
For the CRC error I don't know if that is the FCS or PLCP error..
And should the other 2 be also passed to mac80211 or should those
be stopped?
For the cipher error it could perhaps be possible to send it to mac80211
without the RX_FLAG_DECRYPTED bit set. (At the moment rt2x00 doesn't
see this error yet, because hardware encryption is not yet implemented).
Ivo
next prev parent reply other threads:[~2007-08-04 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 21:44 [PATCH] mac80211: allow drivers to indicate failed FCS/PLCP checksum Johannes Berg
2007-08-04 7:53 ` Johannes Berg
2007-08-04 12:25 ` Ivo van Doorn [this message]
2007-08-06 8:07 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708041425.29112.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).