From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] bcm43xx-mac80211: Rescale link quality output
Date: Mon, 6 Aug 2007 14:10:54 +0200 [thread overview]
Message-ID: <200708061410.54552.mb@bu3sch.de> (raw)
In-Reply-To: <46b57c5f.7s2ojiPQUXY5R3Qv%Larry.Finger@lwfinger.net>
On Sunday 05 August 2007, Larry Finger wrote:
> The link quality output from wireless extensions is too small by the ratio
> of 100/BCM43xx_RX_MAX_SSI (60) for bcm43xx-mac80211. This patch puts the
> quantity on the proper scale.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_xmit.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_xmit.c
> +++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_xmit.c
> @@ -537,7 +537,8 @@ void bcm43xx_rx(struct bcm43xx_wldev *de
> (phystat0 & BCM43xx_RX_PHYST0_GAINCTL),
> (phystat3 & BCM43xx_RX_PHYST3_TRSTATE));
> status.noise = dev->stats.link_noise;
> - status.signal = jssi; /* this looks wrong, but is what mac80211 wants */
> + /* the next line looks wrong, but is what mac80211 wants */
> + status.signal = (jssi * 100) / BCM43xx_RX_MAX_SSI;
> if (phystat0 & BCM43xx_RX_PHYST0_OFDM)
> status.rate = bcm43xx_plcp_get_bitrate_ofdm(plcp);
> else
>
>
Queued into my patch series, thanks.
prev parent reply other threads:[~2007-08-06 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 7:29 [PATCH V2] bcm43xx-mac80211: Rescale link quality output Larry Finger
2007-08-05 12:57 ` Michael Buesch
2007-08-05 14:33 ` Larry Finger
2007-08-05 14:43 ` Michael Buesch
2007-08-06 12:10 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708061410.54552.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).