From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC] bcm43xx-mac80211: Add TX power set file to debugfs
Date: Mon, 6 Aug 2007 22:25:58 +0200 [thread overview]
Message-ID: <200708062225.58737.mb@bu3sch.de> (raw)
In-Reply-To: <46b782f6.XGqOxV2KvXubz5jy%Larry.Finger@lwfinger.net>
On Monday 06 August 2007 22:22:14 Larry Finger wrote:
> Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> +++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
> @@ -2762,12 +2762,11 @@ static int bcm43xx_dev_config(struct iee
> }
>
> /* Adjust the desired TX power level. */
> - if (conf->power_level != 0) {
> - if (conf->power_level != phy->power_level) {
> - phy->power_level = conf->power_level;
> - bcm43xx_phy_xmitpower(dev);
> - }
> - }
> + if (conf->power_level != 0 && phy->power_level == 0) {
> + phy->power_level = conf->power_level;
> + } else
> + phy->power_level = 10;
> + bcm43xx_phy_xmitpower(dev);
No, what's that? I disagree with that.
This breaks power adjustment.
>
> /* Hide/Show the SSID (AP mode only). */
> if (conf->flags & IEEE80211_CONF_SSID_HIDDEN) {
>
>
--
Greetings Michael.
next prev parent reply other threads:[~2007-08-06 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 20:22 [RFC] bcm43xx-mac80211: Add TX power set file to debugfs Larry Finger
2007-08-06 20:25 ` Michael Buesch [this message]
2007-08-06 20:36 ` Larry Finger
2007-08-06 20:45 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708062225.58737.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).