From: "John W. Linville" <linville@tuxdriver.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: acme@ghostprotocols.net, Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset
Date: Mon, 6 Aug 2007 20:11:55 -0400 [thread overview]
Message-ID: <20070807001155.GA3285@tuxdriver.com> (raw)
In-Reply-To: <200708070050.23158.m.kozlowski@tuxland.pl>
Please send wireless patches to linux-wireless@vger.kernel.org,
and CC me.
Thanks!
John
On Tue, Aug 07, 2007 at 12:50:22AM +0200, Mariusz Kozlowski wrote:
> Hello,
>
> This memset() looks superfluous.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/wireless/wl3501_cs.c | 58885 -> 58858 (-27 bytes)
> drivers/net/wireless/wl3501_cs.o | 200252 -> 200000 (-252 bytes)
>
> drivers/net/wireless/wl3501_cs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-2.6.23-rc1-mm2-a/drivers/net/wireless/wl3501_cs.c 2007-08-01 08:43:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm2-b/drivers/net/wireless/wl3501_cs.c 2007-08-07 00:34:36.000000000 +0200
> @@ -1841,7 +1841,6 @@ static int wl3501_get_encode(struct net_
> tocopy = min_t(u8, len_keys, wrqu->encoding.length);
> tocopy = min_t(u8, tocopy, 100);
> wrqu->encoding.length = tocopy;
> - memset(extra, 0, tocopy);
> memcpy(extra, keys, tocopy);
> out:
> return rc;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
John W. Linville
linville@tuxdriver.com
next parent reply other threads:[~2007-08-07 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200708070050.23158.m.kozlowski@tuxland.pl>
2007-08-07 0:11 ` John W. Linville [this message]
2007-08-08 5:58 ` [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset Mariusz Kozlowski
2007-08-08 13:20 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807001155.GA3285@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=acme@ghostprotocols.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).