From: Michael Buesch <mb@bu3sch.de>
To: Andrew Morton <akpm@linux-foundation.org>,
John Linville <linville@tuxdriver.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Felix Fietkau <nbd@openwrt.org>,
linux-wireless@vger.kernel.org
Subject: [PATCH] ssb: Fix extif compile error
Date: Tue, 7 Aug 2007 00:54:00 +0200 [thread overview]
Message-ID: <200708070054.00890.mb@bu3sch.de> (raw)
This is a compilation fix for a recently applied patch
[PATCH 2/3] Use SSB EXTIF in SSB MIPS core driver
when the extif core is not enabled.
This also makes the extif driver depend on CONFIG_SSB_DRIVER_EXTIF
(sorry, my mistake).
Signed-off-by: Michael Buesch <mb@bu3sch.de>
--
John, please apply to wireless-dev
Andrew, please apply to -mm after applying the other ssb patches.
Index: wireless-dev/drivers/ssb/main.c
===================================================================
--- wireless-dev.orig/drivers/ssb/main.c 2007-08-07 00:48:15.000000000 +0200
+++ wireless-dev/drivers/ssb/main.c 2007-08-07 00:48:18.000000000 +0200
@@ -819,7 +819,7 @@
u32 plltype;
u32 clkctl_n, clkctl_m;
- if (bus->extif.dev)
+ if (ssb_extif_available(&bus->extif))
ssb_extif_get_clockcontrol(&bus->extif, &plltype,
&clkctl_n, &clkctl_m);
else if (bus->chipco.dev)
Index: wireless-dev/include/linux/ssb/ssb_driver_extif.h
===================================================================
--- wireless-dev.orig/include/linux/ssb/ssb_driver_extif.h 2007-08-07 00:48:15.000000000 +0200
+++ wireless-dev/include/linux/ssb/ssb_driver_extif.h 2007-08-07 00:48:18.000000000 +0200
@@ -20,10 +20,6 @@
#ifndef LINUX_SSB_EXTIFCORE_H_
#define LINUX_SSB_EXTIFCORE_H_
-struct ssb_extif {
- struct ssb_device *dev;
-};
-
/* external interface address space */
#define SSB_EXTIF_PCMCIA_MEMBASE(x) (x)
#define SSB_EXTIF_PCMCIA_IOBASE(x) ((x) + 0x100000)
@@ -156,6 +152,19 @@
/* watchdog */
#define SSB_EXTIF_WATCHDOG_CLK 48000000 /* Hz */
+
+
+#ifdef CONFIG_SSB_DRIVER_EXTIF
+
+struct ssb_extif {
+ struct ssb_device *dev;
+};
+
+static inline bool ssb_extif_available(struct ssb_extif *extif)
+{
+ return (extif->dev != NULL);
+}
+
extern void ssb_extif_get_clockcontrol(struct ssb_extif *extif,
u32 *plltype, u32 *n, u32 *m);
@@ -167,4 +176,23 @@
struct ssb_serial_port *ports);
#endif /* CONFIG_SSB_SERIAL */
+
+#else /* CONFIG_SSB_DRIVER_EXTIF */
+/* extif disabled */
+
+struct ssb_extif {
+};
+
+static inline bool ssb_extif_available(struct ssb_extif *extif)
+{
+ return 0;
+}
+
+static inline
+void ssb_extif_get_clockcontrol(struct ssb_extif *extif,
+ u32 *plltype, u32 *n, u32 *m)
+{
+}
+
+#endif /* CONFIG_SSB_DRIVER_EXTIF */
#endif /* LINUX_SSB_EXTIFCORE_H_ */
--
Greetings Michael.
reply other threads:[~2007-08-06 22:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708070054.00890.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=aurelien@aurel32.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).