From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: netdev@vger.kernel.org, andy@warmcat.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC] allow device to stop packet mirror behaviour
Date: Wed, 08 Aug 2007 03:17:55 -0700 (PDT) [thread overview]
Message-ID: <20070808.031755.91441405.davem@davemloft.net> (raw)
In-Reply-To: <1186564441.11717.5.camel@johannes.berg>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 08 Aug 2007 11:14:01 +0200
> On Tue, 2007-08-07 at 18:06 -0700, David Miller wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> > Date: Tue, 07 Aug 2007 10:25:55 +0200
> >
> > > The only way to solve this problem therefore seems to be to suppress the
> > > mirroring out of the packet by dev_queue_xmit_nit(). The patch below
> > > does that by way of adding a new netdev flag.
> >
> > Multicast packets also get looped back in a similar manner in the ipv4
> > code. These will also be seen twice due to this issue.
>
> I don't think these other places are of any interest because of the
> radiotap+802.11 framing on the devices where it is relevant to us; you
> can't actually add an IP route to a monitor interface as far as I can
> tell.
Then I don't understand your problem. If they are specific 802.11
protocol packets, the radio stack is in a much better situation to
filter out things like this.
next prev parent reply other threads:[~2007-08-08 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 8:25 [RFC] allow device to stop packet mirror behaviour Johannes Berg
2007-08-07 8:27 ` Johannes Berg
2007-08-08 1:06 ` David Miller
2007-08-08 9:14 ` Johannes Berg
2007-08-08 10:17 ` David Miller [this message]
2007-08-08 10:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808.031755.91441405.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@warmcat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox