* Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset [not found] <200708070050.23158.m.kozlowski@tuxland.pl> @ 2007-08-07 0:11 ` John W. Linville 2007-08-08 5:58 ` Mariusz Kozlowski 0 siblings, 1 reply; 3+ messages in thread From: John W. Linville @ 2007-08-07 0:11 UTC (permalink / raw) To: Mariusz Kozlowski; +Cc: acme, Jeff Garzik, netdev, linux-kernel, linux-wireless Please send wireless patches to linux-wireless@vger.kernel.org, and CC me. Thanks! John On Tue, Aug 07, 2007 at 12:50:22AM +0200, Mariusz Kozlowski wrote: > Hello, > > This memset() looks superfluous. > > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> > > drivers/net/wireless/wl3501_cs.c | 58885 -> 58858 (-27 bytes) > drivers/net/wireless/wl3501_cs.o | 200252 -> 200000 (-252 bytes) > > drivers/net/wireless/wl3501_cs.c | 1 - > 1 file changed, 1 deletion(-) > > --- linux-2.6.23-rc1-mm2-a/drivers/net/wireless/wl3501_cs.c 2007-08-01 08:43:46.000000000 +0200 > +++ linux-2.6.23-rc1-mm2-b/drivers/net/wireless/wl3501_cs.c 2007-08-07 00:34:36.000000000 +0200 > @@ -1841,7 +1841,6 @@ static int wl3501_get_encode(struct net_ > tocopy = min_t(u8, len_keys, wrqu->encoding.length); > tocopy = min_t(u8, tocopy, 100); > wrqu->encoding.length = tocopy; > - memset(extra, 0, tocopy); > memcpy(extra, keys, tocopy); > out: > return rc; > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset 2007-08-07 0:11 ` [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset John W. Linville @ 2007-08-08 5:58 ` Mariusz Kozlowski 2007-08-08 13:20 ` John W. Linville 0 siblings, 1 reply; 3+ messages in thread From: Mariusz Kozlowski @ 2007-08-08 5:58 UTC (permalink / raw) To: John W. Linville; +Cc: acme, Jeff Garzik, netdev, linux-kernel, linux-wireless > Please send wireless patches to linux-wireless@vger.kernel.org, > and CC me. Ok. Did you pick the patch up? Regards, Mariusz ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset 2007-08-08 5:58 ` Mariusz Kozlowski @ 2007-08-08 13:20 ` John W. Linville 0 siblings, 0 replies; 3+ messages in thread From: John W. Linville @ 2007-08-08 13:20 UTC (permalink / raw) To: Mariusz Kozlowski; +Cc: acme, Jeff Garzik, netdev, linux-kernel, linux-wireless On Wed, Aug 08, 2007 at 07:58:21AM +0200, Mariusz Kozlowski wrote: > > Please send wireless patches to linux-wireless@vger.kernel.org, > > and CC me. > > Ok. Did you pick the patch up? Yes, I have it. John -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-08 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200708070050.23158.m.kozlowski@tuxland.pl>
2007-08-07 0:11 ` [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant memset John W. Linville
2007-08-08 5:58 ` Mariusz Kozlowski
2007-08-08 13:20 ` John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).