Re: [PATCH] ssb: Make extif driver compilation depend on extif config

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 09 Aug 2007 01:13:40 +0200
Aurelien Jarno <aurelien@aurel32.net> wrote:

> Andrew Morton a __crit :
> > mips allmodconfig:
> > 
> > drivers/ssb/driver_pcicore.c: In function `ssb_fixup_pcibridge':
> > drivers/ssb/driver_pcicore.c:98: error: implicit declaration of function `pcibios_enable_device'
> > drivers/ssb/driver_pcicore.c: At top level:
> > drivers/ssb/driver_pcicore.c:278: warning: integer overflow in expression
> > drivers/ssb/driver_pcicore.c:278: warning: integer overflow in expression
> 
> Those looks like real errors.

They seems to have gone away after I droped the duplicated patches.

> > drivers/ssb/driver_extif.c:125: error: redefinition of 'extif_read32'
> > drivers/ssb/driver_extif.c:21: error: previous definition of 'extif_read32' was here
> > drivers/ssb/driver_extif.c:130: error: redefinition of 'extif_write32'
> > drivers/ssb/driver_extif.c:26: error: previous definition of 'extif_write32' was here
> > drivers/ssb/driver_extif.c:136: error: redefinition of 'serial_exists'
> > drivers/ssb/driver_extif.c:32: error: previous definition of 'serial_exists' was here
> > drivers/ssb/driver_extif.c:150: error: redefinition of 'ssb_extif_serial_init'
> > drivers/ssb/driver_extif.c:46: error: previous definition of 'ssb_extif_serial_init' was here
> > drivers/ssb/driver_extif.c:181: error: redefinition of 'ssb_extif_timing_init'
> > drivers/ssb/driver_extif.c:77: error: previous definition of 'ssb_extif_timing_init' was here
> > drivers/ssb/driver_extif.c:203: error: redefinition of 'ssb_extif_get_clockcontrol'
> > drivers/ssb/driver_extif.c:99: error: previous definition of 'ssb_extif_get_clockcontrol' was here
> > 
> 
> All the versions of driver_extif.c I have seen have at maximum around
> 100 lines. It looks like a patch applied twice, which make the same code
> appearing twice in the .c file.

Yeah.  I dropped a bunch of things which seemed to help.

I'm hopelessly confused by the ssb stuff.  I'm not sure if I have all the
right stuff, all the latest stuff and I don't understand why some is going
into git-wireless and some is not.

I'd prefer to be dumbly pulling a tree which Michael controls rather than
trying to master it all in -mm, if possible.  A git tree or a quilt tree in
some open dir somewhere would suit?