linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Turn off meaningless TKIP message when  software WEP encryption is used
Date: Mon, 13 Aug 2007 15:35:52 -0400	[thread overview]
Message-ID: <20070813193552.GE19115@tuxdriver.com> (raw)
In-Reply-To: <46c0b062.yM23YNXGCQhX0Zd/%Larry.Finger@lwfinger.net>

On Mon, Aug 13, 2007 at 02:26:26PM -0500, Larry Finger wrote:

> --- wireless-legacy.orig/net/mac80211/wpa.c
> +++ wireless-legacy/net/mac80211/wpa.c
> @@ -516,9 +516,11 @@ ieee80211_rx_h_tkip_decrypt(struct ieee8
>  					  skb->len - hdrlen, rx->sta->addr,
>  					  hwaccel, rx->u.rx.queue);
>  	if (res != TKIP_DECRYPT_OK || wpa_test) {
> -		printk(KERN_DEBUG "%s: TKIP decrypt failed for RX frame from "
> -		       MAC_FMT " (res=%d)\n",
> -		       rx->dev->name, MAC_ARG(rx->sta->addr), res);
> +		if ((rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV)) {
> +			printk(KERN_DEBUG "%s: TKIP decrypt failed for RX frame from "
> +			       MAC_FMT " (res=%d)\n",
> +			       rx->dev->name, MAC_ARG(rx->sta->addr), res);
> +		}
>  		return TXRX_DROP;
>  	}

Since you are in there anyway, should this be rate limited?

John
-- 
John W. Linville
linville@tuxdriver.com

      reply	other threads:[~2007-08-13 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 19:26 [PATCH] mac80211: Turn off meaningless TKIP message when software WEP encryption is used Larry Finger
2007-08-13 19:35 ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070813193552.GE19115@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).