linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Jiri Benc <jbenc@suse.cz>,
	Michael Wu <flamingice@sourmilk.net>
Subject: [PATCH 4/4] mac80211: remove IEEE80211_HW_DATA_NULLFUNC_ACK
Date: Thu, 16 Aug 2007 18:29:12 +0200	[thread overview]
Message-ID: <20070816162933.352627000@sipsolutions.net> (raw)
In-Reply-To: 20070816162908.030659000@sipsolutions.net

The flag is only propagated to hostapd which doesn't use it.
If we ever add it back please do it in an inverted meaning so
drivers for good hardware don't need to set an ever-growing
list of flags.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>
Cc: Michael Wu <flamingice@sourmilk.net>

---
 include/net/mac80211.h         |    3 ---
 net/mac80211/hostapd_ioctl.h   |    2 --
 net/mac80211/ieee80211_ioctl.c |    2 --
 3 files changed, 7 deletions(-)

--- wireless-dev.orig/include/net/mac80211.h	2007-08-16 18:20:19.703468950 +0200
+++ wireless-dev/include/net/mac80211.h	2007-08-16 18:20:23.083468950 +0200
@@ -473,9 +473,6 @@ struct ieee80211_hw {
 
 #define IEEE80211_HW_WEP_INCLUDE_IV (1<<5)
 
-	/* will data nullfunc frames get proper TX status callback */
-#define IEEE80211_HW_DATA_NULLFUNC_ACK (1<<6)
-
 	/* Force software encryption for TKIP packets if WMM is enabled. */
 #define IEEE80211_HW_NO_TKIP_WMM_HWACCEL (1<<7)
 
--- wireless-dev.orig/net/mac80211/hostapd_ioctl.h	2007-08-16 18:20:42.023468950 +0200
+++ wireless-dev/net/mac80211/hostapd_ioctl.h	2007-08-16 18:20:47.063468950 +0200
@@ -171,8 +171,6 @@ struct prism2_hostapd_param {
 #define HOSTAP_CRYPT_FLAG_SET_TX_KEY BIT(0)
 #define HOSTAP_CRYPT_FLAG_PERMANENT BIT(1)
 
-#define HOSTAP_HW_FLAG_NULLFUNC_OK BIT(0)
-
 /* Data structures used for get_hw_features ioctl */
 struct hostapd_ioctl_hw_modes_hdr {
 	int mode;
--- wireless-dev.orig/net/mac80211/ieee80211_ioctl.c	2007-08-16 18:20:29.553468950 +0200
+++ wireless-dev/net/mac80211/ieee80211_ioctl.c	2007-08-16 18:20:38.833468950 +0200
@@ -111,8 +111,6 @@ static int ieee80211_ioctl_get_hw_featur
 	struct ieee80211_hw_mode *mode;
 
 	param->u.hw_features.flags = 0;
-	if (local->hw.flags & IEEE80211_HW_DATA_NULLFUNC_ACK)
-		param->u.hw_features.flags |= HOSTAP_HW_FLAG_NULLFUNC_OK;
 
 	param->u.hw_features.num_modes = 0;
 	list_for_each_entry(mode, &local->modes_list, list) {

-- 


      parent reply	other threads:[~2007-08-16 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16 16:29 [PATCH 0/4] remove IEEE80211_HW_DATA_NULLFUNC_ACK flag Johannes Berg
2007-08-16 16:29 ` [PATCH 1/4] ralink drivers: remove IEEE80211_HW_DATA_NULLFUNC_ACK Johannes Berg
2007-08-16 16:29 ` [PATCH 2/4] rtl8187: " Johannes Berg
2007-08-16 16:29 ` [PATCH 3/4] p54: " Johannes Berg
2007-08-16 16:29 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816162933.352627000@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=flamingice@sourmilk.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).