Re: [PATCH 14/20] mac80211: kill key_mgmt variable, use privacy_enabled

[Jouni Malinen <j@w1.fi>]

On Wed, Aug 15, 2007 at 04:49:34PM +0200, Johannes Berg wrote:

> The key_mgmt variable for STA interfaces doesn't seem well-defined
> nor do we actually use the values other than "NONE", so change it to
> be named better.

Most drivers should not need key_mgmt configuration. The only exception
that I'm aware of is firmware designs that insist on generating WPA/RSN
IE internally. None of them are likely to be using mac80211, though.

> +			 * What are the semantics in wext supposed to be?
> +			 *
> +			 * Don't bother figuring that out... It's wext after
> +			 * all so figuring it out will most likely require a
> +			 * moderate amount of clairvoyance.

Isn't this a bit unnecessary?

> +			sdata->u.sta.privacy_enabled = !!data->value;

This looks a bit odd, though, taken into account that this is coming
from IW_AUTH_KEY_MGMT and not IW_AUTH_PRIVACY_INVOKED.. It would
probably be better to just remove all the crab from here can ignore the
IW_AUTH_KEY_MGMT value in mac80211. The only place that actually used it
in the client code (mixed cell configuration) had already been broken,
so this could all be just removed completely unless someone has plans on
fixing privacy mismatch detection.

-- 
Jouni Malinen                                            PGP id EFC895FA