* [PATCH 0/3] improve mac80211 key handling
@ 2007-08-21 15:57 Johannes Berg
2007-08-21 15:57 ` [PATCH 1/3] mac80211: embed key conf in key, fix driver interface Johannes Berg
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Johannes Berg @ 2007-08-21 15:57 UTC (permalink / raw)
To: John Linville; +Cc: Jiri Benc, Michael Wu, linux-wireless
This patch series improves mac80211's internal key handling
as well as the driver interface.
johannes
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] mac80211: embed key conf in key, fix driver interface
2007-08-21 15:57 [PATCH 0/3] improve mac80211 key handling Johannes Berg
@ 2007-08-21 15:57 ` Johannes Berg
2007-08-21 15:57 ` [PATCH 2/3] mac80211: revamp key handling Johannes Berg
2007-08-21 15:57 ` [PATCH 3/3] mac80211: add interface index to key debugfs Johannes Berg
2 siblings, 0 replies; 7+ messages in thread
From: Johannes Berg @ 2007-08-21 15:57 UTC (permalink / raw)
To: John Linville; +Cc: Jiri Benc, Michael Wu, linux-wireless
This patch embeds the struct ieee80211_key_conf into struct ieee80211_key
and thus avoids allocations and having data present twice.
This required some more changes:
1) The removal of the IEEE80211_KEY_DEFAULT_TX_KEY key flag.
This flag isn't used by drivers nor should it be since
we have a set_key_idx() callback. Maybe that callback needs
to be extended to include the key conf, but only a driver that
requires it will tell.
2) The removal of the IEEE80211_KEY_DEFAULT_WEP_ONLY key flag.
This flag is global, so it shouldn't be passed in the key
conf structure. Pass it to the function instead.
Also, this patch removes the AID parameter to the set_key() callback
because it is currently unused and the hardware currently cannot know
about the AID anyway. I suspect this was used with some hardware that
actually selected the AID itself, but that functionality was removed.
Additionally, I've removed the ALG_NULL key algorithm since we have
ALG_NONE.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/b43/main.c | 4 -
drivers/net/wireless/iwl-base.c | 2
include/net/mac80211.h | 51 ++++++++++--------
net/mac80211/debugfs_key.c | 49 +++++++++++-------
net/mac80211/ieee80211.c | 5 +
net/mac80211/ieee80211_i.h | 3 -
net/mac80211/ieee80211_iface.c | 3 -
net/mac80211/ieee80211_ioctl.c | 108 +++++++++++++++++-----------------------
net/mac80211/ieee80211_key.h | 20 ++-----
net/mac80211/ieee80211_sta.c | 2
net/mac80211/key.c | 28 ----------
net/mac80211/rx.c | 22 +++-----
net/mac80211/sta_info.c | 17 ++----
net/mac80211/tkip.c | 18 +++---
net/mac80211/tx.c | 6 +-
net/mac80211/wep.c | 18 +++---
net/mac80211/wpa.c | 61 ++++++++++++----------
17 files changed, 197 insertions(+), 220 deletions(-)
--- wireless-dev.orig/drivers/net/wireless/b43/main.c 2007-08-21 15:17:25.805923881 +0200
+++ wireless-dev/drivers/net/wireless/b43/main.c 2007-08-21 16:04:26.335923881 +0200
@@ -2780,7 +2780,8 @@ static int b43_dev_config(struct ieee802
static int b43_dev_set_key(struct ieee80211_hw *hw,
set_key_cmd cmd,
- u8 * addr, struct ieee80211_key_conf *key, int aid)
+ u8 *addr, struct ieee80211_key_conf *key,
+ int static_wep_only)
{
struct b43_wl *wl = hw_to_b43_wl(hw);
struct b43_wldev *dev = wl->current_dev;
@@ -2794,7 +2795,6 @@ static int b43_dev_set_key(struct ieee80
return -ENODEV;
switch (key->alg) {
case ALG_NONE:
- case ALG_NULL:
algorithm = B43_SEC_ALGO_NONE;
break;
case ALG_WEP:
--- wireless-dev.orig/include/net/mac80211.h 2007-08-21 16:02:54.745923881 +0200
+++ wireless-dev/include/net/mac80211.h 2007-08-21 16:04:26.345923881 +0200
@@ -205,8 +205,8 @@ struct ieee80211_tx_control {
* is not implemented by the driver */
u8 power_level; /* per-packet transmit power level, in dBm */
u8 antenna_sel_tx; /* 0 = default/diversity, 1 = Ant0, 2 = Ant1 */
- s8 key_idx; /* -1 = do not encrypt, >= 0 keyidx from
- * hw->set_key() */
+ s8 key_idx; /* HW_KEY_IDX_INVALID = do not encrypt,
+ * other values: keyidx from hw->set_key() */
u8 icv_len; /* length of the ICV/MIC field in octets */
u8 iv_len; /* length of the IV field in octets */
u8 tkip_key[16]; /* generated phase2/phase1 key for hw TKIP */
@@ -392,26 +392,23 @@ struct ieee80211_if_conf {
struct ieee80211_tx_control *beacon_control;
};
-typedef enum { ALG_NONE, ALG_WEP, ALG_TKIP, ALG_CCMP, ALG_NULL }
-ieee80211_key_alg;
-
+typedef enum {
+ ALG_NONE,
+ ALG_WEP,
+ ALG_TKIP,
+ ALG_CCMP,
+} ieee80211_key_alg;
struct ieee80211_key_conf {
+ /* shall be changed by the driver to anything but HW_KEY_IDX_INVALID */
+ int hw_key_idx;
- int hw_key_idx; /* filled + used by low-level driver */
ieee80211_key_alg alg;
+
int keylen;
#define IEEE80211_KEY_FORCE_SW_ENCRYPT (1<<0) /* to be cleared by low-level
driver */
-#define IEEE80211_KEY_DEFAULT_TX_KEY (1<<1) /* This key is the new default TX
- key (used only for broadcast
- keys). */
-#define IEEE80211_KEY_DEFAULT_WEP_ONLY (1<<2) /* static WEP is the only
- configured security policy;
- this allows some low-level
- drivers to determine when
- hwaccel can be used */
u32 flags; /* key configuration flags defined above */
s8 keyidx; /* WEP key index */
@@ -628,20 +625,26 @@ struct ieee80211_ops {
* Must be atomic. */
int (*set_tim)(struct ieee80211_hw *hw, int aid, int set);
- /* Set encryption key. IEEE 802.11 module calls this function to set
- * encryption keys. addr is ff:ff:ff:ff:ff:ff for default keys and
- * station hwaddr for individual keys. aid of the station is given
- * to help low-level driver in selecting which key->hw_key_idx to use
- * for this key. TX control data will use the hw_key_idx selected by
- * the low-level driver. */
+ /*
+ * Set encryption key.
+ *
+ * This is called to enable hardware acceleration of encryption and
+ * decryption. The address will be the broadcast address for default
+ * keys and the other station's hardware address for individual keys.
+ * When transmitting, the TX control data will use the hw_key_idx
+ * selected by the low-level driver.
+ */
int (*set_key)(struct ieee80211_hw *hw, set_key_cmd cmd,
- u8 *addr, struct ieee80211_key_conf *key, int aid);
+ u8 *address, struct ieee80211_key_conf *key,
+ int static_wep_only);
- /* Set TX key index for default/broadcast keys. This is needed in cases
+ /*
+ * Set TX key index for default/broadcast keys. This is needed in cases
* where wlan card is doing full WEP/TKIP encapsulation (wep_include_iv
* is not set), in other cases, this function pointer can be set to
- * NULL since the IEEE 802. 11 module takes care of selecting the key
- * index for each TX frame. */
+ * NULL since the IEEE 802.11 module takes care of selecting the key
+ * index for each TX frame.
+ */
int (*set_key_idx)(struct ieee80211_hw *hw, int idx);
/* Enable/disable IEEE 802.1X. This item requests wlan card to pass
--- wireless-dev.orig/net/mac80211/ieee80211_ioctl.c 2007-08-21 15:59:22.725923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_ioctl.c 2007-08-21 16:04:26.375923881 +0200
@@ -278,10 +278,11 @@ static int ieee80211_ioctl_add_sta(struc
* for TX filtering. */
memset(&conf, 0, sizeof(conf));
conf.hw_key_idx = HW_KEY_IDX_INVALID;
- conf.alg = ALG_NULL;
+ conf.alg = ALG_NONE;
conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
if (local->ops->set_key(local_to_hw(local), SET_KEY,
- sta->addr, &conf, sta->aid)) {
+ sta->addr, &conf,
+ local->default_wep_only)) {
sta->key_idx_compression = HW_KEY_IDX_INVALID;
} else {
sta->key_idx_compression = conf.hw_key_idx;
@@ -396,31 +397,26 @@ int ieee80211_set_hw_encryption(struct n
struct sta_info *sta, u8 addr[ETH_ALEN],
struct ieee80211_key *key)
{
- struct ieee80211_key_conf *keyconf = NULL;
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
int rc = 0;
- /* default to sw encryption; this will be cleared by low-level
- * driver if the hw supports requested encryption */
+ /*
+ * default to sw encryption; this will be cleared by low-level
+ * driver if the hw supports requested encryption
+ */
if (key)
- key->force_sw_encrypt = 1;
+ key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- if (key && local->ops->set_key &&
- (keyconf = ieee80211_key_data2conf(local, key))) {
- if (local->ops->set_key(local_to_hw(local), SET_KEY, addr,
- keyconf, sta ? sta->aid : 0)) {
+ if (key && local->ops->set_key) {
+ rc = local->ops->set_key(local_to_hw(local), SET_KEY, addr,
+ &key->conf, local->default_wep_only);
+ if (rc) {
rc = HOSTAP_CRYPT_ERR_KEY_SET_FAILED;
- key->force_sw_encrypt = 1;
- key->hw_key_idx = HW_KEY_IDX_INVALID;
- } else {
- key->force_sw_encrypt =
- !!(keyconf->flags & IEEE80211_KEY_FORCE_SW_ENCRYPT);
- key->hw_key_idx =
- keyconf->hw_key_idx;
-
+ /* protect against buggy drivers */
+ key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
+ key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
}
}
- kfree(keyconf);
return rc;
}
@@ -435,7 +431,6 @@ static int ieee80211_set_encryption(stru
struct sta_info *sta;
struct ieee80211_key *key, *old_key;
int try_hwaccel = 1;
- struct ieee80211_key_conf *keyconf;
struct ieee80211_sub_if_data *sdata;
sdata = IEEE80211_DEV_TO_SUB_IF(dev);
@@ -525,20 +520,18 @@ static int ieee80211_set_encryption(stru
}
if (alg == ALG_NONE) {
- keyconf = NULL;
if (try_hwaccel && key &&
- key->hw_key_idx != HW_KEY_IDX_INVALID &&
+ key->conf.hw_key_idx != HW_KEY_IDX_INVALID &&
local->ops->set_key &&
- (keyconf = ieee80211_key_data2conf(local, key)) != NULL &&
local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- sta_addr, keyconf, sta ? sta->aid : 0)) {
+ sta_addr, &key->conf,
+ local->default_wep_only)) {
if (err)
*err = HOSTAP_CRYPT_ERR_KEY_SET_FAILED;
printk(KERN_DEBUG "%s: set_encrypt - low-level disable"
" failed\n", dev->name);
ret = -EINVAL;
}
- kfree(keyconf);
if (set_tx_key || sdata->default_key == key) {
ieee80211_debugfs_key_remove_default(sdata);
@@ -562,22 +555,20 @@ static int ieee80211_set_encryption(stru
/* default to sw encryption; low-level driver sets these if the
* requested encryption is supported */
- key->hw_key_idx = HW_KEY_IDX_INVALID;
- key->force_sw_encrypt = 1;
+ key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
+ key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- key->alg = alg;
- key->keyidx = idx;
- key->keylen = key_len;
- memcpy(key->key, _key, key_len);
- if (set_tx_key)
- key->default_tx_key = 1;
+ key->conf.alg = alg;
+ key->conf.keyidx = idx;
+ key->conf.keylen = key_len;
+ memcpy(key->conf.key, _key, key_len);
if (alg == ALG_CCMP) {
/* Initialize AES key state here as an optimization
* so that it does not need to be initialized for every
* packet. */
key->u.ccmp.tfm = ieee80211_aes_key_setup_encrypt(
- key->key);
+ key->conf.key);
if (!key->u.ccmp.tfm) {
ret = -ENOMEM;
goto err_free;
@@ -710,7 +701,7 @@ static int ieee80211_ioctl_get_encryptio
sta = NULL;
if (param->u.crypt.idx >= NUM_DEFAULT_KEYS) {
param->u.crypt.idx = sdata->default_key ?
- sdata->default_key->keyidx : 0;
+ sdata->default_key->conf.keyidx : 0;
return 0;
} else
key = &sdata->keys[param->u.crypt.idx];
@@ -730,7 +721,7 @@ static int ieee80211_ioctl_get_encryptio
param->u.crypt.key_len = 0;
param->u.crypt.idx = 0xff;
} else {
- switch ((*key)->alg) {
+ switch ((*key)->conf.alg) {
case ALG_WEP:
memcpy(param->u.crypt.alg, "WEP", 4);
break;
@@ -745,7 +736,7 @@ static int ieee80211_ioctl_get_encryptio
if (local->ops->get_sequence_counter(
local_to_hw(local),
param->sta_addr,
- (*key)->keyidx,
+ (*key)->conf.keyidx,
IEEE80211_SEQ_COUNTER_TX,
&iv32,
&iv16)) {
@@ -785,12 +776,12 @@ static int ieee80211_ioctl_get_encryptio
break;
}
- if (max_key_len < (*key)->keylen)
+ if (max_key_len < (*key)->conf.keylen)
ret = -E2BIG;
else {
- param->u.crypt.key_len = (*key)->keylen;
- memcpy(param->u.crypt.key, (*key)->key,
- (*key)->keylen);
+ param->u.crypt.key_len = (*key)->conf.keylen;
+ memcpy(param->u.crypt.key, (*key)->conf.key,
+ (*key)->conf.keylen);
}
}
@@ -1824,43 +1815,38 @@ static int ieee80211_ioctl_giwretry(stru
static void ieee80211_key_enable_hwaccel(struct ieee80211_local *local,
struct ieee80211_key *key)
{
- struct ieee80211_key_conf *keyconf;
u8 addr[ETH_ALEN];
- if (!key || key->alg != ALG_WEP || !key->force_sw_encrypt ||
+ if (!key || key->conf.alg != ALG_WEP ||
+ !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) ||
(local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP))
return;
memset(addr, 0xff, ETH_ALEN);
- keyconf = ieee80211_key_data2conf(local, key);
- if (keyconf && local->ops->set_key &&
+
+ if (local->ops->set_key)
local->ops->set_key(local_to_hw(local),
- SET_KEY, addr, keyconf, 0) == 0) {
- key->force_sw_encrypt =
- !!(keyconf->flags & IEEE80211_KEY_FORCE_SW_ENCRYPT);
- key->hw_key_idx = keyconf->hw_key_idx;
- }
- kfree(keyconf);
+ SET_KEY, addr, &key->conf,
+ local->default_wep_only);
}
static void ieee80211_key_disable_hwaccel(struct ieee80211_local *local,
struct ieee80211_key *key)
{
- struct ieee80211_key_conf *keyconf;
u8 addr[ETH_ALEN];
- if (!key || key->alg != ALG_WEP || key->force_sw_encrypt ||
+ if (!key || key->conf.alg != ALG_WEP ||
+ (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) ||
(local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP))
return;
memset(addr, 0xff, ETH_ALEN);
- keyconf = ieee80211_key_data2conf(local, key);
- if (keyconf && local->ops->set_key)
+ if (local->ops->set_key)
local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- addr, keyconf, 0);
- kfree(keyconf);
- key->force_sw_encrypt = 1;
+ addr, &key->conf,
+ local->default_wep_only);
+ key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
}
@@ -2286,9 +2272,9 @@ static int ieee80211_ioctl_giwencode(str
return 0;
}
- memcpy(key, sdata->keys[idx]->key,
- min((int)erq->length, sdata->keys[idx]->keylen));
- erq->length = sdata->keys[idx]->keylen;
+ memcpy(key, sdata->keys[idx]->conf.key,
+ min((int)erq->length, sdata->keys[idx]->conf.keylen));
+ erq->length = sdata->keys[idx]->conf.keylen;
erq->flags |= IW_ENCODE_ENABLED;
return 0;
--- wireless-dev.orig/net/mac80211/sta_info.c 2007-08-21 14:58:36.125923881 +0200
+++ wireless-dev/net/mac80211/sta_info.c 2007-08-21 16:04:26.375923881 +0200
@@ -254,23 +254,20 @@ void sta_info_free(struct sta_info *sta)
if (sta->key) {
if (local->ops->set_key) {
- struct ieee80211_key_conf *key;
- key = ieee80211_key_data2conf(local, sta->key);
- if (key) {
- local->ops->set_key(local_to_hw(local),
- DISABLE_KEY,
- sta->addr, key, sta->aid);
- kfree(key);
- }
+ local->ops->set_key(local_to_hw(local),
+ DISABLE_KEY, sta->addr,
+ &sta->key->conf,
+ local->default_wep_only);
}
} else if (sta->key_idx_compression != HW_KEY_IDX_INVALID) {
struct ieee80211_key_conf conf;
memset(&conf, 0, sizeof(conf));
conf.hw_key_idx = sta->key_idx_compression;
- conf.alg = ALG_NULL;
+ conf.alg = ALG_NONE;
conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- sta->addr, &conf, sta->aid);
+ sta->addr, &conf,
+ local->default_wep_only);
sta->key_idx_compression = HW_KEY_IDX_INVALID;
}
--- wireless-dev.orig/drivers/net/wireless/iwl-base.c 2007-08-21 14:58:37.545923881 +0200
+++ wireless-dev/drivers/net/wireless/iwl-base.c 2007-08-21 16:04:26.385923881 +0200
@@ -7864,7 +7864,7 @@ static int iwl_mac_hw_scan(struct ieee80
}
static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd, u8 *addr,
- struct ieee80211_key_conf *key, int aid)
+ struct ieee80211_key_conf *key, int static_wep_only)
{
struct iwl_priv *priv = hw->priv;
int rc = 0;
--- wireless-dev.orig/net/mac80211/debugfs_key.c 2007-08-21 15:17:20.585923881 +0200
+++ wireless-dev/net/mac80211/debugfs_key.c 2007-08-21 16:04:26.385923881 +0200
@@ -14,17 +14,17 @@
#include "debugfs.h"
#include "debugfs_key.h"
-#define KEY_READ(name, buflen, format_string) \
+#define KEY_READ(name, prop, buflen, format_string) \
static ssize_t key_##name##_read(struct file *file, \
char __user *userbuf, \
size_t count, loff_t *ppos) \
{ \
char buf[buflen]; \
struct ieee80211_key *key = file->private_data; \
- int res = scnprintf(buf, buflen, format_string, key->name); \
+ int res = scnprintf(buf, buflen, format_string, key->prop); \
return simple_read_from_buffer(userbuf, count, ppos, buf, res); \
}
-#define KEY_READ_D(name) KEY_READ(name, 20, "%d\n")
+#define KEY_READ_D(name) KEY_READ(name, name, 20, "%d\n")
#define KEY_OPS(name) \
static const struct file_operations key_ ##name## _ops = { \
@@ -36,10 +36,25 @@ static const struct file_operations key_
KEY_READ_##format(name) \
KEY_OPS(name)
-KEY_FILE(keylen, D);
-KEY_FILE(force_sw_encrypt, D);
-KEY_FILE(keyidx, D);
-KEY_FILE(hw_key_idx, D);
+#define KEY_CONF_READ(name, buflen, format_string) \
+ KEY_READ(conf_##name, conf.name, buflen, format_string)
+#define KEY_CONF_READ_D(name) KEY_CONF_READ(name, 20, "%d\n")
+#define KEY_CONF_READ_X(name) KEY_CONF_READ(name, 20, "0x%x\n")
+
+#define KEY_CONF_OPS(name) \
+static const struct file_operations key_ ##name## _ops = { \
+ .read = key_conf_##name##_read, \
+ .open = mac80211_open_file_generic, \
+}
+
+#define KEY_CONF_FILE(name, format) \
+ KEY_CONF_READ_##format(name) \
+ KEY_CONF_OPS(name)
+
+KEY_CONF_FILE(keylen, D);
+KEY_CONF_FILE(keyidx, D);
+KEY_CONF_FILE(hw_key_idx, D);
+KEY_CONF_FILE(flags, X);
KEY_FILE(tx_rx_count, D);
static ssize_t key_algorithm_read(struct file *file,
@@ -49,7 +64,7 @@ static ssize_t key_algorithm_read(struct
char *alg;
struct ieee80211_key *key = file->private_data;
- switch (key->alg) {
+ switch (key->conf.alg) {
case ALG_WEP:
alg = "WEP\n";
break;
@@ -74,7 +89,7 @@ static ssize_t key_tx_spec_read(struct f
int len;
struct ieee80211_key *key = file->private_data;
- switch (key->alg) {
+ switch (key->conf.alg) {
case ALG_WEP:
len = scnprintf(buf, sizeof(buf), "\n");
break;
@@ -103,7 +118,7 @@ static ssize_t key_rx_spec_read(struct f
int i, len;
const u8 *rpn;
- switch (key->alg) {
+ switch (key->conf.alg) {
case ALG_WEP:
len = scnprintf(buf, sizeof(buf), "\n");
break;
@@ -139,7 +154,7 @@ static ssize_t key_replays_read(struct f
char buf[20];
int len;
- if (key->alg != ALG_CCMP)
+ if (key->conf.alg != ALG_CCMP)
return 0;
len = scnprintf(buf, sizeof(buf), "%u\n", key->u.ccmp.replays);
return simple_read_from_buffer(userbuf, count, ppos, buf, len);
@@ -150,12 +165,12 @@ static ssize_t key_key_read(struct file
size_t count, loff_t *ppos)
{
struct ieee80211_key *key = file->private_data;
- int i, res, bufsize = 2*key->keylen+2;
+ int i, res, bufsize = 2 * key->conf.keylen + 2;
char *buf = kmalloc(bufsize, GFP_KERNEL);
char *p = buf;
- for (i = 0; i < key->keylen; i++)
- p += scnprintf(p, bufsize+buf-p, "%02x", key->key[i]);
+ for (i = 0; i < key->conf.keylen; i++)
+ p += scnprintf(p, bufsize + buf - p, "%02x", key->conf.key[i]);
p += scnprintf(p, bufsize+buf-p, "\n");
res = simple_read_from_buffer(userbuf, count, ppos, buf, p - buf);
kfree(buf);
@@ -185,7 +200,7 @@ void ieee80211_debugfs_key_add(struct ie
return;
DEBUGFS_ADD(keylen);
- DEBUGFS_ADD(force_sw_encrypt);
+ DEBUGFS_ADD(flags);
DEBUGFS_ADD(keyidx);
DEBUGFS_ADD(hw_key_idx);
DEBUGFS_ADD(tx_rx_count);
@@ -205,7 +220,7 @@ void ieee80211_debugfs_key_remove(struct
return;
DEBUGFS_DEL(keylen);
- DEBUGFS_DEL(force_sw_encrypt);
+ DEBUGFS_DEL(flags);
DEBUGFS_DEL(keyidx);
DEBUGFS_DEL(hw_key_idx);
DEBUGFS_DEL(tx_rx_count);
@@ -227,7 +242,7 @@ void ieee80211_debugfs_key_add_default(s
if (!sdata->debugfsdir)
return;
- sprintf(buf, "../keys/%d", sdata->default_key->keyidx);
+ sprintf(buf, "../keys/%d", sdata->default_key->conf.keyidx);
sdata->debugfs.default_key =
debugfs_create_symlink("default_key", sdata->debugfsdir, buf);
}
--- wireless-dev.orig/net/mac80211/ieee80211.c 2007-08-21 15:42:24.665923881 +0200
+++ wireless-dev/net/mac80211/ieee80211.c 2007-08-21 16:04:26.385923881 +0200
@@ -889,7 +889,7 @@ static void ieee80211_remove_tx_extra(st
if (!key)
goto no_key;
- switch (key->alg) {
+ switch (key->conf.alg) {
case ALG_WEP:
iv_len = WEP_IV_LEN;
mic_len = WEP_ICV_LEN;
@@ -906,7 +906,8 @@ static void ieee80211_remove_tx_extra(st
goto no_key;
}
- if (skb->len >= mic_len && key->force_sw_encrypt)
+ if (skb->len >= mic_len &&
+ (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT))
skb_trim(skb, skb->len - mic_len);
if (skb->len >= iv_len && skb->len > hdrlen) {
memmove(skb->data + iv_len, skb->data, hdrlen);
--- wireless-dev.orig/net/mac80211/ieee80211_i.h 2007-08-21 16:00:34.675923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_i.h 2007-08-21 16:04:26.435923881 +0200
@@ -923,9 +923,6 @@ int ieee80211_subif_start_xmit(struct sk
int ieee80211_mgmt_start_xmit(struct sk_buff *skb, struct net_device *dev);
/* key handling */
-struct ieee80211_key_conf *
-ieee80211_key_data2conf(struct ieee80211_local *local,
- const struct ieee80211_key *data);
struct ieee80211_key *ieee80211_key_alloc(struct ieee80211_sub_if_data *sdata,
int idx, size_t key_len, gfp_t flags);
void ieee80211_key_free(struct ieee80211_key *key);
--- wireless-dev.orig/net/mac80211/ieee80211_key.h 2007-08-21 14:58:36.265923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_key.h 2007-08-21 16:04:26.435923881 +0200
@@ -44,8 +44,6 @@
struct ieee80211_key {
struct kref kref;
- int hw_key_idx; /* filled and used by low-level driver */
- ieee80211_key_alg alg;
union {
struct {
/* last used TSC */
@@ -73,22 +71,16 @@ struct ieee80211_key {
u8 rx_crypto_buf[6 * AES_BLOCK_LEN];
} ccmp;
} u;
- int tx_rx_count; /* number of times this key has been used */
- int keylen;
- /* if the low level driver can provide hardware acceleration it should
- * clear this flag */
- unsigned int force_sw_encrypt:1;
- unsigned int default_tx_key:1; /* This key is the new default TX key
- * (used only for broadcast keys). */
- s8 keyidx; /* WEP key index */
+ /* number of times this key has been used */
+ int tx_rx_count;
#ifdef CONFIG_MAC80211_DEBUGFS
struct {
struct dentry *stalink;
struct dentry *dir;
struct dentry *keylen;
- struct dentry *force_sw_encrypt;
+ struct dentry *flags;
struct dentry *keyidx;
struct dentry *hw_key_idx;
struct dentry *tx_rx_count;
@@ -100,7 +92,11 @@ struct ieee80211_key {
} debugfs;
#endif
- u8 key[0];
+ /*
+ * key config, must be last because it contains key
+ * material as variable length member
+ */
+ struct ieee80211_key_conf conf;
};
#endif /* IEEE80211_KEY_H */
--- wireless-dev.orig/net/mac80211/ieee80211_sta.c 2007-08-21 15:59:22.735923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_sta.c 2007-08-21 16:04:26.435923881 +0200
@@ -1345,7 +1345,7 @@ static int ieee80211_sta_wep_configured(
{
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
if (!sdata || !sdata->default_key ||
- sdata->default_key->alg != ALG_WEP)
+ sdata->default_key->conf.alg != ALG_WEP)
return 0;
return 1;
}
--- wireless-dev.orig/net/mac80211/key.c 2007-08-21 14:58:36.365923881 +0200
+++ wireless-dev/net/mac80211/key.c 2007-08-21 16:04:26.445923881 +0200
@@ -13,32 +13,6 @@
#include "debugfs_key.h"
#include "aes_ccm.h"
-struct ieee80211_key_conf *
-ieee80211_key_data2conf(struct ieee80211_local *local,
- const struct ieee80211_key *data)
-{
- struct ieee80211_key_conf *conf;
-
- conf = kmalloc(sizeof(*conf) + data->keylen, GFP_ATOMIC);
- if (!conf)
- return NULL;
-
- conf->hw_key_idx = data->hw_key_idx;
- conf->alg = data->alg;
- conf->keylen = data->keylen;
- conf->flags = 0;
- if (data->force_sw_encrypt)
- conf->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- conf->keyidx = data->keyidx;
- if (data->default_tx_key)
- conf->flags |= IEEE80211_KEY_DEFAULT_TX_KEY;
- if (local->default_wep_only)
- conf->flags |= IEEE80211_KEY_DEFAULT_WEP_ONLY;
- memcpy(conf->key, data->key, data->keylen);
-
- return conf;
-}
-
struct ieee80211_key *ieee80211_key_alloc(struct ieee80211_sub_if_data *sdata,
int idx, size_t key_len, gfp_t flags)
{
@@ -56,7 +30,7 @@ static void ieee80211_key_release(struct
struct ieee80211_key *key;
key = container_of(kref, struct ieee80211_key, kref);
- if (key->alg == ALG_CCMP)
+ if (key->conf.alg == ALG_CCMP)
ieee80211_aes_key_free(key->u.ccmp.tfm);
ieee80211_debugfs_key_remove(key);
kfree(key);
--- wireless-dev.orig/net/mac80211/rx.c 2007-08-21 16:02:54.815923881 +0200
+++ wireless-dev/net/mac80211/rx.c 2007-08-21 16:06:31.725923881 +0200
@@ -382,7 +382,7 @@ ieee80211_rx_h_load_key(struct ieee80211
/*
* If we got here for WEP, make sure we got WEP
*/
- if (trying_wep && rx->key && rx->key->alg != ALG_WEP)
+ if (trying_wep && rx->key && rx->key->conf.alg != ALG_WEP)
rx->key = NULL;
} else {
rx->key = rx->sta->key;
@@ -532,17 +532,14 @@ ieee80211_rx_h_wep_weak_iv_detection(str
{
if (!rx->sta || !(rx->fc & IEEE80211_FCTL_PROTECTED) ||
(rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
- !rx->key || rx->key->alg != ALG_WEP || !rx->u.rx.ra_match)
+ !rx->key || rx->key->conf.alg != ALG_WEP || !rx->u.rx.ra_match)
return TXRX_CONTINUE;
/* Check for weak IVs, if hwaccel did not remove IV from the frame */
if ((rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) ||
- rx->key->force_sw_encrypt) {
- u8 *iv = ieee80211_wep_is_weak_iv(rx->skb, rx->key);
- if (iv) {
+ (rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT))
+ if (ieee80211_wep_is_weak_iv(rx->skb, rx->key))
rx->sta->wep_weak_iv_count++;
- }
- }
return TXRX_CONTINUE;
}
@@ -550,7 +547,7 @@ ieee80211_rx_h_wep_weak_iv_detection(str
static ieee80211_txrx_result
ieee80211_rx_h_wep_decrypt(struct ieee80211_txrx_data *rx)
{
- if ((rx->key && rx->key->alg != ALG_WEP) ||
+ if ((rx->key && rx->key->conf.alg != ALG_WEP) ||
!(rx->fc & IEEE80211_FCTL_PROTECTED) ||
((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA &&
((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_MGMT ||
@@ -565,7 +562,7 @@ ieee80211_rx_h_wep_decrypt(struct ieee80
}
if (!(rx->u.rx.status->flag & RX_FLAG_DECRYPTED) ||
- rx->key->force_sw_encrypt) {
+ (rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
if (ieee80211_wep_decrypt(rx->local, rx->skb, rx->key)) {
if (net_ratelimit())
printk(KERN_DEBUG "%s: RX WEP frame, decrypt "
@@ -689,7 +686,7 @@ ieee80211_rx_h_defragment(struct ieee802
/* This is the first fragment of a new frame. */
entry = ieee80211_reassemble_add(rx->sdata, frag, seq,
rx->u.rx.queue, &(rx->skb));
- if (rx->key && rx->key->alg == ALG_CCMP &&
+ if (rx->key && rx->key->conf.alg == ALG_CCMP &&
(rx->fc & IEEE80211_FCTL_PROTECTED)) {
/* Store CCMP PN so that we can verify that the next
* fragment has a sequential PN value. */
@@ -716,7 +713,7 @@ ieee80211_rx_h_defragment(struct ieee802
if (entry->ccmp) {
int i;
u8 pn[CCMP_PN_LEN], *rpn;
- if (!rx->key || rx->key->alg != ALG_CCMP)
+ if (!rx->key || rx->key->conf.alg != ALG_CCMP)
return TXRX_DROP;
memcpy(pn, entry->last_pn, CCMP_PN_LEN);
for (i = CCMP_PN_LEN - 1; i >= 0; i--) {
@@ -908,7 +905,8 @@ ieee80211_rx_h_drop_unencrypted(struct i
* uploaded to the hardware.
*/
if ((rx->local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP) &&
- (!rx->key || !rx->key->force_sw_encrypt))
+ (!rx->key ||
+ !(rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)))
return TXRX_CONTINUE;
/* Drop unencrypted frames if key is set. */
--- wireless-dev.orig/net/mac80211/tkip.c 2007-08-21 14:58:36.435923881 +0200
+++ wireless-dev/net/mac80211/tkip.c 2007-08-21 16:04:26.445923881 +0200
@@ -182,7 +182,7 @@ u8 * ieee80211_tkip_add_iv(u8 *pos, stru
*pos++ = iv0;
*pos++ = iv1;
*pos++ = iv2;
- *pos++ = (key->keyidx << 6) | (1 << 5) /* Ext IV */;
+ *pos++ = (key->conf.keyidx << 6) | (1 << 5) /* Ext IV */;
*pos++ = key->u.tkip.iv32 & 0xff;
*pos++ = (key->u.tkip.iv32 >> 8) & 0xff;
*pos++ = (key->u.tkip.iv32 >> 16) & 0xff;
@@ -194,7 +194,7 @@ u8 * ieee80211_tkip_add_iv(u8 *pos, stru
void ieee80211_tkip_gen_phase1key(struct ieee80211_key *key, u8 *ta,
u16 *phase1key)
{
- tkip_mixing_phase1(ta, &key->key[ALG_TKIP_TEMP_ENCR_KEY],
+ tkip_mixing_phase1(ta, &key->conf.key[ALG_TKIP_TEMP_ENCR_KEY],
key->u.tkip.iv32, phase1key);
}
@@ -204,12 +204,13 @@ void ieee80211_tkip_gen_rc4key(struct ie
/* Calculate per-packet key */
if (key->u.tkip.iv16 == 0 || !key->u.tkip.tx_initialized) {
/* IV16 wrapped around - perform TKIP phase 1 */
- tkip_mixing_phase1(ta, &key->key[ALG_TKIP_TEMP_ENCR_KEY],
+ tkip_mixing_phase1(ta, &key->conf.key[ALG_TKIP_TEMP_ENCR_KEY],
key->u.tkip.iv32, key->u.tkip.p1k);
key->u.tkip.tx_initialized = 1;
}
- tkip_mixing_phase2(key->u.tkip.p1k, &key->key[ALG_TKIP_TEMP_ENCR_KEY],
+ tkip_mixing_phase2(key->u.tkip.p1k,
+ &key->conf.key[ALG_TKIP_TEMP_ENCR_KEY],
key->u.tkip.iv16, rc4key);
}
@@ -266,7 +267,7 @@ int ieee80211_tkip_decrypt_data(struct c
if (!(keyid & (1 << 5)))
return TKIP_DECRYPT_NO_EXT_IV;
- if ((keyid >> 6) != key->keyidx)
+ if ((keyid >> 6) != key->conf.keyidx)
return TKIP_DECRYPT_INVALID_KEYIDX;
if (key->u.tkip.rx_initialized[queue] &&
@@ -293,7 +294,7 @@ int ieee80211_tkip_decrypt_data(struct c
key->u.tkip.iv32_rx[queue] != iv32) {
key->u.tkip.rx_initialized[queue] = 1;
/* IV16 wrapped around - perform TKIP phase 1 */
- tkip_mixing_phase1(ta, &key->key[ALG_TKIP_TEMP_ENCR_KEY],
+ tkip_mixing_phase1(ta, &key->conf.key[ALG_TKIP_TEMP_ENCR_KEY],
iv32, key->u.tkip.p1k_rx[queue]);
#ifdef CONFIG_TKIP_DEBUG
{
@@ -302,7 +303,8 @@ int ieee80211_tkip_decrypt_data(struct c
" TK=", MAC_ARG(ta));
for (i = 0; i < 16; i++)
printk("%02x ",
- key->key[ALG_TKIP_TEMP_ENCR_KEY + i]);
+ key->conf.key[
+ ALG_TKIP_TEMP_ENCR_KEY + i]);
printk("\n");
printk(KERN_DEBUG "TKIP decrypt: P1K=");
for (i = 0; i < 5; i++)
@@ -313,7 +315,7 @@ int ieee80211_tkip_decrypt_data(struct c
}
tkip_mixing_phase2(key->u.tkip.p1k_rx[queue],
- &key->key[ALG_TKIP_TEMP_ENCR_KEY],
+ &key->conf.key[ALG_TKIP_TEMP_ENCR_KEY],
iv16, rc4key);
#ifdef CONFIG_TKIP_DEBUG
{
--- wireless-dev.orig/net/mac80211/tx.c 2007-08-21 16:04:00.675923881 +0200
+++ wireless-dev/net/mac80211/tx.c 2007-08-21 16:04:26.445923881 +0200
@@ -538,11 +538,11 @@ ieee80211_tx_h_fragment(struct ieee80211
static int wep_encrypt_skb(struct ieee80211_txrx_data *tx, struct sk_buff *skb)
{
- if (tx->key->force_sw_encrypt) {
+ if (tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) {
if (ieee80211_wep_encrypt(tx->local, skb, tx->key))
return -1;
} else {
- tx->u.tx.control->key_idx = tx->key->hw_key_idx;
+ tx->u.tx.control->key_idx = tx->key->conf.hw_key_idx;
if (tx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) {
if (ieee80211_wep_add_iv(tx->local, skb, tx->key) ==
NULL)
@@ -560,7 +560,7 @@ ieee80211_tx_h_wep_encrypt(struct ieee80
fc = le16_to_cpu(hdr->frame_control);
- if (!tx->key || tx->key->alg != ALG_WEP ||
+ if (!tx->key || tx->key->conf.alg != ALG_WEP ||
((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA &&
((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_MGMT ||
(fc & IEEE80211_FCTL_STYPE) != IEEE80211_STYPE_AUTH)))
--- wireless-dev.orig/net/mac80211/wep.c 2007-08-21 14:58:36.495923881 +0200
+++ wireless-dev/net/mac80211/wep.c 2007-08-21 16:04:26.455923881 +0200
@@ -67,7 +67,7 @@ void ieee80211_wep_get_iv(struct ieee802
struct ieee80211_key *key, u8 *iv)
{
local->wep_iv++;
- if (ieee80211_wep_weak_iv(local->wep_iv, key->keylen))
+ if (ieee80211_wep_weak_iv(local->wep_iv, key->conf.keylen))
local->wep_iv += 0x0100;
if (!iv)
@@ -76,7 +76,7 @@ void ieee80211_wep_get_iv(struct ieee802
*iv++ = (local->wep_iv >> 16) & 0xff;
*iv++ = (local->wep_iv >> 8) & 0xff;
*iv++ = local->wep_iv & 0xff;
- *iv++ = key->keyidx << 6;
+ *iv++ = key->conf.keyidx << 6;
}
@@ -159,10 +159,10 @@ int ieee80211_wep_encrypt(struct ieee802
u8 *rc4key, *iv;
size_t len;
- if (!key || key->alg != ALG_WEP)
+ if (!key || key->conf.alg != ALG_WEP)
return -1;
- klen = 3 + key->keylen;
+ klen = 3 + key->conf.keylen;
rc4key = kmalloc(klen, GFP_ATOMIC);
if (!rc4key)
return -1;
@@ -179,7 +179,7 @@ int ieee80211_wep_encrypt(struct ieee802
memcpy(rc4key, iv, 3);
/* Copy rest of the WEP key (the secret part) */
- memcpy(rc4key + 3, key->key, key->keylen);
+ memcpy(rc4key + 3, key->conf.key, key->conf.keylen);
/* Add room for ICV */
skb_put(skb, WEP_ICV_LEN);
@@ -251,10 +251,10 @@ int ieee80211_wep_decrypt(struct ieee802
keyidx = skb->data[hdrlen + 3] >> 6;
- if (!key || keyidx != key->keyidx || key->alg != ALG_WEP)
+ if (!key || keyidx != key->conf.keyidx || key->conf.alg != ALG_WEP)
return -1;
- klen = 3 + key->keylen;
+ klen = 3 + key->conf.keylen;
rc4key = kmalloc(klen, GFP_ATOMIC);
if (!rc4key)
@@ -264,7 +264,7 @@ int ieee80211_wep_decrypt(struct ieee802
memcpy(rc4key, skb->data + hdrlen, 3);
/* Copy rest of the WEP key (the secret part) */
- memcpy(rc4key + 3, key->key, key->keylen);
+ memcpy(rc4key + 3, key->conf.key, key->conf.keylen);
if (ieee80211_wep_decrypt_data(local->wep_rx_tfm, rc4key, klen,
skb->data + hdrlen + WEP_IV_LEN,
@@ -321,7 +321,7 @@ u8 * ieee80211_wep_is_weak_iv(struct sk_
ivpos = skb->data + hdrlen;
iv = (ivpos[0] << 16) | (ivpos[1] << 8) | ivpos[2];
- if (ieee80211_wep_weak_iv(iv, key->keylen))
+ if (ieee80211_wep_weak_iv(iv, key->conf.keylen))
return ivpos;
return NULL;
--- wireless-dev.orig/net/mac80211/wpa.c 2007-08-21 16:00:34.675923881 +0200
+++ wireless-dev/net/mac80211/wpa.c 2007-08-21 16:04:26.455923881 +0200
@@ -86,7 +86,7 @@ ieee80211_tx_h_michael_mic_add(struct ie
fc = tx->fc;
- if (!tx->key || tx->key->alg != ALG_TKIP || skb->len < 24 ||
+ if (!tx->key || tx->key->conf.alg != ALG_TKIP || skb->len < 24 ||
!WLAN_FC_DATA_PRESENT(fc))
return TXRX_CONTINUE;
@@ -101,7 +101,7 @@ ieee80211_tx_h_michael_mic_add(struct ie
}
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!tx->key->force_sw_encrypt &&
+ if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
!tx->fragmented &&
!(tx->local->hw.flags & IEEE80211_HW_TKIP_INCLUDE_MMIC) &&
!wpa_test) {
@@ -126,8 +126,8 @@ ieee80211_tx_h_michael_mic_add(struct ie
#else
authenticator = 1;
#endif
- key = &tx->key->key[authenticator ? ALG_TKIP_TEMP_AUTH_TX_MIC_KEY :
- ALG_TKIP_TEMP_AUTH_RX_MIC_KEY];
+ key = &tx->key->conf.key[authenticator ? ALG_TKIP_TEMP_AUTH_TX_MIC_KEY :
+ ALG_TKIP_TEMP_AUTH_RX_MIC_KEY];
mic = skb_put(skb, MICHAEL_MIC_LEN);
michael_mic(key, da, sa, qos_tid & 0x0f, data, data_len, mic);
@@ -173,7 +173,7 @@ ieee80211_rx_h_michael_mic_verify(struct
if (rx->local->hw.flags & IEEE80211_HW_DEVICE_STRIPS_MIC)
return TXRX_CONTINUE;
- if (!rx->key || rx->key->alg != ALG_TKIP ||
+ if (!rx->key || rx->key->conf.alg != ALG_TKIP ||
!(rx->fc & IEEE80211_FCTL_PROTECTED) || !WLAN_FC_DATA_PRESENT(fc))
return TXRX_CONTINUE;
@@ -184,7 +184,7 @@ ieee80211_rx_h_michael_mic_verify(struct
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !rx->key->force_sw_encrypt) {
+ !(rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
if (rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) {
if (skb->len < MICHAEL_MIC_LEN)
return TXRX_DROP;
@@ -207,8 +207,8 @@ ieee80211_rx_h_michael_mic_verify(struct
#else
authenticator = 1;
#endif
- key = &rx->key->key[authenticator ? ALG_TKIP_TEMP_AUTH_RX_MIC_KEY :
- ALG_TKIP_TEMP_AUTH_TX_MIC_KEY];
+ key = &rx->key->conf.key[authenticator ? ALG_TKIP_TEMP_AUTH_RX_MIC_KEY :
+ ALG_TKIP_TEMP_AUTH_TX_MIC_KEY];
michael_mic(key, da, sa, qos_tid & 0x0f, data, data_len, mic);
#ifdef CONFIG_HOSTAPD_WPA_TESTING
if (rx->sta && rx->sta->wpa_trigger & WPA_TRIGGER_FAIL_RX_MIC) {
@@ -244,7 +244,7 @@ ieee80211_rx_h_michael_mic_verify(struct
printk(" (%d)\n", authenticator);
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- mac80211_ev_michael_mic_failure(rx->dev, rx->key->keyidx,
+ mac80211_ev_michael_mic_failure(rx->dev, rx->key->conf.keyidx,
(void *) skb->data);
return TXRX_DROP;
}
@@ -270,7 +270,11 @@ static int tkip_encrypt_skb(struct ieee8
hdrlen = ieee80211_get_hdrlen(fc);
len = skb->len - hdrlen;
- tailneed = !tx->key->force_sw_encrypt ? 0 : TKIP_ICV_LEN;
+ if (tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
+ tailneed = TKIP_ICV_LEN;
+ else
+ tailneed = 0;
+
if ((skb_headroom(skb) < TKIP_IV_LEN ||
skb_tailroom(skb) < tailneed)) {
I802_DEBUG_INC(tx->local->tx_expand_skb_head);
@@ -302,7 +306,7 @@ iv_inc:
skip_iv_inc:
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!tx->key->force_sw_encrypt
+ if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
#ifdef CONFIG_HOSTAPD_WPA_TESTING
&& !tx->wpa_test
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
@@ -333,7 +337,7 @@ skip_iv_inc:
~IEEE80211_TXCTL_TKIP_NEW_PHASE1_KEY;
}
- tx->u.tx.control->key_idx = tx->key->hw_key_idx;
+ tx->u.tx.control->key_idx = tx->key->conf.hw_key_idx;
return 0;
}
@@ -358,7 +362,7 @@ ieee80211_tx_h_tkip_encrypt(struct ieee8
fc = le16_to_cpu(hdr->frame_control);
- if (!key || key->alg != ALG_TKIP || !WLAN_FC_DATA_PRESENT(fc))
+ if (!key || key->conf.alg != ALG_TKIP || !WLAN_FC_DATA_PRESENT(fc))
return TXRX_CONTINUE;
tx->u.tx.control->icv_len = TKIP_ICV_LEN;
@@ -396,11 +400,11 @@ ieee80211_tx_h_tkip_encrypt(struct ieee8
}
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!tx->key->force_sw_encrypt &&
+ if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
!(tx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) &&
!wpa_test) {
/* hwaccel - with no need for preallocated room for IV/ICV */
- tx->u.tx.control->key_idx = tx->key->hw_key_idx;
+ tx->u.tx.control->key_idx = tx->key->conf.hw_key_idx;
return TXRX_CONTINUE;
}
@@ -455,7 +459,7 @@ ieee80211_rx_h_tkip_decrypt(struct ieee8
fc = le16_to_cpu(hdr->frame_control);
hdrlen = ieee80211_get_hdrlen(fc);
- if (!rx->key || rx->key->alg != ALG_TKIP ||
+ if (!rx->key || rx->key->conf.alg != ALG_TKIP ||
!(rx->fc & IEEE80211_FCTL_PROTECTED) ||
(rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA)
return TXRX_CONTINUE;
@@ -475,7 +479,7 @@ ieee80211_rx_h_tkip_decrypt(struct ieee8
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !rx->key->force_sw_encrypt) {
+ !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
if (!(rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV)) {
/* Hardware takes care of all processing, including
* replay protection, so no need to continue here. */
@@ -619,7 +623,10 @@ static int ccmp_encrypt_skb(struct ieee8
hdrlen = ieee80211_get_hdrlen(fc);
len = skb->len - hdrlen;
- tailneed = !key->force_sw_encrypt ? 0 : CCMP_MIC_LEN;
+ if (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
+ tailneed = CCMP_MIC_LEN;
+ else
+ tailneed = 0;
if ((skb_headroom(skb) < CCMP_HDR_LEN ||
skb_tailroom(skb) < tailneed)) {
@@ -657,11 +664,11 @@ pn_inc:
skip_pn_inc:
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- ccmp_pn2hdr(pos, pn, key->keyidx);
+ ccmp_pn2hdr(pos, pn, key->conf.keyidx);
- if (!key->force_sw_encrypt) {
+ if (!(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
/* hwaccel - with preallocated room for CCMP header */
- tx->u.tx.control->key_idx = key->hw_key_idx;
+ tx->u.tx.control->key_idx = key->conf.hw_key_idx;
return 0;
}
@@ -685,7 +692,7 @@ ieee80211_tx_h_ccmp_encrypt(struct ieee8
fc = le16_to_cpu(hdr->frame_control);
- if (!key || key->alg != ALG_CCMP || !WLAN_FC_DATA_PRESENT(fc))
+ if (!key || key->conf.alg != ALG_CCMP || !WLAN_FC_DATA_PRESENT(fc))
return TXRX_CONTINUE;
#ifdef CONFIG_HOSTAPD_WPA_TESTING
@@ -713,11 +720,11 @@ ieee80211_tx_h_ccmp_encrypt(struct ieee8
tx->u.tx.control->iv_len = CCMP_HDR_LEN;
ieee80211_tx_set_iswep(tx);
- if (!tx->key->force_sw_encrypt &&
+ if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
!(tx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV)) {
/* hwaccel - with no need for preallocated room for CCMP "
* header or MIC fields */
- tx->u.tx.control->key_idx = tx->key->hw_key_idx;
+ tx->u.tx.control->key_idx = tx->key->conf.hw_key_idx;
return TXRX_CONTINUE;
}
@@ -755,7 +762,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee8
fc = le16_to_cpu(hdr->frame_control);
hdrlen = ieee80211_get_hdrlen(fc);
- if (!key || key->alg != ALG_CCMP ||
+ if (!key || key->conf.alg != ALG_CCMP ||
!(rx->fc & IEEE80211_FCTL_PROTECTED) ||
(rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA)
return TXRX_CONTINUE;
@@ -765,7 +772,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee8
return TXRX_DROP;
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !key->force_sw_encrypt &&
+ !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
!(rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV))
return TXRX_CONTINUE;
@@ -786,7 +793,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee8
}
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !key->force_sw_encrypt) {
+ !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
/* hwaccel has already decrypted frame and verified MIC */
} else {
u8 *scratch, *b_0, *aad;
--- wireless-dev.orig/net/mac80211/ieee80211_iface.c 2007-08-21 14:58:40.435923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_iface.c 2007-08-21 16:04:26.455923881 +0200
@@ -244,7 +244,8 @@ void ieee80211_if_reinit(struct net_devi
memset(addr, 0xff, ETH_ALEN);
if (local->ops->set_key)
local->ops->set_key(local_to_hw(local), DISABLE_KEY, addr,
- local->keys[i], 0);
+ local->keys[i],
+ local->default_wep_only);
#endif
ieee80211_key_free(sdata->keys[i]);
sdata->keys[i] = NULL;
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] mac80211: revamp key handling
2007-08-21 15:57 [PATCH 0/3] improve mac80211 key handling Johannes Berg
2007-08-21 15:57 ` [PATCH 1/3] mac80211: embed key conf in key, fix driver interface Johannes Berg
@ 2007-08-21 15:57 ` Johannes Berg
2007-08-30 23:45 ` Johannes Berg
2007-08-21 15:57 ` [PATCH 3/3] mac80211: add interface index to key debugfs Johannes Berg
2 siblings, 1 reply; 7+ messages in thread
From: Johannes Berg @ 2007-08-21 15:57 UTC (permalink / raw)
To: John Linville; +Cc: Jiri Benc, Michael Wu, linux-wireless
A whole bunch of things:
1) remove krefs for keys, they aren't really refcounted
2) move code and hardware acceleration handling into
key.c, weed out ieee80211_ioctl.c
3) remove the extended error codes, hostapd and wpa_supplicant
don't use them
4) remove the default_wep_only stuff, this wasn't really
done well and no current driver actually cared, allow
drivers to handle this instead by giving them access
to the local MAC address where the key should be used.
Also allow drivers to keep a list of keys and tell us that
they've had to disable a key.
5) Remove adding a fake key with a NONE key algorithm for each
associated STA. If we have hardware with such TX filtering
we should probably extend the sta_table_notification()
callback with the sta information instead; the fact that
it's treated as a key for some atheros hardware shouldn't
bother the stack.
6) Turn off hardware acceleration for keys when the interface
is down. This is necessary because otherwise monitor
interfaces could be decrypting frames for other interfaces
that are down at the moment. Also, it should go some way
towards better suspend/resume support, in any case the
routines used here could be used for that as well.
Additionally, this makes the driver interface nicer, keys
for a specific local MAC address are only ever present
while an interface with that MAC address is enabled.
7) Change driver set_key() callback interface to allow only
return values of -ENOSPC, -EOPNOTSUPP and 0, warn on all
other return values. This allows debugging the stack when
a driver notices it's handed a key while it is down.
8) Invert the flag meaning to KEY_FLAG_UPLOADED_TO_HARDWARE.
9) Remove REMOVE_ALL_KEYS command as it isn't used nor do we
want to use it, we'll use DISABLE_KEY for each key. It is
hard to use REMOVE_ALL_KEYS because we can handle multiple
virtual interfaces with different key configuration, so we'd
have to keep track of a lot of state for this and that isn't
worth it.
10) Warn when disabling a key fails, it musn't.
11) Remove IEEE80211_HW_NO_TKIP_WMM_HWACCEL in favour of per-key
IEEE80211_KEY_FLAG_WMM_STA to let driver sort it out itself.
12) Tell driver that a (non-WEP) key is used only for transmission
by using an all-zeroes station MAC address when configuring.
13) Update b43 and iwlwifi, but iwlwifi will give loads of
warnings because it never disables keys, I don't know the
hardware nor the driver well enough to fix that though.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Changes since v1:
* fix use-after-free bug pointed out by Larry.
Changes since v2:
* remove the TKIP/WMM stuff
* tell driver about TX-only keys
drivers/net/wireless/adm8211.c | 2
drivers/net/wireless/b43/b43.h | 2
drivers/net/wireless/b43/main.c | 40 +--
drivers/net/wireless/iwl-base.c | 13 -
drivers/net/wireless/rt2x00/rt2400pci.c | 1
drivers/net/wireless/rt2x00/rt2500pci.c | 1
drivers/net/wireless/rt2x00/rt2500usb.c | 1
drivers/net/wireless/rt2x00/rt61pci.c | 1
drivers/net/wireless/rt2x00/rt73usb.c | 1
include/net/mac80211.h | 91 +++++++-
net/mac80211/debugfs_key.c | 4
net/mac80211/debugfs_sta.c | 1
net/mac80211/hostapd_ioctl.h | 6
net/mac80211/ieee80211.c | 6
net/mac80211/ieee80211_i.h | 19 -
net/mac80211/ieee80211_iface.c | 25 --
net/mac80211/ieee80211_ioctl.c | 341 +++-----------------------------
net/mac80211/ieee80211_key.h | 28 ++
net/mac80211/key.c | 279 +++++++++++++++++++++++++-
net/mac80211/rx.c | 7
net/mac80211/sta_info.c | 30 --
net/mac80211/sta_info.h | 4
net/mac80211/tx.c | 9
net/mac80211/wpa.c | 30 +-
24 files changed, 479 insertions(+), 463 deletions(-)
--- wireless-dev.orig/net/mac80211/ieee80211_i.h 2007-08-21 16:25:44.625923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_i.h 2007-08-21 16:26:46.365923881 +0200
@@ -22,6 +22,7 @@
#include <linux/types.h>
#include <linux/spinlock.h>
#include <linux/etherdevice.h>
+#include <linux/mutex.h>
#include <net/wireless.h>
#include "ieee80211_key.h"
#include "sta_info.h"
@@ -314,6 +315,10 @@ struct ieee80211_sub_if_data {
struct wireless_dev wdev;
+ /* keys */
+ struct mutex key_mtx;
+ struct list_head key_list;
+
struct net_device *dev;
struct ieee80211_local *local;
@@ -624,9 +629,6 @@ struct ieee80211_local {
#endif /* CONFIG_MAC80211_DEBUG_COUNTERS */
- int default_wep_only; /* only default WEP keys are used with this
- * interface; this is used to decide when hwaccel
- * can be used with default keys */
int total_ps_buffered; /* total number of all buffered unicast and
* multicast packets for power saving stations
*/
@@ -813,12 +815,6 @@ void ieee80211_key_threshold_notify(stru
int ieee80211_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
extern const struct iw_handler_def ieee80211_iw_handler_def;
-/* Set hw encryption from ieee80211 */
-int ieee80211_set_hw_encryption(struct net_device *dev,
- struct sta_info *sta, u8 addr[ETH_ALEN],
- struct ieee80211_key *key);
-void ieee80211_update_default_wep_only(struct ieee80211_local *local);
-
/* Least common multiple of the used rates (in 100 kbps). This is used to
* calculate rate_inv values for each rate so that only integers are needed. */
@@ -922,11 +918,6 @@ int ieee80211_monitor_start_xmit(struct
int ieee80211_subif_start_xmit(struct sk_buff *skb, struct net_device *dev);
int ieee80211_mgmt_start_xmit(struct sk_buff *skb, struct net_device *dev);
-/* key handling */
-struct ieee80211_key *ieee80211_key_alloc(struct ieee80211_sub_if_data *sdata,
- int idx, size_t key_len, gfp_t flags);
-void ieee80211_key_free(struct ieee80211_key *key);
-
/* utility functions/constants */
extern void *mac80211_wiphy_privid; /* for wiphy privid */
extern const unsigned char rfc1042_header[6];
--- wireless-dev.orig/net/mac80211/ieee80211_ioctl.c 2007-08-21 16:25:44.575923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_ioctl.c 2007-08-21 16:26:46.375923881 +0200
@@ -25,7 +25,6 @@
#include "ieee80211_rate.h"
#include "wpa.h"
#include "aes_ccm.h"
-#include "debugfs_key.h"
static int ieee80211_ioctl_set_beacon(struct net_device *dev,
@@ -213,7 +212,6 @@ static int ieee80211_ioctl_add_sta(struc
int i, j;
struct ieee80211_sub_if_data *sdata;
struct ieee80211_hw_mode *mode;
- int add_key_entry = 1;
/* Prevent a race with changing the rate control algorithm */
if (!netif_running(dev))
@@ -271,24 +269,6 @@ static int ieee80211_ioctl_add_sta(struc
else
sta->flags &= ~WLAN_STA_WDS;
- if (add_key_entry && !sta->key && !sdata->default_key &&
- local->ops->set_key) {
- struct ieee80211_key_conf conf;
- /* Add key cache entry with NULL key type because this may used
- * for TX filtering. */
- memset(&conf, 0, sizeof(conf));
- conf.hw_key_idx = HW_KEY_IDX_INVALID;
- conf.alg = ALG_NONE;
- conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- if (local->ops->set_key(local_to_hw(local), SET_KEY,
- sta->addr, &conf,
- local->default_wep_only)) {
- sta->key_idx_compression = HW_KEY_IDX_INVALID;
- } else {
- sta->key_idx_compression = conf.hw_key_idx;
- }
- }
-
sta_info_put(sta);
if (sdata->type == IEEE80211_IF_TYPE_AP ||
@@ -393,44 +373,14 @@ static int ieee80211_ioctl_set_flags_sta
}
-int ieee80211_set_hw_encryption(struct net_device *dev,
- struct sta_info *sta, u8 addr[ETH_ALEN],
- struct ieee80211_key *key)
-{
- struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
- int rc = 0;
-
- /*
- * default to sw encryption; this will be cleared by low-level
- * driver if the hw supports requested encryption
- */
- if (key)
- key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
-
- if (key && local->ops->set_key) {
- rc = local->ops->set_key(local_to_hw(local), SET_KEY, addr,
- &key->conf, local->default_wep_only);
- if (rc) {
- rc = HOSTAP_CRYPT_ERR_KEY_SET_FAILED;
- /* protect against buggy drivers */
- key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
- }
- }
-
- return rc;
-}
-
-
static int ieee80211_set_encryption(struct net_device *dev, u8 *sta_addr,
- int idx, int alg, int set_tx_key, u32 *err,
+ int idx, int alg, int set_tx_key,
const u8 *_key, size_t key_len)
{
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
int ret = 0;
struct sta_info *sta;
- struct ieee80211_key *key, *old_key;
- int try_hwaccel = 1;
+ struct ieee80211_key *key;
struct ieee80211_sub_if_data *sdata;
sdata = IEEE80211_DEV_TO_SUB_IF(dev);
@@ -443,16 +393,6 @@ static int ieee80211_set_encryption(stru
return -EINVAL;
}
key = sdata->keys[idx];
-
- /* TODO: consider adding hwaccel support for these; at least
- * Atheros key cache should be able to handle this since AP is
- * only transmitting frames with default keys. */
- /* FIX: hw key cache can be used when only one virtual
- * STA is associated with each AP. If more than one STA
- * is associated to the same AP, software encryption
- * must be used. This should be done automatically
- * based on configured station devices. For the time
- * being, this can be only set at compile time. */
} else {
set_tx_key = 0;
if (idx != 0) {
@@ -463,8 +403,6 @@ static int ieee80211_set_encryption(stru
sta = sta_info_get(local, sta_addr);
if (!sta) {
- if (err)
- *err = HOSTAP_CRYPT_ERR_UNKNOWN_ADDR;
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
printk(KERN_DEBUG "%s: set_encrypt - unknown addr "
MAC_FMT "\n",
@@ -477,146 +415,28 @@ static int ieee80211_set_encryption(stru
key = sta->key;
}
- /* FIX:
- * Cannot configure default hwaccel keys with WEP algorithm, if
- * any of the virtual interfaces is using static WEP
- * configuration because hwaccel would otherwise try to decrypt
- * these frames.
- *
- * For now, just disable WEP hwaccel for broadcast when there is
- * possibility of conflict with default keys. This can maybe later be
- * optimized by using non-default keys (at least with Atheros ar521x).
- */
- if (!sta && alg == ALG_WEP && !local->default_wep_only &&
- sdata->type != IEEE80211_IF_TYPE_IBSS &&
- sdata->type != IEEE80211_IF_TYPE_AP) {
- try_hwaccel = 0;
- }
-
- if (local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP) {
- /* Software encryption cannot be used with devices that hide
- * encryption from the host system, so always try to use
- * hardware acceleration with such devices. */
- try_hwaccel = 1;
- }
-
- if ((local->hw.flags & IEEE80211_HW_NO_TKIP_WMM_HWACCEL) &&
- alg == ALG_TKIP) {
- if (sta && (sta->flags & WLAN_STA_WME)) {
- /* Hardware does not support hwaccel with TKIP when using WMM.
- */
- try_hwaccel = 0;
- }
- else if (sdata->type == IEEE80211_IF_TYPE_STA) {
- sta = sta_info_get(local, sdata->u.sta.bssid);
- if (sta) {
- if (sta->flags & WLAN_STA_WME) {
- try_hwaccel = 0;
- }
- sta_info_put(sta);
- sta = NULL;
- }
- }
- }
-
if (alg == ALG_NONE) {
- if (try_hwaccel && key &&
- key->conf.hw_key_idx != HW_KEY_IDX_INVALID &&
- local->ops->set_key &&
- local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- sta_addr, &key->conf,
- local->default_wep_only)) {
- if (err)
- *err = HOSTAP_CRYPT_ERR_KEY_SET_FAILED;
- printk(KERN_DEBUG "%s: set_encrypt - low-level disable"
- " failed\n", dev->name);
- ret = -EINVAL;
- }
-
- if (set_tx_key || sdata->default_key == key) {
- ieee80211_debugfs_key_remove_default(sdata);
- sdata->default_key = NULL;
- }
- ieee80211_debugfs_key_remove(key);
- if (sta)
- sta->key = NULL;
- else
- sdata->keys[idx] = NULL;
ieee80211_key_free(key);
key = NULL;
} else {
- old_key = key;
- key = ieee80211_key_alloc(sta ? NULL : sdata, idx, key_len,
- GFP_KERNEL);
+ /*
+ * Need to free it before allocating a new one with
+ * with the same index or the ordering to the driver's
+ * set_key() callback becomes confused.
+ */
+ ieee80211_key_free(key);
+ key = ieee80211_key_alloc(sdata, sta, alg, idx, key_len, _key);
if (!key) {
ret = -ENOMEM;
goto err_out;
}
-
- /* default to sw encryption; low-level driver sets these if the
- * requested encryption is supported */
- key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
- key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
-
- key->conf.alg = alg;
- key->conf.keyidx = idx;
- key->conf.keylen = key_len;
- memcpy(key->conf.key, _key, key_len);
-
- if (alg == ALG_CCMP) {
- /* Initialize AES key state here as an optimization
- * so that it does not need to be initialized for every
- * packet. */
- key->u.ccmp.tfm = ieee80211_aes_key_setup_encrypt(
- key->conf.key);
- if (!key->u.ccmp.tfm) {
- ret = -ENOMEM;
- goto err_free;
- }
- }
-
- if (set_tx_key || sdata->default_key == old_key) {
- ieee80211_debugfs_key_remove_default(sdata);
- sdata->default_key = NULL;
- }
- ieee80211_debugfs_key_remove(old_key);
- if (sta)
- sta->key = key;
- else
- sdata->keys[idx] = key;
- ieee80211_key_free(old_key);
- ieee80211_debugfs_key_add(local, key);
- if (sta)
- ieee80211_debugfs_key_sta_link(key, sta);
-
- if (try_hwaccel &&
- (alg == ALG_WEP || alg == ALG_TKIP || alg == ALG_CCMP)) {
- int e = ieee80211_set_hw_encryption(dev, sta, sta_addr,
- key);
- if (err)
- *err = e;
- }
- }
-
- if (set_tx_key || (!sta && !sdata->default_key && key)) {
- sdata->default_key = key;
- if (key)
- ieee80211_debugfs_key_add_default(sdata);
-
- if (local->ops->set_key_idx &&
- local->ops->set_key_idx(local_to_hw(local), idx))
- printk(KERN_DEBUG "%s: failed to set TX key idx for "
- "low-level driver\n", dev->name);
}
- if (sta)
- sta_info_put(sta);
+ if (set_tx_key || (!sta && !sdata->default_key && key))
+ ieee80211_set_default_key(sdata, idx);
- return 0;
-
-err_free:
- ieee80211_key_free(key);
-err_out:
+ ret = 0;
+ err_out:
if (sta)
sta_info_put(sta);
return ret;
@@ -661,7 +481,6 @@ static int ieee80211_ioctl_set_encryptio
}
alg = ALG_CCMP;
} else {
- param->u.crypt.err = HOSTAP_CRYPT_ERR_UNKNOWN_ALG;
printk(KERN_DEBUG "%s: set_encrypt - unknown alg\n",
dev->name);
return -EINVAL;
@@ -671,7 +490,7 @@ static int ieee80211_ioctl_set_encryptio
dev, param->sta_addr,
param->u.crypt.idx, alg,
param->u.crypt.flags & HOSTAP_CRYPT_FLAG_SET_TX_KEY,
- ¶m->u.crypt.err, param->u.crypt.key,
+ param->u.crypt.key,
param->u.crypt.key_len);
}
@@ -683,7 +502,7 @@ static int ieee80211_ioctl_get_encryptio
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
int ret = 0;
struct sta_info *sta;
- struct ieee80211_key **key;
+ struct ieee80211_key *key;
int max_key_len;
struct ieee80211_sub_if_data *sdata;
u8 *pos;
@@ -704,24 +523,22 @@ static int ieee80211_ioctl_get_encryptio
sdata->default_key->conf.keyidx : 0;
return 0;
} else
- key = &sdata->keys[param->u.crypt.idx];
+ key = sdata->keys[param->u.crypt.idx];
} else {
sta = sta_info_get(local, param->sta_addr);
- if (!sta) {
- param->u.crypt.err = HOSTAP_CRYPT_ERR_UNKNOWN_ADDR;
+ if (!sta)
return -EINVAL;
- }
- key = &sta->key;
+ key = sta->key;
}
memset(param->u.crypt.seq_counter, 0, HOSTAP_SEQ_COUNTER_SIZE);
- if (!*key) {
+ if (!key) {
memcpy(param->u.crypt.alg, "none", 5);
param->u.crypt.key_len = 0;
param->u.crypt.idx = 0xff;
} else {
- switch ((*key)->conf.alg) {
+ switch (key->conf.alg) {
case ALG_WEP:
memcpy(param->u.crypt.alg, "WEP", 4);
break;
@@ -736,7 +553,7 @@ static int ieee80211_ioctl_get_encryptio
if (local->ops->get_sequence_counter(
local_to_hw(local),
param->sta_addr,
- (*key)->conf.keyidx,
+ key->conf.keyidx,
IEEE80211_SEQ_COUNTER_TX,
&iv32,
&iv16)) {
@@ -745,8 +562,8 @@ static int ieee80211_ioctl_get_encryptio
}
} else {
/* Get it from our own local data */
- iv32 = (*key)->u.tkip.iv32;
- iv16 = (*key)->u.tkip.iv16;
+ iv32 = key->u.tkip.iv32;
+ iv16 = key->u.tkip.iv16;
}
pos = param->u.crypt.seq_counter;
*pos++ = iv16 & 0xff;
@@ -762,7 +579,7 @@ static int ieee80211_ioctl_get_encryptio
u8 *pn;
memcpy(param->u.crypt.alg, "CCMP", 5);
pos = param->u.crypt.seq_counter;
- pn = (*key)->u.ccmp.tx_pn;
+ pn = key->u.ccmp.tx_pn;
*pos++ = pn[5];
*pos++ = pn[4];
*pos++ = pn[3];
@@ -776,12 +593,12 @@ static int ieee80211_ioctl_get_encryptio
break;
}
- if (max_key_len < (*key)->conf.keylen)
+ if (max_key_len < key->conf.keylen)
ret = -E2BIG;
else {
- param->u.crypt.key_len = (*key)->conf.keylen;
- memcpy(param->u.crypt.key, (*key)->conf.key,
- (*key)->conf.keylen);
+ param->u.crypt.key_len = key->conf.keylen;
+ memcpy(param->u.crypt.key, key->conf.key,
+ key->conf.keylen);
}
}
@@ -1812,95 +1629,6 @@ static int ieee80211_ioctl_giwretry(stru
return 0;
}
-static void ieee80211_key_enable_hwaccel(struct ieee80211_local *local,
- struct ieee80211_key *key)
-{
- u8 addr[ETH_ALEN];
-
- if (!key || key->conf.alg != ALG_WEP ||
- !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) ||
- (local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP))
- return;
-
- memset(addr, 0xff, ETH_ALEN);
-
- if (local->ops->set_key)
- local->ops->set_key(local_to_hw(local),
- SET_KEY, addr, &key->conf,
- local->default_wep_only);
-}
-
-
-static void ieee80211_key_disable_hwaccel(struct ieee80211_local *local,
- struct ieee80211_key *key)
-{
- u8 addr[ETH_ALEN];
-
- if (!key || key->conf.alg != ALG_WEP ||
- (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) ||
- (local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP))
- return;
-
- memset(addr, 0xff, ETH_ALEN);
- if (local->ops->set_key)
- local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- addr, &key->conf,
- local->default_wep_only);
- key->conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
-}
-
-
-static int ieee80211_ioctl_default_wep_only(struct ieee80211_local *local,
- int value)
-{
- int i;
- struct ieee80211_sub_if_data *sdata;
-
- local->default_wep_only = value;
- read_lock(&local->sub_if_lock);
- list_for_each_entry(sdata, &local->sub_if_list, list)
- for (i = 0; i < NUM_DEFAULT_KEYS; i++)
- if (value)
- ieee80211_key_enable_hwaccel(local,
- sdata->keys[i]);
- else
- ieee80211_key_disable_hwaccel(local,
- sdata->keys[i]);
- read_unlock(&local->sub_if_lock);
-
- return 0;
-}
-
-
-void ieee80211_update_default_wep_only(struct ieee80211_local *local)
-{
- int i = 0;
- struct ieee80211_sub_if_data *sdata;
-
- read_lock(&local->sub_if_lock);
- list_for_each_entry(sdata, &local->sub_if_list, list) {
-
- if (sdata->dev == local->mdev)
- continue;
-
- /* If there is an AP interface then depend on userspace to
- set default_wep_only correctly. */
- if (sdata->type == IEEE80211_IF_TYPE_AP) {
- read_unlock(&local->sub_if_lock);
- return;
- }
-
- i++;
- }
-
- read_unlock(&local->sub_if_lock);
-
- if (i <= 1)
- ieee80211_ioctl_default_wep_only(local, 1);
- else
- ieee80211_ioctl_default_wep_only(local, 0);
-}
-
static int ieee80211_ioctl_prism2_param(struct net_device *dev,
struct iw_request_info *info,
@@ -2222,12 +1950,7 @@ static int ieee80211_ioctl_siwencode(str
alg = ALG_NONE;
else if (erq->length == 0) {
/* No key data - just set the default TX key index */
- if (sdata->default_key != sdata->keys[idx]) {
- ieee80211_debugfs_key_remove_default(sdata);
- sdata->default_key = sdata->keys[idx];
- if (sdata->default_key)
- ieee80211_debugfs_key_add_default(sdata);
- }
+ ieee80211_set_default_key(sdata, idx);
return 0;
}
@@ -2235,7 +1958,7 @@ static int ieee80211_ioctl_siwencode(str
dev, bcaddr,
idx, alg,
!sdata->default_key,
- NULL, keybuf, erq->length);
+ keybuf, erq->length);
}
@@ -2273,7 +1996,7 @@ static int ieee80211_ioctl_giwencode(str
}
memcpy(key, sdata->keys[idx]->conf.key,
- min((int)erq->length, sdata->keys[idx]->conf.keylen));
+ min_t(int, erq->length, sdata->keys[idx]->conf.keylen));
erq->length = sdata->keys[idx]->conf.keylen;
erq->flags |= IW_ENCODE_ENABLED;
@@ -2434,7 +2157,7 @@ static int ieee80211_ioctl_siwencodeext(
return ieee80211_set_encryption(dev, ext->addr.sa_data, idx, alg,
ext->ext_flags &
IW_ENCODE_EXT_SET_TX_KEY,
- NULL, ext->key, ext->key_len);
+ ext->key, ext->key_len);
}
--- wireless-dev.orig/net/mac80211/ieee80211_key.h 2007-08-21 16:25:44.625923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_key.h 2007-08-21 16:26:46.375923881 +0200
@@ -11,7 +11,7 @@
#define IEEE80211_KEY_H
#include <linux/types.h>
-#include <linux/kref.h>
+#include <linux/list.h>
#include <linux/crypto.h>
#include <net/mac80211.h>
@@ -41,8 +41,20 @@
#define NUM_RX_DATA_QUEUES 17
+struct ieee80211_local;
+struct ieee80211_sub_if_data;
+struct sta_info;
+
+#define KEY_FLAG_UPLOADED_TO_HARDWARE (1<<0)
+
struct ieee80211_key {
- struct kref kref;
+ struct ieee80211_local *local;
+ struct ieee80211_sub_if_data *sdata;
+ struct sta_info *sta;
+
+ struct list_head list;
+
+ unsigned int flags;
union {
struct {
@@ -99,4 +111,16 @@ struct ieee80211_key {
struct ieee80211_key_conf conf;
};
+struct ieee80211_key *ieee80211_key_alloc(struct ieee80211_sub_if_data *sdata,
+ struct sta_info *sta,
+ ieee80211_key_alg alg,
+ int idx,
+ size_t key_len,
+ const u8 *key_data);
+void ieee80211_key_free(struct ieee80211_key *key);
+void ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata, int idx);
+void ieee80211_free_keys(struct ieee80211_sub_if_data *sdata);
+void ieee80211_enable_keys(struct ieee80211_sub_if_data *sdata);
+void ieee80211_disable_keys(struct ieee80211_sub_if_data *sdata);
+
#endif /* IEEE80211_KEY_H */
--- wireless-dev.orig/net/mac80211/key.c 2007-08-21 16:25:44.635923881 +0200
+++ wireless-dev/net/mac80211/key.c 2007-08-21 16:26:46.375923881 +0200
@@ -2,42 +2,305 @@
* Copyright 2002-2005, Instant802 Networks, Inc.
* Copyright 2005-2006, Devicescape Software, Inc.
* Copyright 2006-2007 Jiri Benc <jbenc@suse.cz>
+ * Copyright 2007 Johannes Berg <johannes@sipsolutions.net>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/
+#include <linux/if_ether.h>
+#include <linux/etherdevice.h>
+#include <linux/list.h>
#include <net/mac80211.h>
#include "ieee80211_i.h"
#include "debugfs_key.h"
#include "aes_ccm.h"
+
+/*
+ * Key handling basics
+ *
+ * Key handling in mac80211 is done based on per-interface (sub_if_data)
+ * keys and per-station keys. Since each station belongs to an interface,
+ * each station key also belongs to that interface.
+ *
+ * Hardware acceleration is done on a best-effort basis, for each key
+ * that is eligible the hardware is asked to enable that key but if
+ * it cannot do that they key is simply kept for software encryption.
+ * There is currently no way of knowing this except by looking into
+ * debugfs.
+ */
+
+static const u8 bcast_addr[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
+static const u8 zero_addr[ETH_ALEN];
+
+static const u8 *get_mac_for_key(struct ieee80211_key *key)
+{
+ const u8 *addr = bcast_addr;
+
+ /*
+ * If we're an AP we won't ever receive frames with a non-WEP
+ * group key so we tell the driver that by using the zero MAC
+ * address to indicate a transmit-only key.
+ */
+ if (key->conf.alg != ALG_WEP &&
+ (key->sdata->type == IEEE80211_IF_TYPE_AP ||
+ key->sdata->type == IEEE80211_IF_TYPE_VLAN))
+ addr = zero_addr;
+
+ if (key->sta)
+ addr = key->sta->addr;
+
+ return addr;
+}
+
+static void ieee80211_key_enable_hw_accel(struct ieee80211_key *key)
+{
+ const u8 *addr;
+ int ret;
+
+ if (!key->local->ops->set_key)
+ return;
+
+ addr = get_mac_for_key(key);
+
+ ret = key->local->ops->set_key(local_to_hw(key->local), SET_KEY,
+ key->sdata->dev->dev_addr, addr,
+ &key->conf);
+
+ WARN_ON(!ret && (key->conf.hw_key_idx == HW_KEY_IDX_INVALID));
+
+ if (!ret)
+ key->flags |= KEY_FLAG_UPLOADED_TO_HARDWARE;
+
+ if (ret && ret != -ENOSPC && ret != -EOPNOTSUPP)
+ printk(KERN_ERR "mac80211-%s: failed to set key "
+ "(%d, " MAC_FMT ") to hardware (%d)\n",
+ wiphy_name(key->local->hw.wiphy),
+ key->conf.keyidx, MAC_ARG(addr), ret);
+}
+
+static void ieee80211_key_disable_hw_accel(struct ieee80211_key *key)
+{
+ const u8 *addr;
+ int ret;
+
+ if (!key->local->ops->set_key)
+ return;
+
+ if (!(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
+ return;
+
+ addr = get_mac_for_key(key);
+
+ ret = key->local->ops->set_key(local_to_hw(key->local), DISABLE_KEY,
+ key->sdata->dev->dev_addr, addr,
+ &key->conf);
+
+ if (ret)
+ printk(KERN_ERR "mac80211-%s: failed to remove key "
+ "(%d, " MAC_FMT ") from hardware (%d)\n",
+ wiphy_name(key->local->hw.wiphy),
+ key->conf.keyidx, MAC_ARG(addr), ret);
+
+ key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
+ key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
+}
+
+/*
+ * driver notifying us that it removed a key from hw accel,
+ * set the software key flag.
+ */
+void ieee80211_key_removed(struct ieee80211_key_conf *conf)
+{
+ struct ieee80211_key *key = container_of(conf, struct ieee80211_key,
+ conf);
+
+ WARN_ON(!conf);
+ if (!conf)
+ return;
+
+ key->flags &= ~KEY_FLAG_UPLOADED_TO_HARDWARE;
+ key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
+}
+
struct ieee80211_key *ieee80211_key_alloc(struct ieee80211_sub_if_data *sdata,
- int idx, size_t key_len, gfp_t flags)
+ struct sta_info *sta,
+ ieee80211_key_alg alg,
+ int idx,
+ size_t key_len,
+ const u8 *key_data)
{
struct ieee80211_key *key;
- key = kzalloc(sizeof(struct ieee80211_key) + key_len, flags);
+ BUG_ON(alg == ALG_NONE);
+
+ key = kzalloc(sizeof(struct ieee80211_key) + key_len, GFP_KERNEL);
if (!key)
return NULL;
- kref_init(&key->kref);
+
+ /*
+ * Default to software encryption; we'll later upload the
+ * key to the hardware if possible.
+ */
+ key->conf.hw_key_idx = HW_KEY_IDX_INVALID;
+ key->conf.flags = 0;
+ key->flags = 0;
+
+ key->conf.alg = alg;
+ key->conf.keyidx = idx;
+ key->conf.keylen = key_len;
+ memcpy(key->conf.key, key_data, key_len);
+
+ key->local = sdata->local;
+ key->sdata = sdata;
+ key->sta = sta;
+
+ if (alg == ALG_CCMP) {
+ /*
+ * Initialize AES key state here as an optimization so that
+ * it does not need to be initialized for every packet.
+ */
+ key->u.ccmp.tfm = ieee80211_aes_key_setup_encrypt(key_data);
+ if (!key->u.ccmp.tfm) {
+ ieee80211_key_free(key);
+ return NULL;
+ }
+ }
+
+ ieee80211_debugfs_key_add(key->local, key);
+
+ if (sta) {
+ ieee80211_debugfs_key_sta_link(key, sta);
+ sta->key = key;
+ /*
+ * some hardware cannot handle TKIP with QoS, so
+ * we indicate whether QoS could be in use.
+ */
+ if (sta->flags & WLAN_STA_WME)
+ key->conf.flags |= IEEE80211_KEY_FLAG_WMM_STA;
+ } else {
+ struct sta_info *ap;
+
+ /* same here, the AP could be using QoS */
+ ap = sta_info_get(key->local, key->sdata->u.sta.bssid);
+ if (ap) {
+ if (ap->flags & WLAN_STA_WME)
+ key->conf.flags |= IEEE80211_KEY_FLAG_WMM_STA;
+ sta_info_put(ap);
+ }
+
+ if (idx >= 0 && idx < NUM_DEFAULT_KEYS) {
+ if (!sdata->keys[idx])
+ sdata->keys[idx] = key;
+ else
+ WARN_ON(1);
+ } else
+ WARN_ON(1);
+ }
+
+ list_add(&key->list, &sdata->key_list);
+
+ if (netif_running(key->sdata->dev))
+ ieee80211_key_enable_hw_accel(key);
+
return key;
}
-static void ieee80211_key_release(struct kref *kref)
+static void __ieee80211_key_free(struct ieee80211_key *key)
{
- struct ieee80211_key *key;
+ if (!key)
+ return;
+
+ ieee80211_key_disable_hw_accel(key);
+
+ if (key->sta) {
+ key->sta->key = NULL;
+ } else {
+ if (key->sdata->default_key == key)
+ ieee80211_set_default_key(key->sdata, -1);
+ if (key->conf.keyidx >= 0 &&
+ key->conf.keyidx < NUM_DEFAULT_KEYS)
+ key->sdata->keys[key->conf.keyidx] = NULL;
+ else
+ WARN_ON(1);
+ }
- key = container_of(kref, struct ieee80211_key, kref);
if (key->conf.alg == ALG_CCMP)
ieee80211_aes_key_free(key->u.ccmp.tfm);
ieee80211_debugfs_key_remove(key);
+
+ list_del(&key->list);
+
kfree(key);
}
void ieee80211_key_free(struct ieee80211_key *key)
{
- if (key)
- kref_put(&key->kref, ieee80211_key_release);
+ struct ieee80211_sub_if_data *sdata;
+
+ if (!key)
+ return;
+
+ sdata = key->sdata;
+
+ mutex_lock(&sdata->key_mtx);
+ __ieee80211_key_free(key);
+ mutex_unlock(&sdata->key_mtx);
+}
+
+void ieee80211_set_default_key(struct ieee80211_sub_if_data *sdata, int idx)
+{
+ struct ieee80211_key *key = NULL;
+
+ if (idx >= 0 && idx < NUM_DEFAULT_KEYS)
+ key = sdata->keys[idx];
+
+ if (sdata->default_key != key) {
+ ieee80211_debugfs_key_remove_default(sdata);
+
+ sdata->default_key = key;
+
+ if (sdata->default_key)
+ ieee80211_debugfs_key_add_default(sdata);
+
+ if (sdata->local->ops->set_key_idx)
+ sdata->local->ops->set_key_idx(
+ local_to_hw(sdata->local), idx);
+ }
+}
+
+void ieee80211_free_keys(struct ieee80211_sub_if_data *sdata)
+{
+ struct ieee80211_key *key, *tmp;
+
+ mutex_lock(&sdata->key_mtx);
+ list_for_each_entry_safe(key, tmp, &sdata->key_list, list)
+ __ieee80211_key_free(key);
+ mutex_unlock(&sdata->key_mtx);
+}
+
+void ieee80211_enable_keys(struct ieee80211_sub_if_data *sdata)
+{
+ struct ieee80211_key *key;
+
+ WARN_ON(!netif_running(sdata->dev));
+ if (!netif_running(sdata->dev))
+ return;
+
+ mutex_lock(&sdata->key_mtx);
+ list_for_each_entry(key, &sdata->key_list, list)
+ ieee80211_key_enable_hw_accel(key);
+ mutex_unlock(&sdata->key_mtx);
+}
+
+void ieee80211_disable_keys(struct ieee80211_sub_if_data *sdata)
+{
+ struct ieee80211_key *key;
+
+ mutex_lock(&sdata->key_mtx);
+ list_for_each_entry(key, &sdata->key_list, list)
+ ieee80211_key_disable_hw_accel(key);
+ mutex_unlock(&sdata->key_mtx);
}
--- wireless-dev.orig/drivers/net/wireless/b43/main.c 2007-08-21 16:25:44.535923881 +0200
+++ wireless-dev/drivers/net/wireless/b43/main.c 2007-08-21 16:26:46.385923881 +0200
@@ -728,7 +728,6 @@ static void keymac_write(struct b43_wlde
u32 addrtmp[2];
B43_WARN_ON(index < 4 + 4);
- memcpy(dev->key[index].address, addr, 6);
/* We have two default TX keys and two default RX keys.
* Physical mac 0 is mapped to physical key 8.
* So we must adjust the index here.
@@ -807,9 +806,11 @@ static int b43_key_write(struct b43_wlde
else
sta_keys_start = 8;
for (i = sta_keys_start; i < dev->max_nr_keys; i++) {
- if (compare_ether_addr(dev->key[i].address, mac_addr) ==
- 0) {
- /* found existing */
+ if (dev->key[i].keyconf == keyconf) {
+ /*
+ * we already have this key so we must be
+ * in removal (there is no update)
+ */
index = i;
break;
}
@@ -825,7 +826,7 @@ static int b43_key_write(struct b43_wlde
}
if (index < 0) {
b43err(dev->wl, "Out of hardware key memory\n");
- return -ENOBUFS;
+ return -ENOSPC;
}
} else
B43_WARN_ON(index > 3);
@@ -2860,9 +2861,8 @@ static int b43_dev_config(struct ieee802
}
static int b43_dev_set_key(struct ieee80211_hw *hw,
- set_key_cmd cmd,
- u8 *addr, struct ieee80211_key_conf *key,
- int static_wep_only)
+ set_key_cmd cmd, const u8 *local_addr,
+ const u8 *addr, struct ieee80211_key_conf *key)
{
struct b43_wl *wl = hw_to_b43_wl(hw);
struct b43_wldev *dev = wl->current_dev;
@@ -2871,7 +2871,6 @@ static int b43_dev_set_key(struct ieee80
u8 index;
int err = -EINVAL;
- key->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
if (!dev)
return -ENODEV;
switch (key->alg) {
@@ -2909,11 +2908,10 @@ static int b43_dev_set_key(struct ieee80
switch (cmd) {
case SET_KEY:
- key->flags &= ~IEEE80211_KEY_FORCE_SW_ENCRYPT;
-
if (algorithm == B43_SEC_ALGO_TKIP) {
/* FIXME: No TKIP hardware encryption for now. */
- key->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
+ err = -EOPNOTSUPP;
+ goto out_unlock;
}
if (is_broadcast_ether_addr(addr)) {
@@ -2921,13 +2919,15 @@ static int b43_dev_set_key(struct ieee80
err = b43_key_write(dev, index, algorithm,
key->key, key->keylen, NULL, key);
} else {
+ /*
+ * either pairwise key or address is 00:00:00:00:00:00
+ * for transmit-only keys
+ */
err = b43_key_write(dev, -1, algorithm,
key->key, key->keylen, addr, key);
}
- if (err) {
- key->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
+ if (err)
goto out_unlock;
- }
dev->key[key->hw_key_idx].enabled = 1;
if (algorithm == B43_SEC_ALGO_WEP40 ||
@@ -2954,10 +2954,6 @@ static int b43_dev_set_key(struct ieee80
dev->key[key->hw_key_idx].enabled = 0;
break;
}
- case REMOVE_ALL_KEYS:
- b43_clear_keys(dev);
- err = 0;
- break;
default:
B43_WARN_ON(1);
}
@@ -2966,10 +2962,10 @@ out_unlock:
mutex_unlock(&wl->mutex);
out:
if (!err) {
- b43dbg(wl, "Using %s based encryption for keyidx: %d, "
+ b43dbg(wl, "%s hardware based encryption for keyidx: %d, "
"mac: " MAC_FMT "\n",
- (key->flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) ?
- "software" : "hardware", key->keyidx, MAC_ARG(addr));
+ cmd == SET_KEY ? "Using" : "Disabling", key->keyidx,
+ MAC_ARG(addr));
}
return err;
}
--- wireless-dev.orig/drivers/net/wireless/iwl-base.c 2007-08-21 16:25:44.615923881 +0200
+++ wireless-dev/drivers/net/wireless/iwl-base.c 2007-08-21 16:26:46.395923881 +0200
@@ -7863,8 +7863,9 @@ static int iwl_mac_hw_scan(struct ieee80
return rc;
}
-static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd, u8 *addr,
- struct ieee80211_key_conf *key, int static_wep_only)
+static int iwl_mac_set_key(struct ieee80211_hw *hw, set_key_cmd cmd,
+ const u8 *local_addr, const u8 *addr,
+ struct ieee80211_key_conf *key)
{
struct iwl_priv *priv = hw->priv;
int rc = 0;
@@ -7877,11 +7878,15 @@ static int iwl_mac_set_key(struct ieee80
return -EOPNOTSUPP;
}
+ if (is_zero_ether_addr(addr))
+ /* only support pairwise keys */
+ return -EOPNOTSUPP;
+
sta_id = iwl_hw_find_station(priv, addr);
if (sta_id == IWL_INVALID_STATION) {
IWL_DEBUG_MAC80211("leave - " MAC_FMT
" not in station map.\n", MAC_ARG(addr));
- return -EINVAL;
+ return -ENOSPC;
}
mutex_lock(&priv->mutex);
@@ -7894,8 +7899,6 @@ static int iwl_mac_set_key(struct ieee80
if (!rc) {
iwl_set_rxon_hwcrypto(priv, 1);
iwl_commit_rxon(priv);
- key->flags &= (u32)
- (~IEEE80211_KEY_FORCE_SW_ENCRYPT);
key->hw_key_idx = sta_id;
/* TODO do we need below */
/*
--- wireless-dev.orig/net/mac80211/sta_info.c 2007-08-21 16:25:44.575923881 +0200
+++ wireless-dev/net/mac80211/sta_info.c 2007-08-21 16:26:46.395923881 +0200
@@ -19,7 +19,6 @@
#include "ieee80211_i.h"
#include "ieee80211_rate.h"
#include "sta_info.h"
-#include "debugfs_key.h"
#include "debugfs_sta.h"
/* Caller must hold local->sta_lock */
@@ -144,8 +143,6 @@ static void sta_info_release(struct kref
}
rate_control_free_sta(sta->rate_ctrl, sta->rate_ctrl_priv);
rate_control_put(sta->rate_ctrl);
- if (sta->key)
- ieee80211_debugfs_key_sta_del(sta->key, sta);
kfree(sta);
}
@@ -191,7 +188,6 @@ struct sta_info * sta_info_add(struct ie
local->ops->sta_table_notification(local_to_hw(local),
local->num_sta);
write_unlock_bh(&local->sta_lock);
- sta->key_idx_compression = HW_KEY_IDX_INVALID;
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
printk(KERN_DEBUG "%s: Added STA " MAC_FMT "\n",
@@ -252,35 +248,13 @@ void sta_info_free(struct sta_info *sta)
dev_kfree_skb(skb);
}
- if (sta->key) {
- if (local->ops->set_key) {
- local->ops->set_key(local_to_hw(local),
- DISABLE_KEY, sta->addr,
- &sta->key->conf,
- local->default_wep_only);
- }
- } else if (sta->key_idx_compression != HW_KEY_IDX_INVALID) {
- struct ieee80211_key_conf conf;
- memset(&conf, 0, sizeof(conf));
- conf.hw_key_idx = sta->key_idx_compression;
- conf.alg = ALG_NONE;
- conf.flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
- local->ops->set_key(local_to_hw(local), DISABLE_KEY,
- sta->addr, &conf,
- local->default_wep_only);
- sta->key_idx_compression = HW_KEY_IDX_INVALID;
- }
-
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
printk(KERN_DEBUG "%s: Removed STA " MAC_FMT "\n",
local->mdev->name, MAC_ARG(sta->addr));
#endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
- if (sta->key) {
- ieee80211_debugfs_key_remove(sta->key);
- ieee80211_key_free(sta->key);
- sta->key = NULL;
- }
+ ieee80211_key_free(sta->key);
+ sta->key = NULL;
rate_control_remove_sta_debugfs(sta);
ieee80211_sta_debugfs_remove(sta);
--- wireless-dev.orig/net/mac80211/debugfs_sta.c 2007-08-21 16:21:39.585923881 +0200
+++ wireless-dev/net/mac80211/debugfs_sta.c 2007-08-21 16:26:46.395923881 +0200
@@ -60,7 +60,6 @@ static const struct file_operations sta_
STA_OPS(name)
STA_FILE(aid, aid, D);
-STA_FILE(key_idx_compression, key_idx_compression, D);
STA_FILE(dev, dev->name, S);
STA_FILE(vlan_id, vlan_id, D);
STA_FILE(rx_packets, rx_packets, LU);
--- wireless-dev.orig/net/mac80211/sta_info.h 2007-08-21 16:25:43.655923881 +0200
+++ wireless-dev/net/mac80211/sta_info.h 2007-08-21 16:26:46.395923881 +0200
@@ -91,10 +91,6 @@ struct sta_info {
int channel_use;
int channel_use_raw;
- int key_idx_compression; /* key table index for compression and TX
- * filtering; used only if sta->key is not
- * set */
-
unsigned int assoc_ap:1; /* whether this is an AP that we are
* associated with as a client */
unsigned int dls_sta:1; /* whether this stations is a DLS peer of us */
--- wireless-dev.orig/net/mac80211/tx.c 2007-08-21 16:25:44.685923881 +0200
+++ wireless-dev/net/mac80211/tx.c 2007-08-21 16:26:46.405923881 +0200
@@ -425,10 +425,7 @@ ieee80211_tx_h_ps_buf(struct ieee80211_t
static ieee80211_txrx_result
ieee80211_tx_h_select_key(struct ieee80211_txrx_data *tx)
{
- if (tx->sta)
- tx->u.tx.control->key_idx = tx->sta->key_idx_compression;
- else
- tx->u.tx.control->key_idx = HW_KEY_IDX_INVALID;
+ tx->u.tx.control->key_idx = HW_KEY_IDX_INVALID;
if (unlikely(tx->u.tx.control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT))
tx->key = NULL;
@@ -538,7 +535,7 @@ ieee80211_tx_h_fragment(struct ieee80211
static int wep_encrypt_skb(struct ieee80211_txrx_data *tx, struct sk_buff *skb)
{
- if (tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) {
+ if (!(tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)) {
if (ieee80211_wep_encrypt(tx->local, skb, tx->key))
return -1;
} else {
@@ -831,7 +828,7 @@ __ieee80211_parse_tx_radiotap(
*/
control->retry_limit = 1; /* no retry */
- control->key_idx = -1; /* no encryption key */
+ control->key_idx = HW_KEY_IDX_INVALID;
control->flags &= ~(IEEE80211_TXCTL_USE_RTS_CTS |
IEEE80211_TXCTL_USE_CTS_PROTECT);
control->flags |= IEEE80211_TXCTL_DO_NOT_ENCRYPT |
--- wireless-dev.orig/net/mac80211/ieee80211_iface.c 2007-08-21 16:25:44.705923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_iface.c 2007-08-21 16:26:46.405923881 +0200
@@ -25,6 +25,9 @@ void ieee80211_if_sdata_init(struct ieee
sdata->eapol = 1;
for (i = 0; i < IEEE80211_FRAGMENT_MAX; i++)
skb_queue_head_init(&sdata->fragments[i].skb_list);
+
+ mutex_init(&sdata->key_mtx);
+ INIT_LIST_HEAD(&sdata->key_list);
}
static void ieee80211_if_sdata_deinit(struct ieee80211_sub_if_data *sdata)
@@ -88,8 +91,6 @@ int ieee80211_if_add(struct net_device *
*new_dev = ndev;
write_unlock_bh(&local->sub_if_lock);
- ieee80211_update_default_wep_only(local);
-
return 0;
fail:
@@ -154,7 +155,6 @@ void ieee80211_if_del_mgmt(struct ieee80
void ieee80211_if_set_type(struct net_device *dev, int type)
{
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
- struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
int oldtype = sdata->type;
dev->hard_start_xmit = ieee80211_subif_start_xmit;
@@ -222,7 +222,6 @@ void ieee80211_if_set_type(struct net_de
dev->name, __FUNCTION__, type);
}
ieee80211_debugfs_change_if_type(sdata, oldtype);
- ieee80211_update_default_wep_only(local);
}
/* Must be called with rtnl lock held. */
@@ -234,21 +233,14 @@ void ieee80211_if_reinit(struct net_devi
int i;
ASSERT_RTNL();
+
+ ieee80211_free_keys(sdata);
+
ieee80211_if_sdata_deinit(sdata);
+
for (i = 0; i < NUM_DEFAULT_KEYS; i++) {
- if (!sdata->keys[i])
- continue;
-#if 0
- /* The interface is down at the moment, so there is not
- * really much point in disabling the keys at this point. */
- memset(addr, 0xff, ETH_ALEN);
- if (local->ops->set_key)
- local->ops->set_key(local_to_hw(local), DISABLE_KEY, addr,
- local->keys[i],
- local->default_wep_only);
-#endif
ieee80211_key_free(sdata->keys[i]);
- sdata->keys[i] = NULL;
+ WARN_ON(sdata->keys[i]);
}
switch (sdata->type) {
@@ -353,7 +345,6 @@ int ieee80211_if_remove(struct net_devic
list_del(&sdata->list);
write_unlock_bh(&local->sub_if_lock);
__ieee80211_if_del(local, sdata);
- ieee80211_update_default_wep_only(local);
return 0;
}
}
--- wireless-dev.orig/include/net/mac80211.h 2007-08-21 16:25:44.535923881 +0200
+++ wireless-dev/include/net/mac80211.h 2007-08-21 16:26:46.405923881 +0200
@@ -399,19 +399,40 @@ typedef enum {
ALG_CCMP,
} ieee80211_key_alg;
+/*
+ * This flag indiciates that the station this key is being
+ * configured for may use QoS. If your hardware cannot handle
+ * that situation it should reject that key.
+ */
+#define IEEE80211_KEY_FLAG_WMM_STA (1<<0)
+
struct ieee80211_key_conf {
- /* shall be changed by the driver to anything but HW_KEY_IDX_INVALID */
+ /*
+ * To be set by the driver to the key index it would like to
+ * get in the ieee80211_tx_control.key_idx which defaults
+ * to HW_KEY_IDX_INVALID so that shouldn't be used.
+ */
int hw_key_idx;
+ /* key algorithm, ALG_NONE should never be seen by the driver */
ieee80211_key_alg alg;
- int keylen;
+ /*
+ * for use by the driver, named this way to avoid
+ * accidental use in the stack
+ */
+ struct list_head driver_keylist;
+
+ /* key flags, see above */
+ u8 flags;
+
+ /* key index: 0-3 */
+ s8 keyidx;
-#define IEEE80211_KEY_FORCE_SW_ENCRYPT (1<<0) /* to be cleared by low-level
- driver */
- u32 flags; /* key configuration flags defined above */
+ /* length of key material */
+ u8 keylen;
- s8 keyidx; /* WEP key index */
+ /* the key material */
u8 key[0];
};
@@ -419,7 +440,7 @@ struct ieee80211_key_conf {
#define IEEE80211_SEQ_COUNTER_TX 1
typedef enum {
- SET_KEY, DISABLE_KEY, REMOVE_ALL_KEYS,
+ SET_KEY, DISABLE_KEY,
} set_key_cmd;
/* This is driver-visible part of the per-hw state the stack keeps. */
@@ -492,8 +513,7 @@ struct ieee80211_hw {
/* hole at 6 */
- /* Force software encryption for TKIP packets if WMM is enabled. */
-#define IEEE80211_HW_NO_TKIP_WMM_HWACCEL (1<<7)
+/* hole at 7 */
/*
* Some devices handle Michael MIC internally and do not include MIC in
@@ -630,13 +650,43 @@ struct ieee80211_ops {
*
* This is called to enable hardware acceleration of encryption and
* decryption. The address will be the broadcast address for default
- * keys and the other station's hardware address for individual keys.
+ * keys, the other station's hardware address for individual keys or
+ * the zero address for keys that will be used only for transmission.
+ *
+ * The local_address parameter will always be set to our own address,
+ * this is only relevant if you support multiple local addresses.
+ *
* When transmitting, the TX control data will use the hw_key_idx
* selected by the low-level driver.
+ *
+ * If you support multiple MAC addresses but only hardware acceleration
+ * based on the transmitter address, you should keep a list of all
+ * keys that are currently enabled (use the key conf's driver_keylist
+ * member) and call ieee80211_key_removed() for all keys that you had
+ * to remove.
+ * Note that you should only do that if you're unable to use the key
+ * for transmission afterwards, if you only disabled it for reception
+ * you should not call ieee80211_key_removed() because that will also
+ * remove the key for transmission.
+ *
+ * Return 0 if the key is now in use, -EOPNOTSUPP or -ENOSPC if it
+ * couldn't be added; if you return 0 then hw_key_idx must be
+ * assigned to something other than HW_KEY_IDX_INVALID. When the cmd
+ * is DISABLE_KEY then it must succeed.
+ *
+ * This callback can sleep, and is only called between add_interface
+ * and remove_interface calls, i.e. while the interface with the
+ * given local_address is enabled.
+ *
+ * The ieee80211_key_conf structure pointed to by the key parameter
+ * is guaranteed to be valid until another call to set_key removes
+ * it or until the driver calls ieee80211_key_removed(), it can
+ * especially be used as a cookie to differentiate transmit-only keys
+ * since multiple such keys may be present.
*/
int (*set_key)(struct ieee80211_hw *hw, set_key_cmd cmd,
- u8 *address, struct ieee80211_key_conf *key,
- int static_wep_only);
+ const u8 *local_address, const u8 *address,
+ struct ieee80211_key_conf *key);
/*
* Set TX key index for default/broadcast keys. This is needed in cases
@@ -644,6 +694,10 @@ struct ieee80211_ops {
* is not set), in other cases, this function pointer can be set to
* NULL since the IEEE 802.11 module takes care of selecting the key
* index for each TX frame.
+ *
+ * TODO: If you use this callback in your driver tell us if you need
+ * any other information from it to make it easier, like the
+ * key_conf instead.
*/
int (*set_key_idx)(struct ieee80211_hw *hw, int idx);
@@ -1037,6 +1091,19 @@ ieee80211_get_mc_list_item(struct ieee80
struct dev_mc_list *prev,
void **ptr);
+/**
+ * ieee80211_key_removed - the driver removed a key from hardware accel
+ *
+ * @keyconf: The key config structure for the key that was removed.
+ *
+ * Call this function if for some reason you had to remove a key
+ * from the hardware acceleration completely.
+ * Note that after calling this function you will not get a
+ * DISABLE_KEY notification via set_key() any more for this key,
+ * it is assumed that you've removed it already.
+ */
+void ieee80211_key_removed(struct ieee80211_key_conf *keyconf);
+
/* called by driver to notify scan status completed */
void ieee80211_scan_completed(struct ieee80211_hw *hw);
--- wireless-dev.orig/net/mac80211/ieee80211.c 2007-08-21 16:25:44.615923881 +0200
+++ wireless-dev/net/mac80211/ieee80211.c 2007-08-21 16:26:46.415923881 +0200
@@ -442,6 +442,7 @@ static int ieee80211_open(struct net_dev
} else {
ieee80211_if_config(dev);
ieee80211_reset_erp_info(dev);
+ ieee80211_enable_keys(sdata);
}
if (sdata->type == IEEE80211_IF_TYPE_STA &&
@@ -511,6 +512,9 @@ static int ieee80211_stop(struct net_dev
local->monitors--;
if (!local->monitors)
local->hw.conf.flags &= ~IEEE80211_CONF_RADIOTAP;
+ } else {
+ /* disable all keys for as long as this netdev is down */
+ ieee80211_disable_keys(sdata);
}
local->open_count--;
@@ -907,7 +911,7 @@ static void ieee80211_remove_tx_extra(st
}
if (skb->len >= mic_len &&
- (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT))
+ !(key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
skb_trim(skb, skb->len - mic_len);
if (skb->len >= iv_len && skb->len > hdrlen) {
memmove(skb->data + iv_len, skb->data, hdrlen);
--- wireless-dev.orig/net/mac80211/rx.c 2007-08-21 16:25:44.685923881 +0200
+++ wireless-dev/net/mac80211/rx.c 2007-08-21 16:26:46.415923881 +0200
@@ -537,7 +537,7 @@ ieee80211_rx_h_wep_weak_iv_detection(str
/* Check for weak IVs, if hwaccel did not remove IV from the frame */
if ((rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) ||
- (rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT))
+ !(rx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE))
if (ieee80211_wep_is_weak_iv(rx->skb, rx->key))
rx->sta->wep_weak_iv_count++;
@@ -562,7 +562,7 @@ ieee80211_rx_h_wep_decrypt(struct ieee80
}
if (!(rx->u.rx.status->flag & RX_FLAG_DECRYPTED) ||
- (rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
+ !(rx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)) {
if (ieee80211_wep_decrypt(rx->local, rx->skb, rx->key)) {
if (net_ratelimit())
printk(KERN_DEBUG "%s: RX WEP frame, decrypt "
@@ -905,8 +905,7 @@ ieee80211_rx_h_drop_unencrypted(struct i
* uploaded to the hardware.
*/
if ((rx->local->hw.flags & IEEE80211_HW_DEVICE_HIDES_WEP) &&
- (!rx->key ||
- !(rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)))
+ (!rx->key || (rx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)))
return TXRX_CONTINUE;
/* Drop unencrypted frames if key is set. */
--- wireless-dev.orig/net/mac80211/wpa.c 2007-08-21 16:25:44.705923881 +0200
+++ wireless-dev/net/mac80211/wpa.c 2007-08-21 16:26:46.415923881 +0200
@@ -101,7 +101,7 @@ ieee80211_tx_h_michael_mic_add(struct ie
}
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
+ if ((tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) &&
!tx->fragmented &&
!(tx->local->hw.flags & IEEE80211_HW_TKIP_INCLUDE_MMIC) &&
!wpa_test) {
@@ -184,7 +184,7 @@ ieee80211_rx_h_michael_mic_verify(struct
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !(rx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
+ (rx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)) {
if (rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) {
if (skb->len < MICHAEL_MIC_LEN)
return TXRX_DROP;
@@ -270,10 +270,10 @@ static int tkip_encrypt_skb(struct ieee8
hdrlen = ieee80211_get_hdrlen(fc);
len = skb->len - hdrlen;
- if (tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
- tailneed = TKIP_ICV_LEN;
- else
+ if (tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)
tailneed = 0;
+ else
+ tailneed = TKIP_ICV_LEN;
if ((skb_headroom(skb) < TKIP_IV_LEN ||
skb_tailroom(skb) < tailneed)) {
@@ -306,7 +306,7 @@ iv_inc:
skip_iv_inc:
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
+ if ((tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)
#ifdef CONFIG_HOSTAPD_WPA_TESTING
&& !tx->wpa_test
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
@@ -400,7 +400,7 @@ ieee80211_tx_h_tkip_encrypt(struct ieee8
}
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
- if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
+ if ((tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) &&
!(tx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV) &&
!wpa_test) {
/* hwaccel - with no need for preallocated room for IV/ICV */
@@ -479,7 +479,7 @@ ieee80211_rx_h_tkip_decrypt(struct ieee8
#endif /* CONFIG_HOSTAPD_WPA_TESTING */
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
+ (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)) {
if (!(rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV)) {
/* Hardware takes care of all processing, including
* replay protection, so no need to continue here. */
@@ -623,10 +623,10 @@ static int ccmp_encrypt_skb(struct ieee8
hdrlen = ieee80211_get_hdrlen(fc);
len = skb->len - hdrlen;
- if (key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)
- tailneed = CCMP_MIC_LEN;
- else
+ if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)
tailneed = 0;
+ else
+ tailneed = CCMP_MIC_LEN;
if ((skb_headroom(skb) < CCMP_HDR_LEN ||
skb_tailroom(skb) < tailneed)) {
@@ -666,7 +666,7 @@ skip_pn_inc:
ccmp_pn2hdr(pos, pn, key->conf.keyidx);
- if (!(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
+ if (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) {
/* hwaccel - with preallocated room for CCMP header */
tx->u.tx.control->key_idx = key->conf.hw_key_idx;
return 0;
@@ -720,7 +720,7 @@ ieee80211_tx_h_ccmp_encrypt(struct ieee8
tx->u.tx.control->iv_len = CCMP_HDR_LEN;
ieee80211_tx_set_iswep(tx);
- if (!(tx->key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
+ if ((tx->key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) &&
!(tx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV)) {
/* hwaccel - with no need for preallocated room for CCMP "
* header or MIC fields */
@@ -772,7 +772,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee8
return TXRX_DROP;
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT) &&
+ (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE) &&
!(rx->local->hw.flags & IEEE80211_HW_WEP_INCLUDE_IV))
return TXRX_CONTINUE;
@@ -793,7 +793,7 @@ ieee80211_rx_h_ccmp_decrypt(struct ieee8
}
if ((rx->u.rx.status->flag & RX_FLAG_DECRYPTED) &&
- !(key->conf.flags & IEEE80211_KEY_FORCE_SW_ENCRYPT)) {
+ (key->flags & KEY_FLAG_UPLOADED_TO_HARDWARE)) {
/* hwaccel has already decrypted frame and verified MIC */
} else {
u8 *scratch, *b_0, *aad;
--- wireless-dev.orig/net/mac80211/debugfs_key.c 2007-08-21 16:25:44.615923881 +0200
+++ wireless-dev/net/mac80211/debugfs_key.c 2007-08-21 16:26:46.415923881 +0200
@@ -25,6 +25,7 @@ static ssize_t key_##name##_read(struct
return simple_read_from_buffer(userbuf, count, ppos, buf, res); \
}
#define KEY_READ_D(name) KEY_READ(name, name, 20, "%d\n")
+#define KEY_READ_X(name) KEY_READ(name, name, 20, "0x%x\n")
#define KEY_OPS(name) \
static const struct file_operations key_ ##name## _ops = { \
@@ -39,7 +40,6 @@ static const struct file_operations key_
#define KEY_CONF_READ(name, buflen, format_string) \
KEY_READ(conf_##name, conf.name, buflen, format_string)
#define KEY_CONF_READ_D(name) KEY_CONF_READ(name, 20, "%d\n")
-#define KEY_CONF_READ_X(name) KEY_CONF_READ(name, 20, "0x%x\n")
#define KEY_CONF_OPS(name) \
static const struct file_operations key_ ##name## _ops = { \
@@ -54,7 +54,7 @@ static const struct file_operations key_
KEY_CONF_FILE(keylen, D);
KEY_CONF_FILE(keyidx, D);
KEY_CONF_FILE(hw_key_idx, D);
-KEY_CONF_FILE(flags, X);
+KEY_FILE(flags, X);
KEY_FILE(tx_rx_count, D);
static ssize_t key_algorithm_read(struct file *file,
--- wireless-dev.orig/net/mac80211/hostapd_ioctl.h 2007-08-21 16:25:44.215923881 +0200
+++ wireless-dev/net/mac80211/hostapd_ioctl.h 2007-08-21 16:26:46.415923881 +0200
@@ -177,12 +177,6 @@ struct prism2_hostapd_param {
#define HOSTAP_CRYPT_FLAG_SET_TX_KEY BIT(0)
#define HOSTAP_CRYPT_FLAG_PERMANENT BIT(1)
-#define HOSTAP_CRYPT_ERR_UNKNOWN_ALG 2
-#define HOSTAP_CRYPT_ERR_UNKNOWN_ADDR 3
-#define HOSTAP_CRYPT_ERR_CRYPT_INIT_FAILED 4
-#define HOSTAP_CRYPT_ERR_KEY_SET_FAILED 5
-#define HOSTAP_CRYPT_ERR_TX_KEY_SET_FAILED 6
-#define HOSTAP_CRYPT_ERR_CARD_CONF_FAILED 7
/* Data structures used for get_hw_features ioctl */
struct hostapd_ioctl_hw_modes_hdr {
--- wireless-dev.orig/drivers/net/wireless/adm8211.c 2007-08-21 16:25:25.145923881 +0200
+++ wireless-dev/drivers/net/wireless/adm8211.c 2007-08-21 16:26:46.425923881 +0200
@@ -1953,7 +1953,7 @@ static int __devinit adm8211_probe(struc
SET_IEEE80211_PERM_ADDR(dev, perm_addr);
dev->extra_tx_headroom = sizeof(struct adm8211_tx_hdr);
- dev->flags = IEEE80211_HW_WEP_INCLUDE_IV | IEEE80211_HW_NO_TKIP_WMM_HWACCEL;
+ dev->flags = IEEE80211_HW_WEP_INCLUDE_IV;
// however, IEEE80211_HW_RX_INCLUDES_FCS in promisc mode
dev->channel_change_time = 1000;
--- wireless-dev.orig/drivers/net/wireless/rt2x00/rt2400pci.c 2007-08-21 16:25:42.595923881 +0200
+++ wireless-dev/drivers/net/wireless/rt2x00/rt2400pci.c 2007-08-21 16:26:46.425923881 +0200
@@ -1449,7 +1449,6 @@ static void rt2400pci_probe_hw_mode(stru
*/
rt2x00dev->hw->flags =
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
- IEEE80211_HW_NO_TKIP_WMM_HWACCEL |
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_NO_PROBE_FILTERING;
rt2x00dev->hw->extra_tx_headroom = 0;
--- wireless-dev.orig/drivers/net/wireless/rt2x00/rt2500pci.c 2007-08-21 16:25:42.595923881 +0200
+++ wireless-dev/drivers/net/wireless/rt2x00/rt2500pci.c 2007-08-21 16:26:46.425923881 +0200
@@ -1747,7 +1747,6 @@ static void rt2500pci_probe_hw_mode(stru
*/
rt2x00dev->hw->flags =
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
- IEEE80211_HW_NO_TKIP_WMM_HWACCEL |
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_NO_PROBE_FILTERING;
rt2x00dev->hw->extra_tx_headroom = 0;
--- wireless-dev.orig/drivers/net/wireless/rt2x00/rt2500usb.c 2007-08-21 16:25:42.625923881 +0200
+++ wireless-dev/drivers/net/wireless/rt2x00/rt2500usb.c 2007-08-21 16:26:46.435923881 +0200
@@ -1468,7 +1468,6 @@ static void rt2500usb_probe_hw_mode(stru
IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
IEEE80211_HW_RX_INCLUDES_FCS |
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
- IEEE80211_HW_NO_TKIP_WMM_HWACCEL |
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_NO_PROBE_FILTERING;
rt2x00dev->hw->extra_tx_headroom = TXD_DESC_SIZE;
--- wireless-dev.orig/drivers/net/wireless/rt2x00/rt61pci.c 2007-08-21 16:25:42.625923881 +0200
+++ wireless-dev/drivers/net/wireless/rt2x00/rt61pci.c 2007-08-21 16:26:46.435923881 +0200
@@ -2120,7 +2120,6 @@ static void rt61pci_probe_hw_mode(struct
*/
rt2x00dev->hw->flags =
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
- IEEE80211_HW_NO_TKIP_WMM_HWACCEL |
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_NO_PROBE_FILTERING;
rt2x00dev->hw->extra_tx_headroom = 0;
--- wireless-dev.orig/drivers/net/wireless/rt2x00/rt73usb.c 2007-08-21 16:25:42.655923881 +0200
+++ wireless-dev/drivers/net/wireless/rt2x00/rt73usb.c 2007-08-21 16:26:46.435923881 +0200
@@ -1714,7 +1714,6 @@ static void rt73usb_probe_hw_mode(struct
rt2x00dev->hw->flags =
IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
- IEEE80211_HW_NO_TKIP_WMM_HWACCEL |
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_NO_PROBE_FILTERING;
rt2x00dev->hw->extra_tx_headroom = TXD_DESC_SIZE;
--- wireless-dev.orig/drivers/net/wireless/b43/b43.h 2007-08-21 16:21:39.965923881 +0200
+++ wireless-dev/drivers/net/wireless/b43/b43.h 2007-08-21 16:26:46.435923881 +0200
@@ -571,9 +571,9 @@ struct b43_stats {
};
struct b43_key {
+ void *keyconf;
bool enabled;
u8 algorithm;
- u8 address[6];
};
struct b43_wldev;
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] mac80211: add interface index to key debugfs
2007-08-21 15:57 [PATCH 0/3] improve mac80211 key handling Johannes Berg
2007-08-21 15:57 ` [PATCH 1/3] mac80211: embed key conf in key, fix driver interface Johannes Berg
2007-08-21 15:57 ` [PATCH 2/3] mac80211: revamp key handling Johannes Berg
@ 2007-08-21 15:57 ` Johannes Berg
2 siblings, 0 replies; 7+ messages in thread
From: Johannes Berg @ 2007-08-21 15:57 UTC (permalink / raw)
To: John Linville; +Cc: Jiri Benc, Michael Wu, linux-wireless
Add a new file 'ifindex' to each key's debugfs dir to
allow finding which interface the key was configured on.
This isn't done as a symlink because of possible netdev
name changes.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/debugfs_key.c | 4 ++++
net/mac80211/ieee80211_key.h | 1 +
2 files changed, 5 insertions(+)
--- wireless-dev.orig/net/mac80211/debugfs_key.c 2007-08-21 16:26:46.415923881 +0200
+++ wireless-dev/net/mac80211/debugfs_key.c 2007-08-21 16:27:34.505923881 +0200
@@ -56,6 +56,8 @@ KEY_CONF_FILE(keyidx, D);
KEY_CONF_FILE(hw_key_idx, D);
KEY_FILE(flags, X);
KEY_FILE(tx_rx_count, D);
+KEY_READ(ifindex, sdata->dev->ifindex, 20, "%d\n");
+KEY_OPS(ifindex);
static ssize_t key_algorithm_read(struct file *file,
char __user *userbuf,
@@ -209,6 +211,7 @@ void ieee80211_debugfs_key_add(struct ie
DEBUGFS_ADD(rx_spec);
DEBUGFS_ADD(replays);
DEBUGFS_ADD(key);
+ DEBUGFS_ADD(ifindex);
};
#define DEBUGFS_DEL(name) \
@@ -229,6 +232,7 @@ void ieee80211_debugfs_key_remove(struct
DEBUGFS_DEL(rx_spec);
DEBUGFS_DEL(replays);
DEBUGFS_DEL(key);
+ DEBUGFS_DEL(ifindex);
debugfs_remove(key->debugfs.stalink);
key->debugfs.stalink = NULL;
--- wireless-dev.orig/net/mac80211/ieee80211_key.h 2007-08-21 16:26:46.375923881 +0200
+++ wireless-dev/net/mac80211/ieee80211_key.h 2007-08-21 16:27:34.505923881 +0200
@@ -101,6 +101,7 @@ struct ieee80211_key {
struct dentry *rx_spec;
struct dentry *replays;
struct dentry *key;
+ struct dentry *ifindex;
} debugfs;
#endif
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] mac80211: revamp key handling
2007-08-21 15:57 ` [PATCH 2/3] mac80211: revamp key handling Johannes Berg
@ 2007-08-30 23:45 ` Johannes Berg
2007-08-31 13:03 ` Michael Buesch
0 siblings, 1 reply; 7+ messages in thread
From: Johannes Berg @ 2007-08-30 23:45 UTC (permalink / raw)
To: John Linville; +Cc: Jiri Benc, Michael Wu, linux-wireless, Michael Buesch
Huh, this turned out to be buggy in b43:
> @@ -2921,13 +2919,15 @@ static int b43_dev_set_key(struct ieee80
> err = b43_key_write(dev, index, algorithm,
> key->key, key->keylen, NULL, key);
> } else {
> + /*
> + * either pairwise key or address is 00:00:00:00:00:00
> + * for transmit-only keys
> + */
> err = b43_key_write(dev, -1, algorithm,
> key->key, key->keylen, addr, key);
> }
> - if (err) {
> - key->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
> + if (err)
> goto out_unlock;
> - }
> dev->key[key->hw_key_idx].enabled = 1;
>
> if (algorithm == B43_SEC_ALGO_WEP40 ||
The same obviously has to be done when deleting keys. Michael, you can
either use the patch below or rework it to use the hw_key_idx to delete
the key.
Interestingly, this way I found out that when the B43_RX_MAC_DECERR flag
is set on a frame, then the hardware has decrypted the data with the
wrong key and then found that the ICV isn't correct so that the data is
completely mangled. Hence, you should simply drop the frame in that case
instead of passing it up, mac80211 will simply again attempt to decrypt
it and, since the frame is already decrypted with the wrong key, only
get garbage. This could even be used to DoS a machine with little
resources like an AP: simply send a lot of broken frames that mac80211
will try to decrypt in software.
johannes
--- wireless-dev.orig/drivers/net/wireless/b43/main.c 2007-08-31 01:28:18.532792130 +0200
+++ wireless-dev/drivers/net/wireless/b43/main.c 2007-08-31 01:31:01.502792130 +0200
@@ -2939,9 +2939,18 @@ static int b43_dev_set_key(struct ieee80
static const u8 zero[B43_SEC_KEYSIZE] = { 0 };
algorithm = B43_SEC_ALGO_NONE;
- err = b43_key_write(dev, index, algorithm,
- zero, B43_SEC_KEYSIZE,
- NULL, key);
+ if (is_broadcast_ether_addr(addr)) {
+ /* addr is FF:FF:FF:FF:FF:FF for default keys */
+ err = b43_key_write(dev, index, algorithm,
+ zero, B43_SEC_KEYSIZE, NULL, key);
+ } else {
+ /*
+ * either pairwise key or address is 00:00:00:00:00:00
+ * for transmit-only keys
+ */
+ err = b43_key_write(dev, -1, algorithm,
+ zero, B43_SEC_KEYSIZE, addr, key);
+ }
if (err)
goto out_unlock;
break;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] mac80211: revamp key handling
2007-08-30 23:45 ` Johannes Berg
@ 2007-08-31 13:03 ` Michael Buesch
2007-08-31 23:40 ` Johannes Berg
0 siblings, 1 reply; 7+ messages in thread
From: Michael Buesch @ 2007-08-31 13:03 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, Jiri Benc, Michael Wu, linux-wireless
On Friday 31 August 2007, Johannes Berg wrote:
> Huh, this turned out to be buggy in b43:
>
> > @@ -2921,13 +2919,15 @@ static int b43_dev_set_key(struct ieee80
> > err = b43_key_write(dev, index, algorithm,
> > key->key, key->keylen, NULL, key);
> > } else {
> > + /*
> > + * either pairwise key or address is 00:00:00:00:00:00
> > + * for transmit-only keys
> > + */
> > err = b43_key_write(dev, -1, algorithm,
> > key->key, key->keylen, addr, key);
> > }
> > - if (err) {
> > - key->flags |= IEEE80211_KEY_FORCE_SW_ENCRYPT;
> > + if (err)
> > goto out_unlock;
> > - }
> > dev->key[key->hw_key_idx].enabled = 1;
> >
> > if (algorithm == B43_SEC_ALGO_WEP40 ||
>
> The same obviously has to be done when deleting keys. Michael, you can
> either use the patch below or rework it to use the hw_key_idx to delete
> the key.
>
> Interestingly, this way I found out that when the B43_RX_MAC_DECERR flag
> is set on a frame, then the hardware has decrypted the data with the
> wrong key and then found that the ICV isn't correct so that the data is
> completely mangled. Hence, you should simply drop the frame in that case
> instead of passing it up, mac80211 will simply again attempt to decrypt
> it and, since the frame is already decrypted with the wrong key, only
> get garbage. This could even be used to DoS a machine with little
> resources like an AP: simply send a lot of broken frames that mac80211
> will try to decrypt in software.
I am sorry. I introduced this as I didn't understand my own weird code anymore. :)
I think I'll fix this by using the hw_key_idx.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] mac80211: revamp key handling
2007-08-31 13:03 ` Michael Buesch
@ 2007-08-31 23:40 ` Johannes Berg
0 siblings, 0 replies; 7+ messages in thread
From: Johannes Berg @ 2007-08-31 23:40 UTC (permalink / raw)
To: Michael Buesch; +Cc: John Linville, Jiri Benc, Michael Wu, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Fri, 2007-08-31 at 15:03 +0200, Michael Buesch wrote:
> I am sorry. I introduced this as I didn't understand my own weird code anymore. :)
> I think I'll fix this by using the hw_key_idx.
Well, I made it buggy :)
I noticed another thing: The code there sets the "default keys valid"
bit depending on WEP or not, while the v3 specs may say that it's a
weird thing to do. I suggest setting the "default keys valid" bit in STA
mode when group keys are configured and clearing it in AP mode; that
way, in AP mode, the four group key slots can also be used for the
transmit-only keys that have zeroed MAC addresses.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-08-31 23:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-21 15:57 [PATCH 0/3] improve mac80211 key handling Johannes Berg
2007-08-21 15:57 ` [PATCH 1/3] mac80211: embed key conf in key, fix driver interface Johannes Berg
2007-08-21 15:57 ` [PATCH 2/3] mac80211: revamp key handling Johannes Berg
2007-08-30 23:45 ` Johannes Berg
2007-08-31 13:03 ` Michael Buesch
2007-08-31 23:40 ` Johannes Berg
2007-08-21 15:57 ` [PATCH 3/3] mac80211: add interface index to key debugfs Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).