* [PATCH] b43: allow disabling hardware encryption
@ 2007-08-21 16:08 Johannes Berg
2007-08-21 22:22 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2007-08-21 16:08 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless
For debugging it seems useful to be able to turn off
hardware encryption. With the changes I made to mac80211
that is now simple.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/b43/main.c | 7 +++++++
1 file changed, 7 insertions(+)
--- wireless-dev.orig/drivers/net/wireless/b43/main.c 2007-08-21 16:41:30.955923881 +0200
+++ wireless-dev/drivers/net/wireless/b43/main.c 2007-08-21 16:47:46.175923881 +0200
@@ -96,6 +96,10 @@ static int modparam_hwpctl;
module_param_named(hwpctl, modparam_hwpctl, int, 0444);
MODULE_PARM_DESC(hwpctl, "Enable hardware-side power control (default off)");
+static int modparam_nohwcrypt;
+module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0644);
+MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
+
static const struct ssb_device_id b43_ssb_tbl[] = {
SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 5),
SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 6),
@@ -2850,6 +2854,9 @@ static int b43_dev_set_key(struct ieee80
u8 index;
int err = -EINVAL;
+ if (modparam_nohwcrypt)
+ return -ENOSPC;
+
if (!dev)
return -ENODEV;
switch (key->alg) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] b43: allow disabling hardware encryption
2007-08-21 16:08 [PATCH] b43: allow disabling hardware encryption Johannes Berg
@ 2007-08-21 22:22 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2007-08-21 22:22 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Tuesday 21 August 2007 18:08:18 Johannes Berg wrote:
> For debugging it seems useful to be able to turn off
> hardware encryption. With the changes I made to mac80211
> that is now simple.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> ---
> drivers/net/wireless/b43/main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- wireless-dev.orig/drivers/net/wireless/b43/main.c 2007-08-21 16:41:30.955923881 +0200
> +++ wireless-dev/drivers/net/wireless/b43/main.c 2007-08-21 16:47:46.175923881 +0200
> @@ -96,6 +96,10 @@ static int modparam_hwpctl;
> module_param_named(hwpctl, modparam_hwpctl, int, 0444);
> MODULE_PARM_DESC(hwpctl, "Enable hardware-side power control (default off)");
>
> +static int modparam_nohwcrypt;
> +module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0644);
> +MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
> +
> static const struct ssb_device_id b43_ssb_tbl[] = {
> SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 5),
> SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 6),
> @@ -2850,6 +2854,9 @@ static int b43_dev_set_key(struct ieee80
> u8 index;
> int err = -EINVAL;
>
> + if (modparam_nohwcrypt)
> + return -ENOSPC;
> +
> if (!dev)
> return -ENODEV;
> switch (key->alg) {
I queued this, although your mac80211 patch that changes the key
stuff is not in, yet. /me looks at John. :)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-21 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-21 16:08 [PATCH] b43: allow disabling hardware encryption Johannes Berg
2007-08-21 22:22 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).