From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/2] mac80211: allow drivers to indicate failed FCS/PLCP checksum
Date: Wed, 22 Aug 2007 21:11:03 +0200 [thread overview]
Message-ID: <200708222111.03164.IvDoorn@gmail.com> (raw)
In-Reply-To: <1187774561.4314.0.camel@johannes.berg>
On Wednesday 22 August 2007, Johannes Berg wrote:
> On Tue, 2007-08-21 at 23:07 +0200, Ivo van Doorn wrote:
>
> > Do we need another flag to indicate ICV errors?
> > rt2x00 has the following fields to indicate problems during hardware decryption:
> > ICV error -> How to report this to mac80211?
> > MIC error -> The RX_FLAG_MMIC_ERROR flag can be set
> > invalid key -> Could best be done by just not setting RX_FLAG_DECRYPTED I assume.
>
> I think you either just drop the packet or give it to mac80211 decrypted
> but with ICV still on so that mac80211 will verify the ICV (again) and
> do whatever is appropriate. But I think dropping it ought to be fine. Do
> we want this for monitoring maybe?
Not sure how interesting a frame with a ICV error will be,
on the other hand I am not even sure how a frame with a ICV error
looks like in rt2x00, discovering that will probably happen during
the hardware encryption implementation. ;)
Ivo
next prev parent reply other threads:[~2007-08-22 19:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 16:18 [RFC 0/2] the filter stuff again Johannes Berg
2007-08-21 16:18 ` [RFC 1/2] mac80211: allow drivers to indicate failed FCS/PLCP checksum Johannes Berg
2007-08-21 21:07 ` Ivo van Doorn
2007-08-22 9:22 ` Johannes Berg
2007-08-22 19:11 ` Ivo van Doorn [this message]
2007-08-23 14:13 ` Johannes Berg
2007-08-21 16:18 ` [RFC 2/2] mac80211: revamp interface and filter configuration Johannes Berg
2007-08-21 21:14 ` Ivo van Doorn
2007-08-22 9:23 ` Johannes Berg
2007-09-03 2:07 ` Daniel Drake
2007-09-03 8:36 ` Johannes Berg
2007-09-03 9:29 ` Johannes Berg
2007-09-03 10:57 ` Johannes Berg
2007-09-05 5:16 ` Ulrich Kunitz
2007-09-05 11:23 ` Johannes Berg
2007-09-05 14:16 ` Michael Buesch
2007-09-05 14:21 ` Johannes Berg
2007-09-05 14:23 ` Michael Wu
2007-09-05 14:33 ` Johannes Berg
2007-09-03 13:32 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2007-08-15 15:25 [RFC 0/2] device configuration changes Johannes Berg
2007-08-15 15:25 ` [RFC 1/2] mac80211: allow drivers to indicate failed FCS/PLCP checksum Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708222111.03164.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).