* Re: [PATCH 8/9] define global BIT macro [not found] ` <428714662539710215@wsc.cz> @ 2007-08-18 16:46 ` Randy Dunlap 2007-08-18 17:13 ` Jiri Slaby 2007-08-22 22:03 ` Ralf Baechle 1 sibling, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2007-08-18 16:46 UTC (permalink / raw) To: Jiri Slaby Cc: Andrew Morton, linux-kernel, source, dougthompson, bluesmoke-devel, dtor, linux-input, netdev, James.Bottomley, linux-scsi, gtolstolytkin, vitalywool, dsaxena, ralf, linux-mips, mchehab, video4linux-list, jbenc, flamingice, linux-wireless On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: > define global BIT macro > > move all local BIT defines to the new globally define macro. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > --- > > include/linux/bitops.h | 1 + > include/video/sstfb.h | 1 - > include/video/tdfx.h | 2 -- > net/mac80211/ieee80211_i.h | 2 -- > 18 files changed, 1 insertions(+), 37 deletions(-) > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index 3255b06..a57b81f 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -3,6 +3,7 @@ > #include <asm/types.h> > > #ifdef __KERNEL__ > +#define BIT(nr) (1UL << (nr)) > #define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG)) > #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) > #define BITS_TO_TYPE(nr, t) (((nr)+(t)-1)/(t)) So users of the BIT() macro in include/linux/input.h can be changed to use the global BIT_MASK() macro... and the former can be removed. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 8/9] define global BIT macro 2007-08-18 16:46 ` [PATCH 8/9] define global BIT macro Randy Dunlap @ 2007-08-18 17:13 ` Jiri Slaby 2007-08-18 18:15 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Jiri Slaby @ 2007-08-18 17:13 UTC (permalink / raw) To: Randy Dunlap Cc: Andrew Morton, linux-kernel, source, dougthompson, bluesmoke-devel, dtor, linux-input, netdev, James.Bottomley, linux-scsi, gtolstolytkin, vitalywool, dsaxena, ralf, linux-mips, mchehab, video4linux-list, jbenc, flamingice, linux-wireless Randy Dunlap napsal(a): > On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: > >> define global BIT macro >> >> move all local BIT defines to the new globally define macro. >> >> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> >> >> --- >> >> include/linux/bitops.h | 1 + >> include/video/sstfb.h | 1 - >> include/video/tdfx.h | 2 -- >> net/mac80211/ieee80211_i.h | 2 -- >> 18 files changed, 1 insertions(+), 37 deletions(-) >> >> diff --git a/include/linux/bitops.h b/include/linux/bitops.h >> index 3255b06..a57b81f 100644 >> --- a/include/linux/bitops.h >> +++ b/include/linux/bitops.h >> @@ -3,6 +3,7 @@ >> #include <asm/types.h> >> >> #ifdef __KERNEL__ >> +#define BIT(nr) (1UL << (nr)) >> #define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG)) >> #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) >> #define BITS_TO_TYPE(nr, t) (((nr)+(t)-1)/(t)) > > > So users of the BIT() macro in include/linux/input.h can be > changed to use the global BIT_MASK() macro... > and the former can be removed. I'm afraid I don't understand you. Maybe, you are writing about changes done in patch no. 7 [1], which didn't go through to the lkml? [1] http://www.fi.muni.cz/~xslaby/sklad/07-get-rid-of-input-bit-duplicate-defines.patch thanks, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 8/9] define global BIT macro 2007-08-18 17:13 ` Jiri Slaby @ 2007-08-18 18:15 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2007-08-18 18:15 UTC (permalink / raw) To: Jiri Slaby Cc: Andrew Morton, linux-kernel, source, dougthompson, bluesmoke-devel, dtor, linux-input, netdev, James.Bottomley, linux-scsi, gtolstolytkin, vitalywool, dsaxena, ralf, linux-mips, mchehab, video4linux-list, jbenc, flamingice, linux-wireless Jiri Slaby wrote: > Randy Dunlap napsal(a): >> On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: >> >>> define global BIT macro >>> >>> move all local BIT defines to the new globally define macro. >>> >>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> >>> >>> --- >>> >>> include/linux/bitops.h | 1 + >>> include/video/sstfb.h | 1 - >>> include/video/tdfx.h | 2 -- >>> net/mac80211/ieee80211_i.h | 2 -- >>> 18 files changed, 1 insertions(+), 37 deletions(-) >>> >>> diff --git a/include/linux/bitops.h b/include/linux/bitops.h >>> index 3255b06..a57b81f 100644 >>> --- a/include/linux/bitops.h >>> +++ b/include/linux/bitops.h >>> @@ -3,6 +3,7 @@ >>> #include <asm/types.h> >>> >>> #ifdef __KERNEL__ >>> +#define BIT(nr) (1UL << (nr)) >>> #define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG)) >>> #define BIT_WORD(nr) ((nr) / BITS_PER_LONG) >>> #define BITS_TO_TYPE(nr, t) (((nr)+(t)-1)/(t)) >> >> So users of the BIT() macro in include/linux/input.h can be >> changed to use the global BIT_MASK() macro... >> and the former can be removed. > > I'm afraid I don't understand you. Maybe, you are writing about changes done in > patch no. 7 [1], which didn't go through to the lkml? > > [1] > http://www.fi.muni.cz/~xslaby/sklad/07-get-rid-of-input-bit-duplicate-defines.patch Exactly. Thanks. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 8/9] define global BIT macro [not found] ` <428714662539710215@wsc.cz> 2007-08-18 16:46 ` [PATCH 8/9] define global BIT macro Randy Dunlap @ 2007-08-22 22:03 ` Ralf Baechle 1 sibling, 0 replies; 4+ messages in thread From: Ralf Baechle @ 2007-08-22 22:03 UTC (permalink / raw) To: Jiri Slaby Cc: Andrew Morton, linux-kernel, source, dougthompson, bluesmoke-devel, dtor, linux-input, netdev, James.Bottomley, linux-scsi, gtolstolytkin, vitalywool, dsaxena, linux-mips, mchehab, video4linux-list, jbenc, flamingice, linux-wireless On Sat, Aug 18, 2007 at 11:44:12AM +0200, Jiri Slaby wrote: > define global BIT macro > > move all local BIT defines to the new globally define macro. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Acked-by: Ralf Baechle <ralf@linux-mips.org> for the MACE ethernet and MIPS bits. Ralf ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-23 12:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <737828602404912540@wsc.cz>
[not found] ` <428714662539710215@wsc.cz>
2007-08-18 16:46 ` [PATCH 8/9] define global BIT macro Randy Dunlap
2007-08-18 17:13 ` Jiri Slaby
2007-08-18 18:15 ` Randy Dunlap
2007-08-22 22:03 ` Ralf Baechle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).