From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
John Linville <linville@tuxdriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: 2.6.23-rc3-mm1: net/wireless/rt2x00mac.c build failure
Date: Wed, 22 Aug 2007 22:22:12 +0200 [thread overview]
Message-ID: <200708222222.13618.rjw@sisk.pl> (raw)
In-Reply-To: <200708222212.52805.IvDoorn@gmail.com>
On Wednesday, 22 August 2007 22:12, Ivo van Doorn wrote:
> Hi,
>
> > CC [M] drivers/net/wireless/zd1211rw-mac80211/zd_mac.o
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: In function `zd_op_erp_ie_changed':
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: `IEEE80211_ERP_CHANGE_PREAMBLE' undeclared (first use in this function)
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: (Each undeclared identifier is reported only once
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: for each function it appears in.)
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: At top level:
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: error: unknown field `erp_ie_changed' specified in initializer
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: warning: initialization from incompatible pointer type
> > make[4]: *** [drivers/net/wireless/zd1211rw-mac80211/zd_mac.o] Error 1
> > make[3]: *** [drivers/net/wireless/zd1211rw-mac80211] Error 2
> > make[2]: *** [drivers/net/wireless] Error 2
> > make[1]: *** [drivers/net] Error 2
> > make: *** [drivers] Error 2
>
> I'm not a zd1211rw developer, but a quick look into the patch series it seems
> that the mac80211 version in -mm1 does not contain the patch
> [PATCH 4/4] mac80211: implement ERP info change notifications
> But it does contain the zd1211rw patch:
> [PATCH] zd1211rw-mac80211: use correct preambles for RTS/CTS frames
> Which depended on the above mentioned mac80211 patch.
>
> Just had a second thought about those rt2x00 compilation errors you reported,
> the error is not caused by rt2x00 lagging behind mac80211 api changes but
> that rt2x00 patches to follow the api changes are going upstream but
> the mac80211 api changes it depends on are not going anywhere.
>
> It seems that mac80211 has not been updated in the -mm tree while the
> drivers have been updated. This is causing the compilation errors for both
> rt2x00 as zd1211rw.
> I'll bet that if you try any other mac80211 driver similar issues will arise.
Yup. This also happens to the b43 driver, for example.
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-08-22 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070822020648.5ea3a612.akpm@linux-foundation.org>
2007-08-22 19:16 ` 2.6.23-rc3-mm1: net/wireless/rt2x00mac.c build failure Mariusz Kozlowski
2007-08-22 19:31 ` Ivo van Doorn
2007-08-22 19:54 ` Mariusz Kozlowski
2007-08-22 20:12 ` Ivo van Doorn
2007-08-22 20:22 ` Rafael J. Wysocki [this message]
2007-08-22 19:58 ` John W. Linville
2007-08-25 0:27 ` Ulrich Kunitz
2007-08-27 21:29 ` [-mm patch] iwl-base.c bugfixes Adrian Bunk
2007-08-27 22:34 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708222222.13618.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.kozlowski@tuxland.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).