From: David Miller <davem@davemloft.net>
To: matthew@wil.cx
Cc: shemminger@linux-foundation.org, johannes@sipsolutions.net,
voss@seehuhn.de, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, netdev@vger.kernel.org,
bridge@linux-foundation.org
Subject: Re: [PATCH] bridge: fix OOPS when bridging device without ethtool
Date: Thu, 30 Aug 2007 22:16:42 -0700 (PDT) [thread overview]
Message-ID: <20070830.221642.41875712.davem@davemloft.net> (raw)
In-Reply-To: <20070830164812.GW14130@parisc-linux.org>
From: Matthew Wilcox <matthew@wil.cx>
Date: Thu, 30 Aug 2007 10:48:13 -0600
> On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote:
> > Bridge code calls ethtool to get speed. The conversion to using
> > only ethtool_ops broke the case of devices without ethtool_ops.
> > This is a new regression in 2.6.23.
> >
> > Rearranged the switch to a logical order, and use gcc initializer.
> >
> > Ps: speed should have been part of the network device structure from
> > the start rather than burying it in ethtool.
>
> Feel free to do the conversion ;-) One of the things I like about the
> ethtool framework is it gives us a way to take stuff out of the drivers
> and put it in the midlayer without disturbing userspace.
>
> > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> Acked-by: Matthew Wilcox <matthew@wil.cx>
Applied, thanks!
next prev parent reply other threads:[~2007-08-31 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 22:37 oops with recent wireless-dev tree Jochen Voss
2007-08-30 12:05 ` Johannes Berg
[not found] ` <20070830074949.7cd25b04@freepuppy.rosehill.hemminger.net>
2007-08-30 14:58 ` Matthew Wilcox
2007-08-30 15:29 ` [PATCH] bridge: fix OOPS when bridging device without ethtool Stephen Hemminger
2007-08-30 16:48 ` Matthew Wilcox
2007-08-31 5:16 ` David Miller [this message]
2007-08-30 14:58 ` oops with recent wireless-dev tree Johannes Berg
2007-08-30 15:01 ` Johannes Berg
2007-08-30 15:45 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070830.221642.41875712.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=voss@seehuhn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).