From: Christoph Hellwig <hch@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Daniel Drake <dsd@gentoo.org>,
Ulrich Kunitz <kune@deine-taler.de>,
Tomas Winkler <tomasw@gmail.com>, Zhu Yi <yi.zhu@intel.com>
Subject: Re: COMMON symbol warnings
Date: Sat, 8 Sep 2007 14:01:18 +0100 [thread overview]
Message-ID: <20070908130118.GA11648@infradead.org> (raw)
In-Reply-To: <1189100314.28781.112.camel@johannes.berg>
On Thu, Sep 06, 2007 at 07:38:34PM +0200, Johannes Berg wrote:
> After my compile run with __CHECK_ENDIAN__ the modules were built and I
> got:
>
> WARNING: "iwl_param_debug" [drivers/net/wireless/iwl3945] is COMMON symbol
> WARNING: "iwl_param_disable_hw_scan" [drivers/net/wireless/iwl3945] is COMMON symbol
> WARNING: "iwl_param_hwcrypto" [drivers/net/wireless/iwl3945] is COMMON symbol
> WARNING: "iwl_param_antenna" [drivers/net/wireless/iwl3945] is COMMON symbol
> WARNING: "iwl_param_disable" [drivers/net/wireless/iwl3945] is COMMON symbol
> WARNING: "iwl_param_debug" [drivers/net/wireless/iwl4965] is COMMON symbol
> WARNING: "iwl_param_disable_hw_scan" [drivers/net/wireless/iwl4965] is COMMON symbol
> WARNING: "iwl_param_hwcrypto" [drivers/net/wireless/iwl4965] is COMMON symbol
> WARNING: "iwl_param_antenna" [drivers/net/wireless/iwl4965] is COMMON symbol
> WARNING: "iwl_param_disable" [drivers/net/wireless/iwl4965] is COMMON symbol
> WARNING: "zd_workqueue" [drivers/net/wireless/zd1211rw-mac80211/zd1211rw-mac80211] is COMMON symbol
> WARNING: "zd_workqueue" [drivers/net/wireless/zd1211rw/zd1211rw] is COMMON symbol
>
> any idea what that means?
Yes. It means a variable is declared in multiple places and the linker
merges it for you. The fix is to make sure these are declared extern in
all places but one.
next prev parent reply other threads:[~2007-09-08 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 17:38 COMMON symbol warnings Johannes Berg
2007-09-08 12:59 ` Ulrich Kunitz
2007-09-08 13:01 ` Christoph Hellwig [this message]
2007-09-08 16:35 ` Michael Buesch
2007-09-09 8:50 ` Ulrich Kunitz
2007-09-10 11:08 ` Johannes Berg
2007-09-10 12:14 ` Christoph Hellwig
2007-09-10 12:23 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070908130118.GA11648@infradead.org \
--to=hch@infradead.org \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).