From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tomas Winkler <tomasw@gmail.com>,
Ulrich Kunitz <kune@deine-taler.de>,
Daniel Drake <dsd@gentoo.org>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: zd-mac80211: Fix TX status reports.
Date: Tue, 11 Sep 2007 12:20:31 +0200 [thread overview]
Message-ID: <200709111220.31700.mb@bu3sch.de> (raw)
In-Reply-To: <1189505821.6161.1.camel@johannes.berg>
On Tuesday 11 September 2007 12:17:01 Johannes Berg wrote:
> > However I liked the idea about
> >
> > "An alternative option could be that the mac80211 stack would call
> > a non-atomic function of the driver to report the total count of
> > transmitted packets and the number of successful transmissions."
> >
> > This mechanism will help us to implement aggregation rate scaling
> > I would actually prefer if such statistics will be pushed by driver
> > rather then pulled by mac though.
>
> It doesn't help knowing whether the relevant packets were acked though.
What about the following:
We have a "the packet failed" IRQ. so we know that if that didn't
raise for a packet, it must have succeed.
So currently we already maintain a queue of TX packets. What about
changing the handling of this queue? Instead of dropping (and
telling mac80211 success) on an ACK RX, simply do a timeout.
We can calculate the time (plus some additional msecs to be sure)
by when an ACK must have arrived, no? So, if that times out,
signal a success. Wouldn't that be reliable? Given that the "tx failed"
IRQ actually _is_ reliable.
--
Greetings Michael.
next prev parent reply other threads:[~2007-09-11 10:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 21:41 zd-mac80211: Fix TX status reports Michael Buesch
2007-09-09 10:05 ` Ulrich Kunitz
2007-09-09 10:58 ` Michael Buesch
2007-09-10 10:52 ` Johannes Berg
2007-09-10 10:58 ` Michael Buesch
2007-09-10 11:10 ` Johannes Berg
2007-09-11 3:50 ` Tomas Winkler
2007-09-11 7:52 ` Daniel Drake
2007-09-11 10:03 ` Tomas Winkler
2007-09-11 10:17 ` Johannes Berg
2007-09-11 10:20 ` Michael Buesch [this message]
2007-09-11 10:29 ` Johannes Berg
2007-09-11 10:52 ` Michael Buesch
2007-09-11 10:57 ` Johannes Berg
2007-09-11 22:32 ` Ulrich Kunitz
2007-09-12 8:40 ` Tomas Winkler
2007-09-12 8:54 ` Johannes Berg
2007-09-12 8:56 ` Johannes Berg
2007-09-13 5:56 ` Ulrich Kunitz
2007-09-13 7:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709111220.31700.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).