Re: letting drivers choose their preferred rate scale

["John W. Linville" <linville@tuxdriver.com>]

On Mon, Sep 03, 2007 at 04:06:56PM +0200, ian wrote:
> Johannes Berg wrote:
> > On Mon, 2007-09-03 at 02:21 +0200, ian wrote:
> > 
> >> we could additionally remove the module_alias from rc80211_simple
> > 
> > indeed, please roll into this patch
> > 
> I don't know enough from debugfs yet, to do that part, but I'll read up.
> 
> ---
> Make rc80211_simple the default rate scaling algorithm

> @@ -78,11 +78,12 @@ static struct rate_control_ops *
>  ieee80211_rate_control_ops_get(const char *name)
>  {
>  	struct rate_control_ops *ops;
> +	const char *try_name = name ? name : "simple";
> 
> -	ops = ieee80211_try_rate_control_ops_get(name);
> +	ops = ieee80211_try_rate_control_ops_get(try_name);
>  	if (!ops) {
> -		request_module("rc80211_%s", name ? name : "default");
> -		ops = ieee80211_try_rate_control_ops_get(name);
> +		request_module("rc80211_%s", try_name);
> +		ops = ieee80211_try_rate_control_ops_get(try_name);
>  	}
>  	return ops;
>  }
> --- a/net/mac80211/rc80211_simple.c	2007-09-03 15:53:42.000000000 +0200
> +++ b/net/mac80211/rc80211_simple.c	2007-09-03 15:54:40.000000000 +0200
> @@ -29,7 +29,6 @@
>  #define RATE_CONTROL_INTERVAL (HZ / 20)
>  #define RATE_CONTROL_MIN_TX 10
> 
> -MODULE_ALIAS("rc80211_default");
> 
>  static void rate_control_rate_inc(struct ieee80211_local *local,
>  				  struct sta_info *sta)
 
Does this actually change anything?  With the MODULE_ALIAS line
in rc80211_simple.c, doesn't the request_module("rc80211_default")
just load rc80211_simple?

Confused...

John
-- 
John W. Linville
linville@tuxdriver.com