linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] softmac: Fix inability to associate with WEP networks, and the inability to change essid
Date: Wed, 19 Sep 2007 15:48:20 +0200	[thread overview]
Message-ID: <200709191548.20528.mb@bu3sch.de> (raw)
In-Reply-To: <46f090e4.wi04CrQ11sG6gLcC%Larry.Finger@lwfinger.net>

On Wednesday 19 September 2007 05:00:52 Larry Finger wrote:
> Commit 4cf92a3c was submitted as a fix for bug #8686 at bugzilla.kernel.org
> (http://bugzilla.kernel.org/show_bug.cgi?id=8686). Unfortunately, the fix led to
> a new bug, reported by Yoshifuji Hideaki, that prevented association for WEP
> encrypted networks that use ifconfig to control the device. This patch effectively
> reverts the earlier commit and does a proper fix for bug #8686.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> John,
> 
> This fix replaces my earlier request for reversion of commit 4cf92a3c. As stated
> above, it effectively does the reversion, but it also fixes the original bug.

Looks good and might be OK. Though, I won't ack this, as I don't really
understand the statemachine. So if it works and fixes both bugs, please merge
this into mainline and (more important) into -stable.

-- 
Greetings Michael.

      reply	other threads:[~2007-09-19 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19  3:00 [PATCH] softmac: Fix inability to associate with WEP networks, and the inability to change essid Larry Finger
2007-09-19 13:48 ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709191548.20528.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).