From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] b43: Change loglevel of radio-enable message.
Date: Thu, 20 Sep 2007 15:01:22 +0200 [thread overview]
Message-ID: <200709201501.22977.mb@bu3sch.de> (raw)
In-Reply-To: <46F26DAA.6070909@lwfinger.net>
On Thursday 20 September 2007, Larry Finger wrote:
> Michael Buesch wrote:
> > On Wednesday 19 September 2007 19:55:59 Larry Finger wrote:
> >> Michael Buesch wrote:
> >>> Also cleanup the code a bit and remove the inline.
> >>>
> >>> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >>> @@ -2214,7 +2229,7 @@ static int b43_chip_init(struct b43_wlde
> >>> b43_radio_turn_on(dev);
> >>> dev->radio_hw_enable = b43_is_hw_radio_enabled(dev);
> >>> b43dbg(dev->wl, "Radio %s by hardware\n", <========================
> >>> - (dev->radio_hw_enable == 0) ? "disabled" : "enabled");
> >>> + dev->radio_hw_enable ? "enabled" : "disabled");
> >> Shouldn't this one be b43info rather than b43dbg?
> >
> > No, I think it's really only interesting to see if it changed
> > in operation.
> > If it doesn't work, people will press their rfkill buttons
> > before even noticing this message on init. :)
>
> I have a suggestion to simplify the whole business of hardware radio control. Why don't we
> unconditionally set radio_hw_enable to one here and dispense with this message? That way, people
> without the rfkill switch will never see a message and those that do will only get messages if their
> switch is off, or if it is toggled.
Great idea, Larry!
I will implement that in an additional patch later.
Thanks.
prev parent reply other threads:[~2007-09-20 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 16:58 [PATCH] b43: Change loglevel of radio-enable message Michael Buesch
2007-09-19 17:55 ` Larry Finger
2007-09-19 17:57 ` Michael Buesch
2007-09-20 12:55 ` Larry Finger
2007-09-20 13:01 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709201501.22977.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).