linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Ulrich Kunitz <kune@deine-taler.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Daniel Drake <dsd@gentoo.org>,
	davem@davemloft.net, jeff@garzik.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: Please pull 'z1211' branch of wireless-2.6
Date: Sat, 22 Sep 2007 14:11:11 +0200	[thread overview]
Message-ID: <200709221411.12128.mb@bu3sch.de> (raw)
In-Reply-To: <20070922094800.GB12327@deine-taler.de>

On Saturday 22 September 2007 11:48:00 Ulrich Kunitz wrote:
> A real high-quality driver will require Johannes' proposed
> mac80211 driver interface changes to be merged and TX
> confirmations handled in a way, that the semantics can really be
> supported by the driver. (Michael Buesh's patch is taping over the
> issue.)

No it is not. It is fixing the issue. It fixes the following issues:
* You must ignore the Txstat-requested bit in the driver.
* You must report bad frames with the excessive_retries set.

The issue you are (most likely) talking about is that we can not
reliably tell whether a frame was good in the driver. That is a different
issue completely seperate from the two points above, which my patch fixes.

With my patch rate-controlling correctly works. Without it does not.

If you find a way to fix the reliable-detection-of-good-TX issue, that's
another good fix. But I think it's not release critical, because the
device works with the current "guessing-around" code. But without the two
points above fixed, it does not correctly work at all (unless you manually
tune to the best rate each time you move the machine).

-- 
Greetings Michael.

  reply	other threads:[~2007-09-22 12:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 18:10 Please pull 'z1211' branch of wireless-2.6 John W. Linville
2007-09-19 18:59 ` David Miller
2007-09-19 19:23   ` Michael Buesch
2007-09-19 19:56     ` David Miller
2007-09-19 20:12       ` David Miller
2007-09-19 22:08 ` Daniel Drake
2007-09-19 22:14   ` David Miller
2007-09-19 22:27     ` Daniel Drake
2007-09-19 22:32       ` David Miller
2007-09-20 13:47   ` John W. Linville
2007-09-20 14:28     ` Daniel Drake
2007-09-20 16:37       ` Larry Finger
2007-09-20 16:40         ` Johannes Berg
2007-09-22  9:48     ` Ulrich Kunitz
2007-09-22 12:11       ` Michael Buesch [this message]
2007-09-22 14:42         ` Ulrich Kunitz
2007-09-22 14:47           ` Michael Buesch
2007-09-19 22:12 ` Daniel Drake
2007-09-20 13:28   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709221411.12128.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=davem@davemloft.net \
    --cc=dsd@gentoo.org \
    --cc=jeff@garzik.org \
    --cc=kune@deine-taler.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).