From: Michael Buesch <mb@bu3sch.de>
To: David Miller <davem@davemloft.net>
Cc: johannes@sipsolutions.net, kune@deine-taler.de, dsd@gentoo.org,
linux-wireless@vger.kernel.org
Subject: Re: zd1211 or mac80211: SKB invalid truesize
Date: Tue, 25 Sep 2007 23:25:02 +0200 [thread overview]
Message-ID: <200709252325.03360.mb@bu3sch.de> (raw)
In-Reply-To: <20070925.141816.71108553.davem@davemloft.net>
On Tuesday 25 September 2007 23:18:16 David Miller wrote:
> From: Michael Buesch <mb@bu3sch.de>
> Date: Tue, 25 Sep 2007 22:42:11 +0200
>
> > I get dmesg spammed with the following message when
> > I connect to an open network with zd1211rw-mac80211.
> > I'm not sure if that's a bug in zd or mac80211.
> > Any idea how to debug this?
> >
> > [ 280.915811] SKB BUG: Invalid truesize (840) len=1440, sizeof(sk_buff)=168
> >
> > The device keeps working fine while this spams dmesg.
>
> For anyone who investigates this, the issue is that if there is a
> socket associated with an skb (ie. skb->sk is non-NULL) you cannot
> change the skb->truesize without also adjusting the memory accounted
> to the socket.
>
> Otherwise when the SKB gets freed, the wrong amount of socket buffer
> memory allocation will be given back to the socket.
>
> When the above message triggers, it means the skb->truesize is
> smaller than skb->len plus the size of struct sk_buff which is
> obviously completely bogus.
Yeah, well. But how can this happen? Someone assigning to skb->len?
zd1211 doesn't do this.
Any slight idea which (kind of) code could trigger this?
--
Greetings Michael.
next prev parent reply other threads:[~2007-09-25 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 20:42 zd1211 or mac80211: SKB invalid truesize Michael Buesch
2007-09-25 21:18 ` David Miller
2007-09-25 21:25 ` Michael Buesch [this message]
2007-09-25 21:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709252325.03360.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).