Error in compilation of b43

Error in compilation of b43

[Larry Finger]

Michael,

When I add your patch "b43: RF-kill support" to my source, I get the fo=
llowing compilation error:

  CC [M]  drivers/net/wireless/b43/rfkill.o
In file included from drivers/net/wireless/b43/rfkill.c:25:
drivers/net/wireless/b43/rfkill.h:17: error: field =E2=80=98notify_work=
=E2=80=99 has incomplete type
drivers/net/wireless/b43/rfkill.c: In function =E2=80=98b43_notify_rfki=
ll_press=E2=80=99:
drivers/net/wireless/b43/rfkill.c:31: warning: type defaults to =E2=80=98=
int=E2=80=99 in declaration of =E2=80=98__mptr=E2=80=99
drivers/net/wireless/b43/rfkill.c:31: warning: initialization from inco=
mpatible pointer type
drivers/net/wireless/b43/rfkill.c: In function =E2=80=98b43_rfkill_led_=
name=E2=80=99:
drivers/net/wireless/b43/rfkill.c:112: error: implicit declaration of f=
unction =E2=80=98rfkill_get_led_name=E2=80=99
drivers/net/wireless/b43/rfkill.c:112: warning: return makes pointer fr=
om integer without a cast

I assume that I missed some critical patch. Can you tell me which one i=
t is?

Thanks,

Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Error in compilation of b43

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Thu, 2007-09-27 at 23:38 -0500, Larry Finger wrote:

> drivers/net/wireless/b43/rfkill.c:112: error: implicit declaration of function ‘rfkill_get_led_name’
> drivers/net/wireless/b43/rfkill.c:112: warning: return makes pointer from integer without a cast
> 
> I assume that I missed some critical patch. Can you tell me which one it is?

Looks like "[PATCH] rfkill: Add support for an rfkill LED" might be it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: Error in compilation of b43

[Larry Finger]

Johannes Berg wrote:
> On Thu, 2007-09-27 at 23:38 -0500, Larry Finger wrote:
>=20
>> drivers/net/wireless/b43/rfkill.c:112: error: implicit declaration o=
f function =E2=80=98rfkill_get_led_name=E2=80=99
>> drivers/net/wireless/b43/rfkill.c:112: warning: return makes pointer=
 from integer without a cast
>>
>> I assume that I missed some critical patch. Can you tell me which on=
e it is?
>=20
> Looks like "[PATCH] rfkill: Add support for an rfkill LED" might be i=
t.

That patch fixed the implicit declaration of rfkill_get_led_name, but I=
 still get the other error

In file included from drivers/net/wireless/b43/rfkill.c:25:
drivers/net/wireless/b43/rfkill.h:17: error: field =E2=80=98notify_work=
=E2=80=99 has incomplete type
drivers/net/wireless/b43/rfkill.c: In function =E2=80=98b43_notify_rfki=
ll_press=E2=80=99:
drivers/net/wireless/b43/rfkill.c:31: warning: type defaults to =E2=80=98=
int=E2=80=99 in declaration of =E2=80=98__mptr=E2=80=99
drivers/net/wireless/b43/rfkill.c:31: warning: initialization from inco=
mpatible pointer type

Larry
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Error in compilation of b43

[Michael Buesch]

On Friday 28 September 2007 15:36:02 Larry Finger wrote:
> Johannes Berg wrote:
> > On Thu, 2007-09-27 at 23:38 -0500, Larry Finger wrote:
> >=20
> >> drivers/net/wireless/b43/rfkill.c:112: error: implicit declaration=
 of function =E2=80=98rfkill_get_led_name=E2=80=99
> >> drivers/net/wireless/b43/rfkill.c:112: warning: return makes point=
er from integer without a cast
> >>
> >> I assume that I missed some critical patch. Can you tell me which =
one it is?
> >=20
> > Looks like "[PATCH] rfkill: Add support for an rfkill LED" might be=
 it.
>=20
> That patch fixed the implicit declaration of rfkill_get_led_name, but=
 I still get the other error
>=20
> In file included from drivers/net/wireless/b43/rfkill.c:25:
> drivers/net/wireless/b43/rfkill.h:17: error: field =E2=80=98notify_wo=
rk=E2=80=99 has incomplete type
> drivers/net/wireless/b43/rfkill.c: In function =E2=80=98b43_notify_rf=
kill_press=E2=80=99:
> drivers/net/wireless/b43/rfkill.c:31: warning: type defaults to =E2=80=
=98int=E2=80=99 in declaration of =E2=80=98__mptr=E2=80=99
> drivers/net/wireless/b43/rfkill.c:31: warning: initialization from in=
compatible pointer type

The workqueue is removed by the other patch I just sent.

--=20
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html