* r2x00: Wrong rfkill inputdev poll interval
@ 2007-09-28 11:58 Michael Buesch
2007-09-28 18:49 ` Ivo van Doorn
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2007-09-28 11:58 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: linux-wireless
You pass the poll interval as (HZ/4), but the input
dev expects milliseconds instead of jiffies.
So a value of 250 would be right in your case.
Though, I think polling that often for this event might be overkill.
I'd say polling once a second should be OK for b43, for example.
We currenty also poll it only once per second.
But that's up to your choice. :)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: r2x00: Wrong rfkill inputdev poll interval
2007-09-28 11:58 r2x00: Wrong rfkill inputdev poll interval Michael Buesch
@ 2007-09-28 18:49 ` Ivo van Doorn
0 siblings, 0 replies; 2+ messages in thread
From: Ivo van Doorn @ 2007-09-28 18:49 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless
On Friday 28 September 2007, Michael Buesch wrote:
> You pass the poll interval as (HZ/4), but the input
> dev expects milliseconds instead of jiffies.
Oops. Thanks, I'll fix this immediately. :)
> So a value of 250 would be right in your case.
> Though, I think polling that often for this event might be overkill.
>
> I'd say polling once a second should be OK for b43, for example.
> We currenty also poll it only once per second.
> But that's up to your choice. :)
Yeah, I was not really sure what a nice timeout value should be.
I'll raise it to 1 second as well.
Thanks,
Ivo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-28 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-28 11:58 r2x00: Wrong rfkill inputdev poll interval Michael Buesch
2007-09-28 18:49 ` Ivo van Doorn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).