* [PATCH] b43: Leds spinlock SMP compilefix
@ 2007-09-29 22:04 Michael Buesch
2007-10-02 20:20 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Michael Buesch @ 2007-09-29 22:04 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, bcm43xx-dev, Larry Finger
This was missing an address operator.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: wireless-2.6/drivers/net/wireless/b43/leds.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/b43/leds.c 2007-09-29 12:44:08.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/b43/leds.c 2007-09-30 00:02:18.000000000 +0200
@@ -37,14 +37,14 @@ static void b43_led_turn_on(struct b43_w
unsigned long flags;
u16 ctl;
- spin_lock_irqsave(wl->leds_lock, flags);
+ spin_lock_irqsave(&wl->leds_lock, flags);
ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
if (activelow)
ctl &= ~(1 << led_index);
else
ctl |= (1 << led_index);
b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
- spin_unlock_irqrestore(wl->leds_lock, flags);
+ spin_unlock_irqrestore(&wl->leds_lock, flags);
}
static void b43_led_turn_off(struct b43_wldev *dev, u8 led_index,
@@ -54,14 +54,14 @@ static void b43_led_turn_off(struct b43_
unsigned long flags;
u16 ctl;
- spin_lock_irqsave(wl->leds_lock, flags);
+ spin_lock_irqsave(&wl->leds_lock, flags);
ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
if (activelow)
ctl |= (1 << led_index);
else
ctl &= ~(1 << led_index);
b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
- spin_unlock_irqrestore(wl->leds_lock, flags);
+ spin_unlock_irqrestore(&wl->leds_lock, flags);
}
/* Callback from the LED subsystem. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b43: Leds spinlock SMP compilefix
2007-09-29 22:04 [PATCH] b43: Leds spinlock SMP compilefix Michael Buesch
@ 2007-10-02 20:20 ` John W. Linville
2007-10-02 20:41 ` Michael Buesch
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2007-10-02 20:20 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless, bcm43xx-dev, Larry Finger
I'll just roll this into the "b43: LED triggers support" patch.
Thanks,
John
On Sun, Sep 30, 2007 at 12:04:36AM +0200, Michael Buesch wrote:
> This was missing an address operator.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Index: wireless-2.6/drivers/net/wireless/b43/leds.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/b43/leds.c 2007-09-29 12:44:08.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/b43/leds.c 2007-09-30 00:02:18.000000000 +0200
> @@ -37,14 +37,14 @@ static void b43_led_turn_on(struct b43_w
> unsigned long flags;
> u16 ctl;
>
> - spin_lock_irqsave(wl->leds_lock, flags);
> + spin_lock_irqsave(&wl->leds_lock, flags);
> ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
> if (activelow)
> ctl &= ~(1 << led_index);
> else
> ctl |= (1 << led_index);
> b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
> - spin_unlock_irqrestore(wl->leds_lock, flags);
> + spin_unlock_irqrestore(&wl->leds_lock, flags);
> }
>
> static void b43_led_turn_off(struct b43_wldev *dev, u8 led_index,
> @@ -54,14 +54,14 @@ static void b43_led_turn_off(struct b43_
> unsigned long flags;
> u16 ctl;
>
> - spin_lock_irqsave(wl->leds_lock, flags);
> + spin_lock_irqsave(&wl->leds_lock, flags);
> ctl = b43_read16(dev, B43_MMIO_GPIO_CONTROL);
> if (activelow)
> ctl |= (1 << led_index);
> else
> ctl &= ~(1 << led_index);
> b43_write16(dev, B43_MMIO_GPIO_CONTROL, ctl);
> - spin_unlock_irqrestore(wl->leds_lock, flags);
> + spin_unlock_irqrestore(&wl->leds_lock, flags);
> }
>
> /* Callback from the LED subsystem. */
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b43: Leds spinlock SMP compilefix
2007-10-02 20:20 ` John W. Linville
@ 2007-10-02 20:41 ` Michael Buesch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2007-10-02 20:41 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, bcm43xx-dev, Larry Finger
On Tuesday 02 October 2007 22:20:53 John W. Linville wrote:
> I'll just roll this into the "b43: LED triggers support" patch.
Yep, thanks a lot.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-02 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-29 22:04 [PATCH] b43: Leds spinlock SMP compilefix Michael Buesch
2007-10-02 20:20 ` John W. Linville
2007-10-02 20:41 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).