From: Michael Wu <flamingice@sourmilk.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Daniel Drake <dsd@gentoo.org>,
johannes@sipsolutions.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit
Date: Thu, 4 Oct 2007 17:26:11 -0400 [thread overview]
Message-ID: <200710041726.11744.flamingice@sourmilk.net> (raw)
In-Reply-To: <20071004180900.GG6037@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Thursday 04 October 2007 14:09, John W. Linville wrote:
> diff --git a/net/mac80211/ieee80211_iface.c
> b/net/mac80211/ieee80211_iface.c index be7e77f..6607b80 100644
> --- a/net/mac80211/ieee80211_iface.c
> +++ b/net/mac80211/ieee80211_iface.c
> @@ -106,7 +106,7 @@ void ieee80211_if_set_type(struct net_device *dev, int
> type) * which already has a hard_start_xmit routine assigned
> * which must not be changed.
> */
> - if (!dev->hard_start_xmit)
> + if (dev->type != ARPHRD_IEEE80211)
The standard way of checking for the master device is
dev == sdata->local->mdev
wme.c doesn't quite follow this but that code needs to die anyway.
This does look nicer than the other patch.
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-04 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071004113343.552139D502B@zog.reactivated.net>
2007-10-04 14:34 ` [PATCH] mac80211: Fix TX after monitor interface is converted to managed Michael Wu
2007-10-04 15:06 ` Michael Buesch
2007-10-04 15:14 ` Michael Wu
2007-10-04 15:19 ` John W. Linville
2007-10-04 17:11 ` Michael Wu
2007-10-04 18:15 ` John W. Linville
2007-10-04 21:16 ` Michael Wu
2007-10-04 21:31 ` Roland Dreier
2007-10-04 22:13 ` John W. Linville
2007-10-04 18:12 ` Johannes Berg
2007-10-04 15:54 ` Stephen Hemminger
2007-10-04 16:56 ` Michael Wu
2007-10-04 18:07 ` John W. Linville
2007-10-04 18:09 ` [PATCH] ieee80211_if_set_type: make check for master dev more explicit John W. Linville
2007-10-04 18:44 ` Johannes Berg
2007-10-04 19:13 ` John W. Linville
2007-10-05 12:01 ` Johannes Berg
2007-10-04 21:26 ` Michael Wu [this message]
2007-10-04 23:02 ` John W. Linville
2007-10-06 2:23 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710041726.11744.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).