From: "John W. Linville" <linville@tuxdriver.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Michael Wu <flamingice@sourmilk.net>,
Michael Buesch <mb@bu3sch.de>, Daniel Drake <dsd@gentoo.org>,
johannes@sipsolutions.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed
Date: Thu, 4 Oct 2007 18:13:58 -0400 [thread overview]
Message-ID: <20071004221358.GM6037@tuxdriver.com> (raw)
In-Reply-To: <ada4ph6bm8h.fsf@cisco.com>
On Thu, Oct 04, 2007 at 02:31:26PM -0700, Roland Dreier wrote:
> > Programming with assertions (and BUG_ON is a form of that) is
> > generally a good practice. Almost any book or other source on
> The problem with BUG_ON is that it kills the whole system. So every
> time you add a BUG_ON into code, you have to weigh whether the problem
> you detected is so severe that the right response is to panic. For
> example, I can see panicking on something fundamental like corrupted
> page tables. However I would submit that the wireless stack should
> *never* use BUG_ON -- printing a warning and trying to limp on seems
> preferable to me.
OK, I'll buy that as an argument to use WARN_ON instead of BUG_ON.
But it doesn't invalidate the desire to have some sort of assertion.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-10-04 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071004113343.552139D502B@zog.reactivated.net>
2007-10-04 14:34 ` [PATCH] mac80211: Fix TX after monitor interface is converted to managed Michael Wu
2007-10-04 15:06 ` Michael Buesch
2007-10-04 15:14 ` Michael Wu
2007-10-04 15:19 ` John W. Linville
2007-10-04 17:11 ` Michael Wu
2007-10-04 18:15 ` John W. Linville
2007-10-04 21:16 ` Michael Wu
2007-10-04 21:31 ` Roland Dreier
2007-10-04 22:13 ` John W. Linville [this message]
2007-10-04 18:12 ` Johannes Berg
2007-10-04 15:54 ` Stephen Hemminger
2007-10-04 16:56 ` Michael Wu
2007-10-04 18:07 ` John W. Linville
2007-10-04 18:09 ` [PATCH] ieee80211_if_set_type: make check for master dev more explicit John W. Linville
2007-10-04 18:44 ` Johannes Berg
2007-10-04 19:13 ` John W. Linville
2007-10-05 12:01 ` Johannes Berg
2007-10-04 21:26 ` Michael Wu
2007-10-04 23:02 ` John W. Linville
2007-10-06 2:23 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004221358.GM6037@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dsd@gentoo.org \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).