From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Wu <flamingice@sourmilk.net>, linux-wireless@vger.kernel.org
Subject: Re: mac80211: What is get_sequence_counter?
Date: Fri, 5 Oct 2007 16:06:06 +0200 [thread overview]
Message-ID: <200710051606.06382.mb@bu3sch.de> (raw)
In-Reply-To: <1191593004.7367.32.camel@johannes.berg>
On Friday 05 October 2007 16:03:24 Johannes Berg wrote:
> On Fri, 2007-10-05 at 15:56 +0200, Michael Buesch wrote:
> > What is the get_sequence_counter callback for?
> >
> > /* For devices that have internal sequence counters, allow 802.11
> > * code to access the current value of a counter */
> > int (*get_sequence_counter)(struct ieee80211_hw *hw,
> > u8* addr, u8 keyidx, u8 txrx,
> > u32* iv32, u16* iv16);
> >
> > It doesn't seem to be used in current mac80211 code.
> > It seems that this is to fetch the current initial values.
> > Is that correct?
> > Who is supposed to use this callback? If it's unused, let's remove
> > it please. The documentation for it sucks anyway. :)
>
> No, it's actually used in a patch I'm about to post:
> http://johannes.sipsolutions.net/patches/kernel/all/2007-09-28-22%3a38/017-mac80211-key-seq-nl80211.patch
>
> Mind you, it could be renamed and described better; it's used for
> getting the current sequence number of a hardware TKIP implementation.
Ah, ok. It sounded to me like it's supposed to fetch the
seq_ctrl counter (data header), if the device does frame sequence
counting in hw.
Can you please rename that to something like
get_tkip_ivs() or
get_tkip_counters()
or something like that?
--
Greetings Michael.
next prev parent reply other threads:[~2007-10-05 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 13:56 mac80211: What is get_sequence_counter? Michael Buesch
2007-10-05 14:03 ` Johannes Berg
2007-10-05 14:06 ` Michael Buesch [this message]
2007-10-05 14:24 ` Johannes Berg
2007-10-09 9:12 ` Johannes Berg
2007-10-09 13:52 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710051606.06382.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).