[PATCH] libertas: fix "warning: Using plain integer as NULL pointer" sparse warnings

[PATCH] libertas: fix "warning: Using plain integer as NULL pointer" sparse warnings

[Holger Schurig]

Subject says it all.

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Index: libertas-2.6/drivers/net/wireless/libertas/scan.c
===================================================================
--- libertas-2.6.orig/drivers/net/wireless/libertas/scan.c	
2007-10-08 12:40:31.000000000 +0200
+++ libertas-2.6/drivers/net/wireless/libertas/scan.c	2007-10-08 
12:40:41.000000000 +0200
@@ -578,7 +578,7 @@ static int wlan_scan_channel_list(wlan_p
 
 	lbs_deb_enter(LBS_DEB_ASSOC);
 
-	if (pscancfgout == 0 || pchantlvout == 0 || pscanchanlist == 0) 
{
+	if (pscancfgout == NULL || pchantlvout == NULL || pscanchanlist 
== NULL) {
 		lbs_deb_scan("Scan: Null detect: %p, %p, %p\n",
 		       pscancfgout, pchantlvout, pscanchanlist);
 		return -1;

Re: [PATCH] libertas: fix "warning: Using plain integer as NULL pointer" sparse warnings

[Holger Schurig]

Hmm, I had "wordwrap" turned on :-(

checkpatch.pl barks on this patch anyway, because of the
ridiculus 80 columns restriction it wants to impose. Should I 
rephrase the patch because of this or just ignore this 
checkpatch warning?

Re: [PATCH] libertas: fix "warning: Using plain integer as NULL pointer" sparse warnings

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Mon, 2007-10-08 at 11:47 +0200, Holger Schurig wrote:

> checkpatch.pl barks on this patch anyway, because of the
> ridiculus 80 columns restriction it wants to impose. Should I 
> rephrase the patch because of this or just ignore this 
> checkpatch warning?

Personally, I'd prefer it written as "extended booleans" anyway:

+       if (!pscancfgout || !pchantlvout || !pscanchanlist)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]