Re: [PATCH 2/6] ath5k: Enable radar detection

["Luis R. Rodriguez" <mcgrof@gmail.com>]

On Sun, Oct 07, 2007 at 03:28:12AM -0700, Nick Kossifidis wrote:
> Take a look here..
> http://thread.gmane.org/gmane.linux.drivers.madwifi.devel/4386/focus=4391

Of course I have tested this...

So far I haven't received one AR5K_INT_RXPHY interrupt yet. Mind you we
are already setting radar to 1 too -- we do this at the end of
ath_reset() with ath5k_hw_enable_radar_alert() -- so not sure what's
going on. I do live in front of a cemetery...

Anyway IMO we shouldn't handle radar detection but simply pass it down
to the upper layers, in this case mac80211. It seems for DFS this
would mean to force to change channels and blacklist the channel for
30 minutes. If this interrupt *does* prove to be very noisy we can 
simply disable the AR5K_RX_FILTER_RADARERR and even AR5K_RX_FILTER_PHYERR
later. Perhaps AR5K_RX_FILTER_RADARERR should be enabled during
configure_filter() through mac80211 to indicate when we do *need* DFS.
Right now AR5K_RX_FILTER_PHYERR is enabled when mac80211 tells us
about FIF_FCSFAIL | FIF_PLCPFAIL, we also keep the current 
hw settings on AR5K_PHY_ERR_FIL (AR5K_PHY_ERR_FIL_RADAR, 
AR5K_PHY_ERR_FIL_OFDM or AR5K_PHY_ERR_FIL_CCK).

Comments?

  Luis