Re: [PATCH 2.6.23.RC9] wpa_supplicant didn't work w/ wpa_secured hidden AP

Re: [PATCH 2.6.23.RC9] wpa_supplicant didn't work w/ wpa_secured hidden AP

[John W. Linville]

On Wed, Oct 10, 2007 at 11:26:54AM -0700, Abhijeet Kolekar wrote:
> This patch fixes the problem of associating with wpa_secured hidden
> ap.Please try out.
> 
> The original author of this patch is Bill Moss<bmoss@clemson.edu>
> 
> Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>

Wow...that is one busted patch...  Please avoid using editors that
convert tabs to whitespace.  Probably also need to account for existing
IEEE80211_SCAN_MATCH_SSID behavior...?

Still, the general idea looks fine and I'd really like to make
wpa_supplicant and mac80211 work together with hidden APs.  I'll fix-up
the patch and post it as a follow-up to this message...

John

P.S.  Is limiting this to STA mode correct?  Would wpa_supplicant
ever set that flag for an IBSS?
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH 2.6.23.RC9] wpa_supplicant didn't work w/ wpa_secured hidden AP

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On Wed, 2007-10-10 at 16:24 -0400, John W. Linville wrote:

> P.S.  Is limiting this to STA mode correct?  Would wpa_supplicant
> ever set that flag for an IBSS?

Regardless of whether wpa_supplicant does, the user can always do that
with iwlist. I think it should be done regardless of mode.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [ipw3945-devel] [PATCH 2.6.23.RC9] wpa_supplicant didn't work w/ wpa_secured hidden AP

[dragoran]

The patch seems not to work for me, I tested with 2.6.23-6.fc8 (where
the patch is included)... played with ap_scan ... disabled hw_scan but
I was unable to acciotate.

Re: [ipw3945-devel] [PATCH 2.6.23.RC9] wpa_supplicant didn't work w/ wpa_secured hidden AP

[John W. Linville]

On Fri, Oct 12, 2007 at 11:16:52AM +0200, dragoran wrote:
> The patch seems not to work for me, I tested with 2.6.23-6.fc8 (where
> the patch is included)... played with ap_scan ... disabled hw_scan but
> I was unable to acciotate.

Yeah, it seems like a no-op to me as well.  Does it actually help anyone?

-- 
John W. Linville
linville@tuxdriver.com