* [patch 7/8] b43 wireless needs <linux/io.h> [not found] <20071013123123.085686856@mail.of.borg> @ 2007-10-13 12:31 ` Geert Uytterhoeven 2007-10-13 15:21 ` Michael Buesch 2007-10-13 15:22 ` Larry Finger 0 siblings, 2 replies; 5+ messages in thread From: Geert Uytterhoeven @ 2007-10-13 12:31 UTC (permalink / raw) To: Linus Torvalds, Andrew Morton, Michael Buesch, Stefano Brivio Cc: linux-m68k, linux-kernel, linux-wireless b43 wireless needs <linux/io.h> linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/wireless/b43/phy.c | 1 + drivers/net/wireless/b43/pio.h | 1 + drivers/net/wireless/b43/sysfs.c | 5 +++-- 3 files changed, 5 insertions(+), 2 deletions(-) --- a/drivers/net/wireless/b43/phy.c +++ b/drivers/net/wireless/b43/phy.c @@ -26,6 +26,7 @@ */ #include <linux/delay.h> +#include <linux/io.h> #include <linux/types.h> #include "b43.h" --- a/drivers/net/wireless/b43/pio.h +++ b/drivers/net/wireless/b43/pio.h @@ -4,6 +4,7 @@ #include "b43.h" #include <linux/interrupt.h> +#include <linux/io.h> #include <linux/list.h> #include <linux/skbuff.h> --- a/drivers/net/wireless/b43/sysfs.c +++ b/drivers/net/wireless/b43/sysfs.c @@ -23,13 +23,14 @@ */ +#include <linux/capability.h> +#include <linux/io.h> + #include "b43.h" #include "sysfs.h" #include "main.h" #include "phy.h" -#include <linux/capability.h> - #define GENERIC_FILESIZE 64 static int get_integer(const char *buf, size_t count) -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 7/8] b43 wireless needs <linux/io.h> 2007-10-13 12:31 ` [patch 7/8] b43 wireless needs <linux/io.h> Geert Uytterhoeven @ 2007-10-13 15:21 ` Michael Buesch 2007-10-13 15:22 ` Larry Finger 1 sibling, 0 replies; 5+ messages in thread From: Michael Buesch @ 2007-10-13 15:21 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linus Torvalds, Andrew Morton, Stefano Brivio, linux-m68k, linux-kernel, linux-wireless, Larry Finger, John Linville On Saturday 13 October 2007 14:31:30 Geert Uytterhoeven wrote: > b43 wireless needs <linux/io.h> > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Michael Buesch <mb@bu3sch.de> Cc: Larry Finger <larry.finger@lwfinger.net> > --- > drivers/net/wireless/b43/phy.c | 1 + > drivers/net/wireless/b43/pio.h | 1 + > drivers/net/wireless/b43/sysfs.c | 5 +++-- > 3 files changed, 5 insertions(+), 2 deletions(-) > > --- a/drivers/net/wireless/b43/phy.c > +++ b/drivers/net/wireless/b43/phy.c > @@ -26,6 +26,7 @@ > */ > > #include <linux/delay.h> > +#include <linux/io.h> > #include <linux/types.h> > > #include "b43.h" > --- a/drivers/net/wireless/b43/pio.h > +++ b/drivers/net/wireless/b43/pio.h > @@ -4,6 +4,7 @@ > #include "b43.h" > > #include <linux/interrupt.h> > +#include <linux/io.h> > #include <linux/list.h> > #include <linux/skbuff.h> > > --- a/drivers/net/wireless/b43/sysfs.c > +++ b/drivers/net/wireless/b43/sysfs.c > @@ -23,13 +23,14 @@ > > */ > > +#include <linux/capability.h> > +#include <linux/io.h> > + > #include "b43.h" > #include "sysfs.h" > #include "main.h" > #include "phy.h" > > -#include <linux/capability.h> > - > #define GENERIC_FILESIZE 64 > > static int get_integer(const char *buf, size_t count) > -- Greetings Michael. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 7/8] b43 wireless needs <linux/io.h> 2007-10-13 12:31 ` [patch 7/8] b43 wireless needs <linux/io.h> Geert Uytterhoeven 2007-10-13 15:21 ` Michael Buesch @ 2007-10-13 15:22 ` Larry Finger 2007-10-13 18:38 ` Geert Uytterhoeven 1 sibling, 1 reply; 5+ messages in thread From: Larry Finger @ 2007-10-13 15:22 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linus Torvalds, Andrew Morton, Michael Buesch, linux-m68k, linux-kernel, linux-wireless Geert Uytterhoeven wrote: > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' >From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct? If so, I will probably need to prepare a similar patch for b43legacy. Thanks, Larry ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 7/8] b43 wireless needs <linux/io.h> 2007-10-13 15:22 ` Larry Finger @ 2007-10-13 18:38 ` Geert Uytterhoeven 2007-10-13 18:45 ` Michael Buesch 0 siblings, 1 reply; 5+ messages in thread From: Geert Uytterhoeven @ 2007-10-13 18:38 UTC (permalink / raw) To: Larry Finger Cc: Linus Torvalds, Andrew Morton, Michael Buesch, linux-m68k, linux-kernel, linux-wireless On Sat, 13 Oct 2007, Larry Finger wrote: > Geert Uytterhoeven wrote: > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' > > From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct? That's correct. > If so, I will probably need to prepare a similar patch for b43legacy. I had no problems compiling b43legacy on m68k, though. Probably <linux/io.h> was included through some other include file. Of course it's safer to always #include <linux/io.h> when using I/O. During linking, I did get a bunch of `undefined reference to `dma_*'' errors, with both b43 and b43legacy (and a few other drivers). Probably they need to depend on HAS_DMA. I'll post separate patches for those after I've sorted them out. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 7/8] b43 wireless needs <linux/io.h> 2007-10-13 18:38 ` Geert Uytterhoeven @ 2007-10-13 18:45 ` Michael Buesch 0 siblings, 0 replies; 5+ messages in thread From: Michael Buesch @ 2007-10-13 18:45 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Larry Finger, Linus Torvalds, Andrew Morton, linux-m68k, linux-kernel, linux-wireless On Saturday 13 October 2007 20:38:43 Geert Uytterhoeven wrote: > On Sat, 13 Oct 2007, Larry Finger wrote: > > Geert Uytterhoeven wrote: > > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' > > > > > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > > > linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' > > > > > > linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': > > > linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit declaration of function 'mmiowb' > > > > From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct? > > That's correct. > > > If so, I will probably need to prepare a similar patch for b43legacy. > > I had no problems compiling b43legacy on m68k, though. Probably > <linux/io.h> was included through some other include file. > Of course it's safer to always #include <linux/io.h> when using I/O. > > During linking, I did get a bunch of `undefined reference to `dma_*'' > errors, with both b43 and b43legacy (and a few other drivers). Probably > they need to depend on HAS_DMA. > I'll post separate patches for those after I've sorted them out. We could make the b43 and b43legacy DMA engine code depend on HAS_DMA then. So it can still be compiled with PIO. (Though, I don't know if anybody would put such a card into a machine without DMA, anyway). The DMA engine code is a seperate kconfig option. -- Greetings Michael. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-13 18:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071013123123.085686856@mail.of.borg>
2007-10-13 12:31 ` [patch 7/8] b43 wireless needs <linux/io.h> Geert Uytterhoeven
2007-10-13 15:21 ` Michael Buesch
2007-10-13 15:22 ` Larry Finger
2007-10-13 18:38 ` Geert Uytterhoeven
2007-10-13 18:45 ` Michael Buesch
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).