* Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value
@ 2007-10-15 12:54 Michael Buesch
2007-10-15 13:39 ` WANG Cong
2007-10-16 13:39 ` Larry Finger
0 siblings, 2 replies; 3+ messages in thread
From: Michael Buesch @ 2007-10-15 12:54 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, bcm43xx-dev, WANG Cong, Adrian Bunk
From: Adrian Bunk <bunk@kernel.org>
Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start()
in case of returning an uninitialized value.
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
drivers/net/wireless/b43/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
===================================================================
--- linux-2.6.23-mm1.orig/drivers/net/wireless/b43legacy/main.c
+++ linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
@@ -3306,7 +3306,7 @@ static int b43legacy_start(struct ieee80
struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
struct b43legacy_wldev *dev = wl->current_dev;
int did_init = 0;
- int err;
+ int err = 0;
mutex_lock(&wl->mutex);
-------------------------------------------------------
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value
2007-10-15 12:54 Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value Michael Buesch
@ 2007-10-15 13:39 ` WANG Cong
2007-10-16 13:39 ` Larry Finger
1 sibling, 0 replies; 3+ messages in thread
From: WANG Cong @ 2007-10-15 13:39 UTC (permalink / raw)
To: Michael Buesch
Cc: John Linville, linux-wireless, bcm43xx-dev, WANG Cong,
Adrian Bunk
On Mon, Oct 15, 2007 at 02:54:45PM +0200, Michael Buesch wrote:
>From: Adrian Bunk <bunk@kernel.org>
Adrian suggested to change this tag. So maybe the following is right.
Reported-by: Adrian Bunk <bunk@kernel.org>
<snip>
Thanks!
--
May the Source Be With You.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value
2007-10-15 12:54 Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value Michael Buesch
2007-10-15 13:39 ` WANG Cong
@ 2007-10-16 13:39 ` Larry Finger
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2007-10-16 13:39 UTC (permalink / raw)
To: Michael Buesch
Cc: John Linville, WANG Cong, Adrian Bunk, linux-wireless,
bcm43xx-dev
Michael Buesch wrote:
> From: Adrian Bunk <bunk@kernel.org>
>
> Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start()
> in case of returning an uninitialized value.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> ---
> drivers/net/wireless/b43/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43legacy/main.c
> +++ linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> @@ -3306,7 +3306,7 @@ static int b43legacy_start(struct ieee80
> struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
> struct b43legacy_wldev *dev = wl->current_dev;
> int did_init = 0;
> - int err;
> + int err = 0;
>
> mutex_lock(&wl->mutex);
>
>
>
> -------------------------------------------------------
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-16 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-15 12:54 Fwd: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value Michael Buesch
2007-10-15 13:39 ` WANG Cong
2007-10-16 13:39 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).