From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ug-out-1314.google.com ([66.249.92.172]:10843 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbXJWTy4 (ORCPT ); Tue, 23 Oct 2007 15:54:56 -0400 Received: by ug-out-1314.google.com with SMTP id z38so190731ugc for ; Tue, 23 Oct 2007 12:54:55 -0700 (PDT) To: Adrian Bunk Subject: Re: drivers/net/wireless/rt2x00/: struct data_desc strangeness Date: Tue, 23 Oct 2007 22:13:46 +0200 Cc: "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20071014175032.GI4211@stusta.de> <200710142106.20409.IvDoorn@gmail.com> <20071023194344.GX30533@stusta.de> In-Reply-To: <20071023194344.GX30533@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200710232213.47105.IvDoorn@gmail.com> (sfid-20071023_205502_812634_C0CA6C10) From: Ivo van Doorn Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, > > > I haven't checked whether it might work in all cases, but passing > > > non-zero values as second parameter to rt2x00_desc_{read,write}() > > > (as is done in many cases) is even in the best case bad coding style. > > > > Access to the array is correct, even with non-zero values the code that is > > reading/writing to the array knows the exact size of the descriptor. Within > > rt2x00 are however 5 drivers who have different descriptor sizes. That means > > I can't create a structure which has the correct array length. > > > > The structure itself is just a simple map over preallocated memory > > (skb->data in case of USB or dma in case of PCI). > > > > So possible solutions would be: > > - remove struct data_desc and make it a void* or __le32* > > This is at the cost of code readibility since the above pointers > > have less meaning then a pointer to a structure which can be nicely > > documented. > >... > > The worst is a wrong meaning. > __le32 word[1] is an array with _one_ element. > > And an __le32* can be used as an array. Ok. I'll fix this in 1 or 2 days. Ivo