From: "John W. Linville" <linville@tuxdriver.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
mcgrof@gmail.com, jirislaby@gmail.com
Subject: Re: [PATCH 1/2] ath5k: Maintain coding style
Date: Thu, 25 Oct 2007 22:43:48 -0400 [thread overview]
Message-ID: <20071026024348.GA14080@tuxdriver.com> (raw)
In-Reply-To: <20071021013630.GB5817@localhost.domain.invalid>
On Sun, Oct 21, 2007 at 01:36:30AM +0000, Nick Kossifidis wrote:
> * Sort functions in segments like we do on the rest of the code (eg.
> hw.c). This improves readability and maintainability.
>
> * Add myself as module author (a patch for this was submited some time
> ago as part of SFLC's changes but wasn't applied)
>
> * Declare that this driver is or 5xxx chipset series only in
> MODULE_SUPPORTED_DEVICE and MODULE_DESCRIPTION.
This patch and the next one do not apply. Further, after manually
fixing-up this patch it removes a bunch of functions that are still
used.
Would you mind re-diffing and trying again?
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-10-26 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 1:36 [PATCH 1/2] ath5k: Maintain coding style Nick Kossifidis
2007-10-26 2:43 ` John W. Linville [this message]
2007-10-26 9:28 ` [ath5k-devel] " Nick Kossifidis
2007-10-26 23:58 ` Nick Kossifidis
2007-10-27 12:49 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026024348.GA14080@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).