From: Michael Wu <flamingice@sourmilk.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>,
Dan Williams <dcbw@redhat.com>, dragoran <drago01@gmail.com>
Subject: Re: [RFC] mac80211: use IW_AUTH_PRIVACY_INVOKED rather than IW_AUTH_KEY_MGMT
Date: Thu, 1 Nov 2007 15:22:58 -0400 [thread overview]
Message-ID: <200711011523.03063.flamingice@sourmilk.net> (raw)
In-Reply-To: <1193671155.5197.71.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Monday 29 October 2007 11:19:15 Johannes Berg wrote:
> - if (ieee80211_sta_wep_configured(dev) !=
> - !!(bss->capability & WLAN_CAPABILITY_PRIVACY))
> + privacy = !!(bss->capability & WLAN_CAPABILITY_PRIVACY);
> + if ((ieee80211_sta_wep_configured(dev) != privacy) &&
> + !!((ifsta->flags & IEEE80211_STA_PRIVACY_INVOKED) != privacy))
!! for the wrong set of parenthesis, AFAICT.
-Michael Wu
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]
next prev parent reply other threads:[~2007-11-01 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 15:19 [RFC] mac80211: use IW_AUTH_PRIVACY_INVOKED rather than IW_AUTH_KEY_MGMT Johannes Berg
2007-11-01 19:22 ` Michael Wu [this message]
2007-11-02 9:49 ` Johannes Berg
2007-11-03 13:11 ` [PATCH] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711011523.03063.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=dcbw@redhat.com \
--cc=drago01@gmail.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox