linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC] ssb: Add code for SPROM Rev 4
Date: Mon, 5 Nov 2007 17:31:33 +0100	[thread overview]
Message-ID: <200711051731.33284.mb@bu3sch.de> (raw)
In-Reply-To: <472F3EE3.5040201@lwfinger.net>

On Monday 05 November 2007 17:03:47 Larry Finger wrote:
> 	u8 path_data0[SPROM_PATH_DATA_SIZE];
> 	u8 path_data1 ...
> 
> where SPROM_PATH_DATA_SIZE = 0x26. Once we see how the data are used, it may make more sense to have
> these data be u16,


> or even a union so that we can have it both ways. 
            ^^^^^                        ^^^^^^^^^

Whoops, endianess broken :)

> I'm not sure we need a separate "valid bit" for path data. In the sprom that we are working with,

Ok, even better then.
The "valid bit" was just an idea for stuff in the sprom which cannot
be determined valid or not in another way.

> As I said earlier, my current patch is working OK for present needs. Once we come to an agreement
> regarding the sprom data structures, I will begin implementing them. As I see it, conversion will be
> a 3-step process. We will need a patch to add the new structure, a second to populate that
> structure, patches to convert b44, b43, and b43legacy to use the new data, and a final patch to
> remove the old structure. In this manner, bisection will be supported.

cool :)

Are you going to try a redesign of the structure?
I'm not too motivated to do it, as I don't know too much about
the v4 sprom, yet.

-- 
Greetings Michael.

      reply	other threads:[~2007-11-05 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-03 15:19 [RFC] ssb: Add code for SPROM Rev 4 Larry Finger
2007-11-05 12:51 ` Michael Buesch
2007-11-05 16:03   ` Larry Finger
2007-11-05 16:31     ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711051731.33284.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).