Re: [RFC 1 of 6] ssb: Add new SPROM structure while keeping the old

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 06 November 2007 20:14:11 Larry Finger wrote:
> This is patch 1 of 6.
> 
> The SPROM's for various devices utilizing the Sonics Silicon Backplane come
> with various revisions. The Revision 2 SPROM inherited the data layout of 1, and
> Revision 3 inherited the layout of 2. The first instance of Revision 4 has
> now been found in a BCM4328 wireless LAN card. This device does not inherit any
> layout from previous versions. Although it was possible to create a data
> structure that kept all the old layouts, we decided to start fresh, keep only
> those SPROM variables that are used by the drivers that utilize ssb, and to
> do the conversion in such a manner that neither compilation or execution will
> be affected if a bisection lands in the middle of these changes, while keeping
> the patches as small as possible.
> 
> In this patch, the sprom structures are changed while maintaining the old ones.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> Index: wireless-2.6/include/linux/ssb/ssb.h
> ===================================================================
> --- wireless-2.6.orig/include/linux/ssb/ssb.h
> +++ wireless-2.6/include/linux/ssb/ssb.h
> @@ -78,8 +78,32 @@ struct ssb_sprom_r3 {
>  	u32 ofdmgpo;		/* G-PHY OFDM Power Offset */
>  };
>  
> -struct ssb_sprom_r4 {
> -	/* TODO */
> +struct ssb_sprom_data {
> +	u8 il0mac[6];		/* MAC address for 802.11b/g */
> +	u8 et0mac[6];		/* MAC address for Ethernet */
> +	u8 et1mac[6];		/* MAC address for 802.11a */
> +	u8 et0phyaddr:5;	/* MII address for enet0 */
> +	u8 et1phyaddr:5;	/* MII address for enet1 */

While we are at it, please also get rid of these ugly foo:X bitfields.

-- 
Greetings Michael.