From: Frank Lichtenheld <frank@lichtenheld.de>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: silence a bogus gcc warning
Date: Sun, 11 Nov 2007 10:27:03 +0100 [thread overview]
Message-ID: <20071111092703.GQ2961@planck.djpig.de> (raw)
In-Reply-To: <200711101727.43736.mb@bu3sch.de>
On Sat, Nov 10, 2007 at 05:27:43PM +0100, Michael Buesch wrote:
> On Saturday 10 November 2007 16:25:33 John W. Linville wrote:
> > On Sat, Nov 10, 2007 at 04:14:03PM +0100, Michael Buesch wrote:
> > > From: Frank Lichtenheld <frank@lichtenheld.de>
> > >=20
> > > inititalise ret to 0 to avoid the following bogus warning:
> > > CC [M] drivers/net/wireless/b43/debugfs.o
> > > drivers/net/wireless/b43/debugfs.c: In function =E2=80=98b43_debu=
gfs_read=E2=80=99:
> > > drivers/net/wireless/b43/debugfs.c:355: warning: =E2=80=98ret=E2=80=
=99 may be used uninitialized in this function
> > >=20
> > > Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> > > Signed-off-by: Michael Buesch <mb@bu3sch.de>
> >=20
> > Isn't this what uninitialized_var() is for?
Erh, I didn't actually knew that existed, sorry.
OTOH in this case it is actually longer to write.
> I'd be OK with that, too.
Should I send a changed patch?
Gruesse,
--=20
=46rank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-11-11 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 15:14 [PATCH] b43: silence a bogus gcc warning Michael Buesch
2007-11-10 15:25 ` John W. Linville
2007-11-10 16:27 ` Michael Buesch
2007-11-11 9:27 ` Frank Lichtenheld [this message]
2007-11-11 11:23 ` Michael Buesch
2007-11-12 10:12 ` Frank Lichtenheld
-- strict thread matches above, loose matches on Subject: below --
2007-11-09 8:13 [PATCH][B43]: " Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071111092703.GQ2961@planck.djpig.de \
--to=frank@lichtenheld.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).