Re: zd1211rw (2.6.22 sparc64): unaligned access (do_rx)

[David Miller <davem@davemloft.net>]

From: "John W. Linville" <linville@tuxdriver.com>
Date: Tue, 20 Nov 2007 17:08:50 -0500

> On Tue, Nov 20, 2007 at 01:58:42PM -0800, David Miller wrote:
> > From: Jean Tourrilhes <jt@hpl.hp.com>
> > Date: Tue, 20 Nov 2007 10:00:16 -0800
> > 
> > > 	This is a special version of Wireless Tools with some debug
> > > code. It will help me understand what's happening with the bus error
> > > while scanning and see what fix I can come up with.
> > > 	What you need to do is :
> > > 		o untar, make
> > > 		o ./iwlist scan > scan.log
> > > 	And send me the result.
> > 
> > I already know what's happening.  Your "fixup" code is deferencing
> > the wrong part of the iw_point pointer, it only works on little
> > endian.
> > 
> > The fix is to remove the userland fixup code entirely and fixup
> > the stream in the kernel.
> 
> What a mess...are there going to be userland ABI implications of this?
> Hopefully the fact that 64-bit kernels were just broken is enough
> justifcation to fix this?

I think we'll be OK, to my knowledge only the wireless tools
tried to "correct" this in userspace and it only triggers
when a specific length check fails.

So if we fix the kernel, the length check won't trigger any more
and things will just work.