Re: [PATCH v3] remove bcm43xx

[Stefano Brivio <stefano.brivio@polimi.it>]

On Tue, 20 Nov 2007 00:19:55 +0100
Andreas Schwab <schwab@suse.de> wrote:

> Stefano Brivio <stefano.brivio@polimi.it> writes:
> 
> > This is strange. Because it has been developed mainly on PPC. Plus, if
> > you could better define "does not work"
> 
> See <http://marc.info/?l=linux-wireless&m=119356497407301&w=2>.

It looks like we don't get a valid txstatus even if the txstatus indicator
register told us we could read it. The only difference I can see between
bcm43xx and b43 here is that in bcm43xx we allowed the whole register to be
non-zero, while in b43 we check a bit only (as per v4 specs). Would you
mind to try this:

--- drivers/net/wireless/b43/main.c.orig        2007-11-20 01:12:12.186524483 +0100
+++ drivers/net/wireless/b43/main.c     2007-11-20 01:12:34.922702865 +0100
@@ -947,7 +947,7 @@

        while (1) {
                v0 = b43_read32(dev, B43_MMIO_XMITSTAT_0);
-               if (!(v0 & 0x00000001))
+               if (!v0)
                        break;
                v1 = b43_read32(dev, B43_MMIO_XMITSTAT_1);

(probably it's not the solution, I just want to see what happens then).
BTW, what firmware are you using? Michael, any clue?


-- 
Ciao
Stefano