linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Tomas Winkler <tomasw@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Zhu Yi <yi.zhu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: coding style lesson: iwlwifi vs. endianness
Date: Wed, 28 Nov 2007 19:58:10 -0500	[thread overview]
Message-ID: <20071129005810.GA6161@tuxdriver.com> (raw)
In-Reply-To: <1196286192.4967.29.camel@localhost.localdomain>

On Wed, Nov 28, 2007 at 04:43:12PM -0500, Dan Williams wrote:
> On Wed, 2007-11-28 at 20:20 +0200, Tomas Winkler wrote:
> > If you would compose your email in less arrogant tone I would answer
> > you why your assumptions are wrong.
> > I know it is tempting to teach BIG Intel, but please try to keep good
> > spirit on this mailing list as it was so far.
> > Thanks
> > Tomas.
> 
> Ignoring the email tones and focusing on the problem, could you
> elaborate your reasons?  Doing endian conversions at the boundaries is
> quite a bit simpler and does lead to cleaner, more readable code.  The
> bulk of the work being done with a softmac card is in the driver +
> stack, so the clearer those are, the better for everyone.

ACK

While I can understand why you might think that Johannes was being
smug, I doubt if he really meant to be.  Please try to presume the
best intent. :-)

As Dan points-out, Johannes main point (i.e. convert data at system
boundaries) makes plenty of sense.  Please do take the time to tell
us what he is missing?

Thanks,

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-11-29  1:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 18:44 coding style lesson: iwlwifi vs. endianness Johannes Berg
2007-11-28 18:20 ` Tomas Winkler
2007-11-28 18:50   ` Johannes Berg
2007-11-28 21:43   ` Dan Williams
2007-11-29  0:58     ` John W. Linville [this message]
2007-11-29 23:02       ` Tomas Winkler
2007-12-10 11:42         ` Johannes Berg
2007-12-10 14:18           ` Tomas Winkler
2007-12-10 15:18             ` Johannes Berg
2007-12-10 15:30               ` Michael Buesch
2007-12-10 16:18                 ` Johannes Berg
2007-12-10 16:48                   ` Michael Buesch
2007-12-10 16:21                 ` Tomas Winkler
2007-12-10 16:25                   ` Johannes Berg
2007-12-10 21:18                     ` Tomas Winkler
2007-12-10 16:10               ` Tomas Winkler
2007-12-10 16:17                 ` Johannes Berg
2007-12-10 16:23                 ` Johannes Berg
2007-11-29  9:03   ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129005810.GA6161@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).