From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: linux-wireless@vger.kernel.org
Cc: "Tomas Winkler" <tomasw@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Zhu Yi" <yi.zhu@intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>
Subject: Re: coding style lesson: iwlwifi vs. endianness
Date: Thu, 29 Nov 2007 10:03:12 +0100 [thread overview]
Message-ID: <200711291003.12423.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1ba2fa240711281020n6052980cl610f6c790788d2da@mail.gmail.com>
> I know it is tempting to teach BIG Intel
Hmm, Intel is not the enemy or foe. It's actually quite liked,
because Intel is playing in many ways quite open and helpful
towards the OSS community. Having experienced openly
downloadable manuals for PXA processors from Intel and now the
barricaded website from Marvell, after they took over
PXA255/PXA270 ...
But back to the topic:
A driver that I happen to know quite well now is the
(non-mac80211) libertas in drivers/net/wireless/libertas/. And
this driver happens to use le16_to_cpu() and cpu_to_le16() all
over the place. Both in it's library part and in it's hardware
interface module (if_usb.c, if_cf.c, if_sdio.c).
That makes it easy to keep the thing "sparse"-clean. I wrote the
compact-flash code on x86. And others used that later on ARM and
MIPS (I'm going to use it on PXA as well). They didn't have a
endianness problem so far.
So, using that programming idiom paid well back.
prev parent reply other threads:[~2007-11-29 9:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:44 coding style lesson: iwlwifi vs. endianness Johannes Berg
2007-11-28 18:20 ` Tomas Winkler
2007-11-28 18:50 ` Johannes Berg
2007-11-28 21:43 ` Dan Williams
2007-11-29 0:58 ` John W. Linville
2007-11-29 23:02 ` Tomas Winkler
2007-12-10 11:42 ` Johannes Berg
2007-12-10 14:18 ` Tomas Winkler
2007-12-10 15:18 ` Johannes Berg
2007-12-10 15:30 ` Michael Buesch
2007-12-10 16:18 ` Johannes Berg
2007-12-10 16:48 ` Michael Buesch
2007-12-10 16:21 ` Tomas Winkler
2007-12-10 16:25 ` Johannes Berg
2007-12-10 21:18 ` Tomas Winkler
2007-12-10 16:10 ` Tomas Winkler
2007-12-10 16:17 ` Johannes Berg
2007-12-10 16:23 ` Johannes Berg
2007-11-29 9:03 ` Holger Schurig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711291003.12423.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).