Re: [RFC][PATCH] mac80211: Use PID controller for TX rate control

[Stefano Brivio <stefano.brivio@polimi.it>]

On Tue, 04 Dec 2007 09:15:03 +0100
Mattias Nissler <mattias.nissler@gmx.de> wrote:

> Um, if Nick says the device has problems transmitting frames, IMHO this
> will make it quite impossible to get the PID rate control right by
> tuning parameters. Of course you can set the failed frames percentage
> target to 100, but that's certainly not what we want.

Ok, sure. But to some degree, having problems in transmitting frames
because of driver issues is an approximation of a noisy environment.
However, we can't do so much in this specific case.

> Just an idea for your hack: wouldn't it be easier if we had all these
> parameters accessible via debugfs instead of module parameters? Also, it
> might be useful to have the parameters in sysfs so they can be changed
> also for production systems, once mac80211 is stable.

They are in sysfs. You just need to set perm to 0644. But this is racy, and
you should implement some locking, and I just didn't want to bother about
this. It's not racy, if you make sure that the interface is down while you
write parameters. Of course, if we want these parameters to get into
mac80211, proper locking should be implemented.


--
Ciao
Stefano