From: "John W. Linville" <linville@tuxdriver.com>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: Mattias Nissler <mattias.nissler@gmx.de>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [patch 4/9] mac80211: Make PID rate control algorithm the default
Date: Mon, 17 Dec 2007 15:41:12 -0500 [thread overview]
Message-ID: <20071217204112.GE3121@tuxdriver.com> (raw)
In-Reply-To: <20071217210649.370ba385@morte>
On Mon, Dec 17, 2007 at 09:06:49PM +0100, Stefano Brivio wrote:
> On Mon, 17 Dec 2007 10:02:02 -0500
> "John W. Linville" <linville@tuxdriver.com> wrote:
>
> > On Mon, Dec 17, 2007 at 02:25:21AM +0100, Mattias Nissler wrote:
> >
> > > config MAC80211_RCPID
> > > - bool "'PID' rate control algorithm" if EMBEDDED
> > > + bool "'PID' rate control algorithm"
> >
> > Shouldn't this keep the "if EMBEDDED"? Especially if it is going to be the default?
>
> How is EMBEDDED supposed to be related to this? Anyway, I'll go for the two
> modules approach, forcing one module to be selected.
As I recall, the "if EMBEDDED" was there basically to say "it should
always be built-in, but if you are trying to totally minimize your
footprint you can turn it off". Of course, that still would only
work if you had another rate control algorithm available e.g. the
iwlwifi drivers.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-12-17 20:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071217012517.882216322@gmx.de>
[not found] ` <20071217012549.932807027@gmx.de>
2007-12-17 11:46 ` [patch 1/9] mac80211: Clean up rate selection code Johannes Berg
2007-12-17 21:07 ` Mattias Nissler
2007-12-18 13:17 ` Johannes Berg
2007-12-18 19:12 ` Mattias Nissler
[not found] ` <20071217012550.045470580@gmx.de>
2007-12-17 11:48 ` [patch 2/9] iwlwifi: Resync rate control code with mac80211 Johannes Berg
2007-12-17 21:07 ` Mattias Nissler
[not found] ` <20071217012550.127484236@gmx.de>
2007-12-17 11:50 ` [patch 3/9] mac80211: Add PID controller based rate control algorithm Johannes Berg
2007-12-17 21:08 ` Mattias Nissler
2007-12-18 12:50 ` Johannes Berg
[not found] ` <20071217012550.213561122@gmx.de>
2007-12-17 11:52 ` [patch 4/9] mac80211: Make PID rate control algorithm the default Johannes Berg
2007-12-17 21:12 ` Mattias Nissler
2007-12-17 15:02 ` John W. Linville
2007-12-17 20:06 ` Stefano Brivio
2007-12-17 20:41 ` John W. Linville [this message]
2007-12-17 21:16 ` Stefano Brivio
2007-12-18 12:49 ` Johannes Berg
2007-12-18 20:01 ` Mattias Nissler
2007-12-19 16:05 ` Johannes Berg
[not found] ` <20071217012550.464889334@gmx.de>
2007-12-17 11:57 ` [patch 7/9] mac80211: Dump rc80211_pid events to debugfs Johannes Berg
2007-12-17 21:09 ` Mattias Nissler
[not found] ` <20071217012550.634829179@gmx.de>
2007-12-17 12:02 ` [patch 9/9] mac80211: Publish rc80211_pid parameters in debugfs Johannes Berg
2007-12-17 21:09 ` Mattias Nissler
2007-12-17 0:19 [patch 0/9] Rate control rework mattias.nissler
[not found] ` <20071217002056.351743954@gmx.de>
2007-12-17 0:49 ` [patch 4/9] mac80211: Make PID rate control algorithm the default Johannes Berg
2007-12-17 0:50 ` Stefano Brivio
2007-12-17 0:54 ` Johannes Berg
2007-12-17 0:57 ` Stefano Brivio
2007-12-17 1:09 ` Johannes Berg
2007-12-17 9:56 ` Mattias Nissler
2007-12-17 14:48 ` John W. Linville
2007-12-17 17:42 ` Johannes Berg
2007-12-17 9:51 ` Mattias Nissler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217204112.GE3121@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mattias.nissler@gmx.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).