From: Arnd Bergmann <ARNDB@de.ibm.com>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Akinobu Mita <akinobu.mita@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mattias Nissler <mattias.nissler@gmx.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH v4 7/8] debugfs: allow access to signed values
Date: Thu, 20 Dec 2007 13:47:13 +0100 [thread overview]
Message-ID: <200712201347.15022.ARNDB@de.ibm.com> (raw)
In-Reply-To: <20071220131548.1d09cd62@morte>
On Thursday 20 December 2007, Stefano Brivio wrote:
> debugfs: allow access to signed values
>
> Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove
> a cast in libfs, change the simple_attr_open prototype and thus fix the users as
> well.
>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Mattias Nissler <mattias.nissler@gmx.de>
> To: Greg Kroah-Hartman <gregkh@suse.de>
> To: Arnd Bergmann <arndb@de.ibm.com>
> To: Akinobu Mita <akinobu.mita@gmail.com>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Have you checked that spufs still builds? I would guess that you need
to do the same interface changes there.
Also, Christoph has recently posted a suggestion for how to improve
the interface to allow the 'get' operation to return an error:
http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962
I'd suggest consolidating the two changes in order to avoid merge
conflicts.
Arnd <><
next prev parent reply other threads:[~2007-12-20 12:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071219001955.055692620@polimi.it>
2007-12-19 0:25 ` [PATCH v3 1/8] mac80211: clean up rate selection Stefano Brivio
2007-12-19 16:42 ` Johannes Berg
2007-12-20 12:50 ` [PATCH v4 " Stefano Brivio
2007-12-19 0:25 ` [PATCH v3 2/8] mac80211: add PID controller based rate control algorithm Stefano Brivio
2007-12-19 0:26 ` [PATCH v3 3/8] mac80211: make PID rate control algorithm the default Stefano Brivio
2007-12-19 0:26 ` [PATCH v3 4/8] rc80211-pid: add rate behaviour learning algorithm Stefano Brivio
2007-12-19 0:26 ` [PATCH v3 5/8] rc80211-pid: add sharpening factor Stefano Brivio
2007-12-19 0:27 ` [PATCH v3 6/8] rc80211-pid: add debugging Stefano Brivio
2007-12-19 0:27 ` [PATCH v3 7/8] debugfs: allow access to signed values Stefano Brivio
2007-12-19 6:45 ` Greg KH
2007-12-19 9:20 ` Stefano Brivio
2007-12-19 14:29 ` John W. Linville
2007-12-19 9:28 ` [PATCH v4 " Stefano Brivio
2007-12-19 16:00 ` [PATCH v3 " Johannes Berg
2007-12-20 12:15 ` [PATCH v4 " Stefano Brivio
2007-12-20 12:47 ` Arnd Bergmann [this message]
2007-12-28 18:58 ` Christoph Hellwig
2007-12-28 19:15 ` Johannes Berg
2007-12-29 18:20 ` Stefano Brivio
2007-12-20 12:40 ` [PATCH v5 " Stefano Brivio
2007-12-20 14:34 ` John W. Linville
2007-12-19 0:27 ` [PATCH v3 8/8] rc80211-pid: export tuning parameters through debugfs Stefano Brivio
2007-12-19 16:49 ` Johannes Berg
2007-12-20 12:27 ` [PATCH v4 " Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712201347.15022.ARNDB@de.ibm.com \
--to=arndb@de.ibm.com \
--cc=akinobu.mita@gmail.com \
--cc=gregkh@suse.de \
--cc=hch@lst.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mattias.nissler@gmx.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).