From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: Larry Finger <larry.finger@lwfinger.net>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Only select allowed TX and RX antennas
Date: Sat, 22 Dec 2007 23:08:05 +0100 [thread overview]
Message-ID: <200712222308.05818.mb@bu3sch.de> (raw)
In-Reply-To: <476D87DA.5030908@lwfinger.net>
On Saturday 22 December 2007 22:55:38 Larry Finger wrote:
> Michael Buesch wrote:
> > This fixes antenna selection in b43. It adds a sanity check
> > for the antenna numbers we get from mac80211.
> >=20
> > This patch depends on
> > [PATCH] ssb: Fix extraction of values from SPROM
> >=20
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>=20
> After applying the 4 patches you sent earlier, the compilation fails =
with
>=20
> CC [M] drivers/ssb/main.o
> drivers/net/wireless/b43/main.c: In function =E2=80=98b43_ieee80211_a=
ntenna_sanitize=E2=80=99:
> drivers/net/wireless/b43/main.c:2720: error: =E2=80=98struct ssb_spro=
m=E2=80=99 has no member named =E2=80=98ant_available_bg=E2=80=99
> drivers/net/wireless/b43/main.c:2722: error: =E2=80=98struct ssb_spro=
m=E2=80=99 has no member named =E2=80=98ant_available_a=E2=80=99
>=20
> These members of ssb_sprom are defined in the patch you sent to Felix=
Fietkau on Dec. 10, but not in
> this patch set.
This patch was included in the series I just sent.
[PATCH] ssb: Fix extraction of values from SPROM
> Index: wireless-2.6/include/linux/ssb/ssb.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- wireless-2.6.orig/include/linux/ssb/ssb.h 2007-12-14
> 13:15:42.000000000 +0100 +++ wireless-2.6/include/linux/ssb/ssb.h =
=20
> 2007-12-20 18:58:49.000000000 +0100 @@ -22,7 +22,12 @@ struct ssb_spr=
om {
> u8 et1mac[6]; /* MAC address for 802.11a */
> u8 et0phyaddr; /* MII address for enet0 */
> u8 et1phyaddr; /* MII address for enet1 */
> + u8 et0mdcport; /* MDIO for enet0 */
> + u8 et1mdcport; /* MDIO for enet1 */
> + u8 board_rev; /* Board revision number from SPROM. =
*/
> u8 country_code; /* Country Code */
> + u8 ant_available_a; /* A-PHY antenna available bits (up t=
o 4)
> + u8 ant_available_bg; /* B/G-PHY antenna available bits (up=
to
--=20
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-22 22:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 20:54 [PATCH] b43: Only select allowed TX and RX antennas Michael Buesch
2007-12-22 21:55 ` Larry Finger
2007-12-22 22:08 ` Michael Buesch [this message]
2007-12-22 22:29 ` Larry Finger
2007-12-23 3:10 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712222308.05818.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).